Improve company productivity with a Business Account.Sign Up

x
?
Solved

MS SQL 2000 Function ' DATEADD ' Problem

Posted on 2007-11-25
8
Medium Priority
?
3,006 Views
Last Modified: 2010-04-21
Hello Experts,
I'm Using MS SQL2000

What the different between following spTestRPT1.sql and spTestRPT2.sql ?

spTestRPT1.sql  Doesnt like  DATEADD("hh",23,@p_DateTo_IN)
spTestRPT2.sql Doesnt mind either DATEADD("hh",23,@p_DateTo_IN) or DATEADD(hh,23,@p_DateTo_IN)
Error Message for spTestRPT1.sql
Server: Msg 1023, Level 15, State 1, Procedure spTestRPT1, Line 30
Invalid parameter 1 specified for dateadd.

Whats the reason for this? Anything to do with header? Well I try switching header information as well.
Its not a big issue since I figure it out one work without quotation mark. But whats the reason for this?
Udana


spTestRPT1.sql
 
if exists (select * from dbo.sysobjects where id = object_id(N'[dbo].[spTestRPT1]') and OBJECTPROPERTY(id, N'IsProcedure') = 1)
drop procedure [dbo].[spTestRPT1]
GO
 
SET QUOTED_IDENTIFIER OFF 
GO
SET ANSI_NULLS ON 
GO
 
CREATE Procedure spTestRPT1
(
	@p_LoginContactId_IN integer,
	@p_DateFrom_IN datetime,
	@p_DateTo_IN datetime,
	@p_StateID_IN integer,
	@p_NetworkID_IN integer
)
AS 
 
SET @p_DateTo_IN = DATEADD(hh,23,@p_DateTo_IN) 
SET @p_DateTo_IN = DATEADD(mi,59,@p_DateTo_IN)
SET @p_DateTo_IN = DATEADD(ss,59,@p_DateTo_IN)
 
 
 
 
---> Continues
 
spTestRPT2.sql
 
 
USE TEST
Go
-----
IF EXISTS (SELECT '*' 
           FROM sysobjects 
           WHERE ID = object_id('[dbo].[spTestRPT2]') 
          and OBJECTPROPERTY(ID, 'IsProcedure') = 1)
DROP PROCEDURE [dbo].[spTestRPT2]
GO
 
CREATE PROCEDURE spTestRPT2
(
	@p_LoginContactId_IN 	integer,
	@p_StatusID_IN  	as smallint,		---4
	@p_DateFrom_IN		as datetime,		---8
	@p_DateTo_IN 		as datetime		---9
 
)
 AS
 
SET @p_DateTo_IN = DATEADD("hh",23,@p_DateTo_IN)
SET @p_DateTo_IN = DATEADD("mi",59,@p_DateTo_IN)
SET @p_DateTo_IN = DATEADD("ss",59,@p_DateTo_IN)
 
---> continues

Open in new window

0
Comment
Question by:udanabanana
8 Comments
 
LVL 7

Expert Comment

by:Alpha Au
ID: 20347909
According to the example used in MSDN
http://msdn2.microsoft.com/en-us/library/aa258267(SQL.80).aspx

the dateparts Is the parameter that specifies on which part of the date to return a new value.
The table lists the dateparts and abbreviations recognized by Microsoft® SQL Server™.

that's mean it does not need double quote
0
 
LVL 6

Expert Comment

by:PaultheBroker
ID: 20347971
I think that SET QUOTED_IDENTIFIER ON (the default behaviour) will produce the beahvoiur you are seeing in RPT2 - I can't answer why the flag was reset between the two create statements, if you've provided a full listing....as you set it OFF for the RPT1
0
 
LVL 6

Assisted Solution

by:PaultheBroker
PaultheBroker earned 200 total points
ID: 20347976
0
What Kind of Coding Program is Right for You?

There are many ways to learn to code these days. From coding bootcamps like Flatiron School to online courses to totally free beginner resources. The best way to learn to code depends on many factors, but the most important one is you. See what course is best for you.

 
LVL 6

Expert Comment

by:PaultheBroker
ID: 20348027
... ok, I now see you tried changing the header round, and this had no effect... I give up...what's the answer??? :)
0
 
LVL 25

Accepted Solution

by:
imitchie earned 1800 total points
ID: 20348166
Looking at the header information, I hazard a guess that spTestRPT1 has a matching

SET ANSI_NULLS OFF
GO
SET QUOTED_IDENTIFIER ON
GO

at the bottom.  (part of the ..continues.. that you have omitted)

When SET QUOTED_IDENTIFIER is ON, identifiers can be delimited by double quotation marks, and literals must be delimited by single quotation marks. When SET QUOTED_IDENTIFIER is OFF, identifiers cannot be quoted and must follow all Transact-SQL rules for identifiers.

The better way to use DATEADD is NOT to quote the first parameter.  What SQL Server 2005 _allows_ you to do is quote it, provided SET QUOTED_IDENTIFIER is ON.
0
 

Author Comment

by:udanabanana
ID: 20348375
imitchie
you are correct! Thanks mate.
Udana
IF @@rowcount = 1
BEGIN	
	SELECT @@identity
    	RETURN 0
END
ELSE
    	RETURN 1
 
 
GO
SET QUOTED_IDENTIFIER OFF 
GO
SET ANSI_NULLS ON 
GO
 
GRANT  EXECUTE  ON [dbo].[spTestRPT1]  TO [TEST_USER]
GO

Open in new window

0
 

Author Comment

by:udanabanana
ID: 20348383
Thanks Guys for the Help.
0
 

Author Closing Comment

by:udanabanana
ID: 31410908
450 points  to imitichie for the explaination.
50 points to PaultheBroker for valuable link.
0

Featured Post

What Kind of Coding Program is Right for You?

There are many ways to learn to code these days. From coding bootcamps like Flatiron School to online courses to totally free beginner resources. The best way to learn to code depends on many factors, but the most important one is you. See what course is best for you.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

When trying to connect from SSMS v17.x to a SQL Server Integration Services 2016 instance or previous version, you get the error “Connecting to the Integration Services service on the computer failed with the following error: 'The specified service …
This article will show a step by step guide on how to mask column values in Oracle 12c using DBMS_REDACT full redaction option. This option is available on licensed Oracle Enterprise edition as part of Oracle's Advanced Security.
Using examples as well as descriptions, and references to Books Online, show the documentation available for date manipulation functions and by using a select few of these functions, show how date based data can be manipulated with these functions.
Viewers will learn how to use the INSERT statement to insert data into their tables. It will also introduce the NULL statement, to show them what happens when no value is giving for any given column.

579 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question