[2 days left] What’s wrong with your cloud strategy? Learn why multicloud solutions matter with Nimble Storage.Register Now

x
?
Solved

SQL update question

Posted on 2007-11-26
4
Medium Priority
?
238 Views
Last Modified: 2010-04-21
I have a table with 2 columns. Column1 is given and sorted ascending, what i need to do is update column2 with corresponding values.  Column 2 just should increment by one and reset to one when the value in column1 changes.



Col1      Col2
1      1
1      2
1      3
1      4
1      5
2      1
2      2
2      3
2      4
3      1
3      2
3      3
3      4
3      5
3      6
3      7
3      8
3      9
3      10


Thanks
sopheak
0
Comment
Question by:sopheak
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
4 Comments
 
LVL 18

Expert Comment

by:Yveau
ID: 20353479
Here goes:

Hope this helps ...

-- creating original situation
create table #Y(Col1 int,Col2 int)
go
 
insert into #Y values(1, NULL)
insert into #Y values(1, NULL)
insert into #Y values(1, NULL)
insert into #Y values(1, NULL)
insert into #Y values(1, NULL)
insert into #Y values(2, NULL)
insert into #Y values(2, NULL)
insert into #Y values(2, NULL)
insert into #Y values(2, NULL)
insert into #Y values(3, NULL)
insert into #Y values(3, NULL)
insert into #Y values(3, NULL)
insert into #Y values(3, NULL)
insert into #Y values(3, NULL)
insert into #Y values(3, NULL)
insert into #Y values(3, NULL)
insert into #Y values(3, NULL)
insert into #Y values(3, NULL)
insert into #Y values(3, NULL)
go
 
-- actual code starts here
alter table #Y
add col3 int identity(1,1)
go
 
declare @c1 int
declare @c1p int
declare @c3 int
declare @c2 int
 
declare Yveau cursor
for
select col1, col3
from  #Y
 
open yveau
fetch yveau
into @c1, @c3
 
while @@fetch_status = 0
begin
        if isnull(@c1p,-1) != @c1
        begin
                set @c2 = 1
        end
        else
        begin
                set @c2 = @c2 + 1
        end
 
        update #y
        set    col2 = @c2
        where  col3 = @c3
 
        set @c1p = @c1
 
        fetch yveau
        into @c1, @c3
end
 
close yveau
deallocate yveau
 
alter table #Y
drop column col3
 
select * from #Y
 
-->> result:
Col1        Col2
----------- -----------
1           1
1           2
1           3
1           4
1           5
2           1
2           2
2           3
2           4
3           1
3           2
3           3
3           4
3           5
3           6
3           7
3           8
3           9
3           10
 
--

Open in new window

0
 
LVL 18

Expert Comment

by:Yveau
ID: 20353492
To be completely perfect, the cursor should have been declared like this:

Hope this helps ...

declare Yveau cursor
for
select col1, col3 
from #Y 
order by col3 asc
 
--

Open in new window

0
 
LVL 35

Accepted Solution

by:
David Todd earned 720 total points
ID: 20354290
Hi,

Avoid cursors like the plauge ...

If you are using SQL 2005, look at the row_number() function.

If you are using SQl 2000 or earlier, then I'd use a temp table with an identity to uniquely identify those rows and then build an update statement, rather than using a loop or cursor.

HTH
  David
use tempdb
go
 
 
if object_id( N'tempdb..#Y', N'U' ) is not null 
	drop table #Y;
	
create table #Y(Col1 int,Col2 int)
go
 
set nocount on
 
insert into #Y values(1, NULL)
insert into #Y values(1, NULL)
insert into #Y values(1, NULL)
insert into #Y values(1, NULL)
insert into #Y values(1, NULL)
insert into #Y values(2, NULL)
insert into #Y values(2, NULL)
insert into #Y values(2, NULL)
insert into #Y values(2, NULL)
insert into #Y values(3, NULL)
insert into #Y values(3, NULL)
insert into #Y values(3, NULL)
insert into #Y values(3, NULL)
insert into #Y values(3, NULL)
insert into #Y values(3, NULL)
insert into #Y values(3, NULL)
insert into #Y values(3, NULL)
insert into #Y values(3, NULL)
insert into #Y values(3, NULL)
 
set nocount off
 
select *
from #Y
go
 
select 
	row_number() over( partition by col1 order by col1 ) as RowNumber
	, col1
from #Y
go
 
update y
	set y.col2 = y.RowNumber
from 
	(
	select 
		row_number() over( partition by col1 order by col1 ) as RowNumber
		, col1
		, col2
	from #Y	
	) y
 
select *
from #Y
go

Open in new window

0
 

Author Closing Comment

by:sopheak
ID: 31411075
Thanks for the row_number
0

Featured Post

Hire Technology Freelancers with Gigs

Work with freelancers specializing in everything from database administration to programming, who have proven themselves as experts in their field. Hire the best, collaborate easily, pay securely, and get projects done right.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

INTRODUCTION: While tying your database objects into builds and your enterprise source control system takes a third-party product (like Visual Studio Database Edition or Red-Gate's SQL Source Control), you can achieve some protection using a sing…
This article explains how to reset the password of the sa account on a Microsoft SQL Server.  The steps in this article work in SQL 2005, 2008, 2008 R2, 2012, 2014 and 2016.
In this video, Percona Solution Engineer Dimitri Vanoverbeke discusses why you want to use at least three nodes in a database cluster. To discuss how Percona Consulting can help with your design and architecture needs for your database and infras…
We’ve all felt that sense of false security before—locking down external access to a database or component and feeling like we’ve done all we need to do to secure company data. But that feeling is fleeting. Attacks these days can happen in many w…

656 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question