Solved

Select Statement, MS Sql Server

Posted on 2007-11-27
4
136 Views
Last Modified: 2010-03-19
Good afternoon,

I've got a table in my database that has 3 relationships to the same table (you can enter 3 states, so it has a relationship from like addressstateID to StateID in the state table, and one for billingstateaddress, etc).

In the table itself, I have 2 test columns entered.  However, when I run my select statement it's pulling back 5,000 results.  Everything is identical, except for Billing State and Shipping State.  It'll pull back one record for Alabama and Alabama.  Then the next record will be identical except it'll pull back Alabama and Alaska, and it keeps going through this for each and every possible combination of states, even though there are only 2 actual records in the database.

Doing my own troubleshooting, it seems to be narrowed down to the CROSS JOIN - if I remove the CROSS JOIN, then it only pulls back 2 records - but it only pulls back the StateID not the state names like I need.

I did something very similiar on another page, and it works flawless, and after 3 hours of looking through everything I can't figure out what would cause this.  Has anybody else run into this before and would know what is causing it?  I double checked the relationships and everything else, and I can't for the life of me figure it out.
SELECT     a.VendorLocationId, a.VendorId, a.Address, a.City, a.StateId, a.ZipCode, a.ShippingAddress, a.ShippingCity, a.ShippingStateId, a.ShippingZipCode, 

                      a.BillingAddress, a.BillingCity, a.BillingStateId, a.BillingZipCode, a.PrimaryPhone, a.SecondaryPhone, a.Fax, a.Email, b.State, c.State AS BillingState, 

                      d.State AS ShippingState

FROM         VendorLocation AS a CROSS JOIN

                      State AS b CROSS JOIN

                      State AS c CROSS JOIN

                      State AS d

WHERE     (a.VendorId = @VendorID) AND (a.StateId = b.StateId OR

                      a.StateId IS NULL) AND (a.BillingStateId = c.StateId OR

                      a.BillingStateId IS NULL) AND (a.ShippingStateId = d.StateId OR

                      a.ShippingStateId IS NULL)

Open in new window

0
Comment
Question by:arhame
  • 2
  • 2
4 Comments
 
LVL 142

Accepted Solution

by:
Guy Hengel [angelIII / a3] earned 500 total points
ID: 20360976
I highly doubt you want a CROSS JOIN ... but a LEFT JOIN will do perfectly
SELECT     a.VendorLocationId, a.VendorId, a.Address, a.City, a.StateId, a.ZipCode, a.ShippingAddress, a.ShippingCity, a.ShippingStateId, a.ShippingZipCode, 
                      a.BillingAddress, a.BillingCity, a.BillingStateId, a.BillingZipCode, a.PrimaryPhone, a.SecondaryPhone, a.Fax, a.Email, b.State, c.State AS BillingState, 
                      d.State AS ShippingState
FROM      VendorLocation AS a 
LEFT JOIN State AS b 
   ON (a.StateId = b.StateId)
LEFT JOIN State AS c 
   ON (a.BillingStateId = c.StateId)
LEFT JOIN State AS d
   ON (a.ShippingStateId = d.StateId)
WHERE     (a.VendorId = @VendorID) 
                      
       

Open in new window

0
 
LVL 8

Author Comment

by:arhame
ID: 20361051
Ah, that did the trick.  I actually just put a , in the select statement like:
FROM      VendorLocation                      a
      ,State                  b
      ,State                  c
      ,State                  d

But visual studio 2005 kept putting in the CROSS JOIN.

Visual Studio forced yours to a left outter join, but it's pulling the proper results.  That shouldn't matter should it?  Left Outer join instead of just left join?
0
 
LVL 142

Expert Comment

by:Guy Hengel [angelIII / a3]
ID: 20361064
LEFT JOIN and LEFT OUTER JOIN are indeed the same thing, OUTER being optional keyword
0
 
LVL 8

Author Comment

by:arhame
ID: 20361071
Thanks for your quick help :)  Points awarded.
0

Featured Post

Optimizing Cloud Backup for Low Bandwidth

With cloud storage prices going down a growing number of SMBs start to use it for backup storage. Unfortunately, business data volume rarely fits the average Internet speed. This article provides an overview of main Internet speed challenges and reveals backup best practices.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

I am showing a way to read/import the excel data in table using SQL server 2005... Suppose there is an Excel file "Book1" at location "C:\temp" with column "First Name" and "Last Name". Now to import this Excel data into the table, we will use…
Use this article to create a batch file to backup a Microsoft SQL Server database to a Windows folder.  The folder can be on the local hard drive or on a network share.  This batch file will query the SQL server to get the current date & time and wi…
Here's a very brief overview of the methods PRTG Network Monitor (https://www.paessler.com/prtg) offers for monitoring bandwidth, to help you decide which methods you´d like to investigate in more detail.  The methods are covered in more detail in o…
With Secure Portal Encryption, the recipient is sent a link to their email address directing them to the email laundry delivery page. From there, the recipient will be required to enter a user name and password to enter the page. Once the recipient …

930 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

10 Experts available now in Live!

Get 1:1 Help Now