Solved

Select Statement, MS Sql Server

Posted on 2007-11-27
4
137 Views
Last Modified: 2010-03-19
Good afternoon,

I've got a table in my database that has 3 relationships to the same table (you can enter 3 states, so it has a relationship from like addressstateID to StateID in the state table, and one for billingstateaddress, etc).

In the table itself, I have 2 test columns entered.  However, when I run my select statement it's pulling back 5,000 results.  Everything is identical, except for Billing State and Shipping State.  It'll pull back one record for Alabama and Alabama.  Then the next record will be identical except it'll pull back Alabama and Alaska, and it keeps going through this for each and every possible combination of states, even though there are only 2 actual records in the database.

Doing my own troubleshooting, it seems to be narrowed down to the CROSS JOIN - if I remove the CROSS JOIN, then it only pulls back 2 records - but it only pulls back the StateID not the state names like I need.

I did something very similiar on another page, and it works flawless, and after 3 hours of looking through everything I can't figure out what would cause this.  Has anybody else run into this before and would know what is causing it?  I double checked the relationships and everything else, and I can't for the life of me figure it out.
SELECT     a.VendorLocationId, a.VendorId, a.Address, a.City, a.StateId, a.ZipCode, a.ShippingAddress, a.ShippingCity, a.ShippingStateId, a.ShippingZipCode, 
                      a.BillingAddress, a.BillingCity, a.BillingStateId, a.BillingZipCode, a.PrimaryPhone, a.SecondaryPhone, a.Fax, a.Email, b.State, c.State AS BillingState, 
                      d.State AS ShippingState
FROM         VendorLocation AS a CROSS JOIN
                      State AS b CROSS JOIN
                      State AS c CROSS JOIN
                      State AS d
WHERE     (a.VendorId = @VendorID) AND (a.StateId = b.StateId OR
                      a.StateId IS NULL) AND (a.BillingStateId = c.StateId OR
                      a.BillingStateId IS NULL) AND (a.ShippingStateId = d.StateId OR
                      a.ShippingStateId IS NULL)

Open in new window

0
Comment
Question by:arhame
  • 2
  • 2
4 Comments
 
LVL 143

Accepted Solution

by:
Guy Hengel [angelIII / a3] earned 500 total points
ID: 20360976
I highly doubt you want a CROSS JOIN ... but a LEFT JOIN will do perfectly
SELECT     a.VendorLocationId, a.VendorId, a.Address, a.City, a.StateId, a.ZipCode, a.ShippingAddress, a.ShippingCity, a.ShippingStateId, a.ShippingZipCode, 
                      a.BillingAddress, a.BillingCity, a.BillingStateId, a.BillingZipCode, a.PrimaryPhone, a.SecondaryPhone, a.Fax, a.Email, b.State, c.State AS BillingState, 
                      d.State AS ShippingState
FROM      VendorLocation AS a 
LEFT JOIN State AS b 
   ON (a.StateId = b.StateId)
LEFT JOIN State AS c 
   ON (a.BillingStateId = c.StateId)
LEFT JOIN State AS d
   ON (a.ShippingStateId = d.StateId)
WHERE     (a.VendorId = @VendorID) 
                      
       

Open in new window

0
 
LVL 8

Author Comment

by:arhame
ID: 20361051
Ah, that did the trick.  I actually just put a , in the select statement like:
FROM      VendorLocation                      a
      ,State                  b
      ,State                  c
      ,State                  d

But visual studio 2005 kept putting in the CROSS JOIN.

Visual Studio forced yours to a left outter join, but it's pulling the proper results.  That shouldn't matter should it?  Left Outer join instead of just left join?
0
 
LVL 143

Expert Comment

by:Guy Hengel [angelIII / a3]
ID: 20361064
LEFT JOIN and LEFT OUTER JOIN are indeed the same thing, OUTER being optional keyword
0
 
LVL 8

Author Comment

by:arhame
ID: 20361071
Thanks for your quick help :)  Points awarded.
0

Featured Post

Free Tool: IP Lookup

Get more info about an IP address or domain name, such as organization, abuse contacts and geolocation.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Recently, when I was asked to create a new SQL 2005 cluster, Microsoft released a new service pack for MS SQL 2005 what is Service Pack 3. When I finished the installation of MS SQL 2005 I found myself troubled why the installation of SP3 failed …
In this article I will describe the Backup & Restore method as one possible migration process and I will add the extra tasks needed for an upgrade when and where is applied so it will cover all.
This video shows how to quickly and easily add an email signature for all users on Exchange 2016. The resulting signature is applied on a server level by Exchange Online. The email signature template has been downloaded from: www.mail-signatures…
Although Jacob Bernoulli (1654-1705) has been credited as the creator of "Binomial Distribution Table", Gottfried Leibniz (1646-1716) did his dissertation on the subject in 1666; Leibniz you may recall is the co-inventor of "Calculus" and beat Isaac…

791 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question