Solved

Trigger question in MS SQL 2005 on update /insert audit

Posted on 2007-11-28
9
4,487 Views
Last Modified: 2008-02-13
I have created this trigger below to audit updates and inserts to my table, I also want any updates or inserts to be copied to another table called labdata, and then logged in my audit table. how would i do this?
this is what i have so far and it works for what i have so far.
CREATE TRIGGER AuditSamples
ON dbo.[Samples Received]
AFTER INSERT, UPDATE
--NOT FOR REPLICATION
AS
DECLARE @Operation char(6)

IF EXISTS(SELECT * FROM deleted)
      SET @Operation = 'Update'
ELSE
      SET @Operation ='Insert'

INSERT INTO dbo.SamplesAudit(DateChanged,TableName,UserName,Operation)
SELECT GetDate(),'[Samples Received]', suser_sname(),
      @Operation
--End of Trigger
0
Comment
Question by:edi77
  • 4
  • 2
  • 2
  • +1
9 Comments
 
LVL 10

Expert Comment

by:pai_prasad
Comment Utility
I also want any updates or inserts to be copied to another table called labdata,
>>>>
is my understanding correct

1. Insert happens in the parent table
2. Trigger is fired
3, U need the inserted row in child table
4 make an audit entry for the insert in audit table

0
 
LVL 42

Expert Comment

by:dqmq
Comment Utility
Not quite sure what your question is.  To insert in another table, add another insert to the trigger.  

Note that your code only inserts one row in the audit table, even if your update affects several rows in the samples_received.  That may or may not be what you intend for the audit table.  But for the labdata table, it's not acceptable.

For that case, you need to join the the Inserted table to generate multiple rows:

INSERT INTO dbo.labdata
    Select * from Inserted
0
 

Author Comment

by:edi77
Comment Utility
ok my insert and updates should only happen one at a time.
yes , after i insert any record into lab samples i also want to insert it into the labdata table.
how where in the code do i do that?
can u show me what u mean?

after it does that for insert or update, i would like it to go to the audit table as well.

does that make sense?

0
 
LVL 42

Expert Comment

by:dqmq
Comment Utility
>ok my insert and updates should only happen one at a time.

I've heard that before!!



CREATE TRIGGER AuditSamples
ON dbo.[Samples Received]
AFTER INSERT, UPDATE
--NOT FOR REPLICATION
AS
BEGIN --Trigger

--insert one row in samples for each update or insert STATEMENT
--to make a ROW trigger, remove the DISTINCT keyword
INSERT INTO dbo.SamplesAudit(DateChanged,TableName,UserName,Operation)
SELECT DISTINCT GetDate(),'[Samples Received]', suser_sname()
, ISNULL('Update','Insert')  From Deleted

--insert one row in lab data for each update or insert ROW
INSERT INTO dbo.labdata
   SELECT * FROM Inserted

END --Trigger


If you want to audit the insert to labdata, then it's best to have a insert trigger on that table, as well.
0
Complete VMware vSphere® ESX(i) & Hyper-V Backup

Capture your entire system, including the host, with patented disk imaging integrated with VMware VADP / Microsoft VSS and RCT. RTOs is as low as 15 seconds with Acronis Active Restore™. You can enjoy unlimited P2V/V2V migrations from any source (even from a different hypervisor)

 
LVL 5

Expert Comment

by:ursangel
Comment Utility
All the experts commenst should work fine,
Just add this line of insert in your existing tirgger.
Insert into dbo.labdata (select * from inserted)
hoping that your lab data and lab sample have the same schema.
0
 

Author Comment

by:edi77
Comment Utility
ok that didnt really work it said it couldnt find the labdata table ...
the thing is the first way i did it worked so that part is good. the audit on samples recieved works fine.

so if i want to keep it simpler

what if i just did all the inserting into the labdata table in a seperate trigger. would that be better?
if so how would that look?

i want it to say.
when a new record is updated or inserted in samples recieved enter a record into labdata, then audit that record in a an audit table.
actually i dont want to copy the WHOLE record just 3 fields. DNA, Kit, Participant

could you help me with what that syntax looks like. can i write a trigger on one table based on another like this?
i have no idea never done it.
0
 

Author Comment

by:edi77
Comment Utility
no the field names nor schema arent exactly the same. i only need about 3 fields to be copied into the lab data table from the samples table.
0
 

Author Comment

by:edi77
Comment Utility
anyone out there who can help?
0
 
LVL 5

Accepted Solution

by:
ursangel earned 500 total points
Comment Utility
You havent specified which are the column name that u need to be inserted into the LABDATA table.
Im just writing this from my guess. Replace the column name with the exact one's
Just select the coulmn name alone and insert into the labdata
insert into LABDATA (Col1, Col2, Col3) select Col1, Col2 Col3 from Inserted

0

Featured Post

IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

Join & Write a Comment

Let's review the features of new SQL Server 2012 (Denali CTP3). It listed as below: PERCENT_RANK(): PERCENT_RANK() function will returns the percentage value of rank of the values among its group. PERCENT_RANK() function value always in be…
International Data Corporation (IDC) prognosticates that before the current the year gets over disbursing on IT framework products to be sent in cloud environs will be $37.1B.
Via a live example, show how to set up a backup for SQL Server using a Maintenance Plan and how to schedule the job into SQL Server Agent.
Viewers will learn how the fundamental information of how to create a table.

772 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

11 Experts available now in Live!

Get 1:1 Help Now