Solved

Appropriate use of exceptions

Posted on 2007-12-01
4
250 Views
Last Modified: 2013-12-13
I can best present this question with code...

Thanks
//This is how you'd (presumably) normally work with exceptions...
 
//within the class
public function query($query) {
 if (!$query = @mysql_query($query,$this->conn)) {
  throw new Exception('Query Error');
 }
 return $query;
}
 
//code
$db = new classname();
try {
 $db->query('the_query'); 
}
catch (Exception $e) {
 die($e->getMessage());
}
 
#########################################
 
/* but I'm thinking as an exception thrown will always result in the
 termination of the script here, and I'd otherwise have to include
 the try-catch block every time I want to run a query; would it not 
make more sense to just build it into the class? i.e. */
 
#########################################
 
//within the class
public function query($query) {
 try {
  if (!$query = @mysql_query($query,$this->conn)) {
   throw new Exception('Query Error');
  }
 } catch (Exception $e) {
  die($e->getMessage());
 }
 $this->query_count++;
 return $query;
}
 
//code
$db = new classname();
$db->query('the_query');
 
 
/* is there any reason why this would be considered bad 
practice, or a bad idea? */

Open in new window

0
Comment
Question by:calcanus
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
4 Comments
 
LVL 36

Accepted Solution

by:
Zyloch earned 125 total points
ID: 20388704
If you are just going to kill the script, then you would do it within the function itself, but most of the time, you wouldn't want to be that extreme. You would want some way to notify the calling function that something went wrong. In this case, you would throw your exception. Perhaps, you would log the error to a log file before that inside your function.

Yes, it litters your code with many try-catch clauses. However, since you can pass any message string in an exception, you can use a central catch clause. Or if the function that is catching the exception is part of another function, you can translate multiple exception types into a single exception that is more general (perhaps logging along the way).

That said, you may be able to use set_exception_handler() to handle truly redundant cases.
0
 
LVL 19

Assisted Solution

by:SteveH_UK
SteveH_UK earned 125 total points
ID: 20389160
In this particular case, you might also consider supporting both options by an optional parameter.  That way your code is reusable, and supports informing the caller of an "exceptional" circumstance, but also allows you to choose a default behaviour of exiting your script.
0
 
LVL 16

Expert Comment

by:CWS (haripriya)
ID: 21188508
No comment has been added to this question in more than 21 days, so it is now classified as abandoned.

I will leave the following recommendation for this question in the Cleanup topic area:
   Split: steelseth12 {http:#20388704} & SteveH_UK {http:#20389160}

Any objections should be posted here in the next 4 days. After that time, the question will be closed.

cyberwebservice
Experts Exchange Cleanup Volunteer
0
 
LVL 1

Expert Comment

by:Computer101
ID: 21216914
Forced accept.

Computer101
EE Admin
0

Featured Post

PeopleSoft Has Never Been Easier

PeopleSoft Adoption Made Smooth & Simple!

On-The-Job Training Is made Intuitive & Easy With WalkMe's On-Screen Guidance Tool.  Claim Your Free WalkMe Account Now

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Build an array called $myWeek which will hold the array elements Today, Yesterday and then builds up the rest of the week by the name of the day going back 1 week.   (CODE) (CODE) Then you just need to pass your date to the function. If i…
Password hashing is better than message digests or encryption, and you should be using it instead of message digests or encryption.  Find out why and how in this article, which supplements the original article on PHP Client Registration, Login, Logo…
The viewer will learn how to dynamically set the form action using jQuery.
This tutorial will teach you the core code needed to finalize the addition of a watermark to your image. The viewer will use a small PHP class to learn and create a watermark.

688 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question