Solved

An alternate solution for this bad loop

Posted on 2007-12-04
8
241 Views
Last Modified: 2010-04-01
I finally got this loop to change but I can't fiqure out another way to stop

while (x = 1)

   {

            cout << "x is: " << x << '\n';

   }


The above code executes a never ending loop displaying x is: 1 out to the console.

This happens because condition x = 1 is reset to 1 (never changes) every time the loop is performed,  even if the  x++  increment is added.

One way to stop this loop is as follows&.

    int x = 1;      // initialize interger x to equal 1

    while (x < 2) // execute loop while x is less than 2

    {    
            cout << "x is: " << x << '\n';      // console out x is: 1

            x++;   // increment x by 1 (this will change the loop condition and terminate the loop

    }

I need an alternate way to stop this loop.  Can you help me?
0
Comment
Question by:cooperk50
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 3
  • 2
8 Comments
 
LVL 45

Accepted Solution

by:
Kent Olsen earned 63 total points
ID: 20402417
Hi cooperk50,

You must have missed the answer in the other thread.

  while (x == 1)

That will enter the loop if x is 1, and keep looping until x has any other value.

If you want to execute the loop once, no matter what the value of x, do this:

  do
  {
    cout << "x is:  " << x << \n";
    ++x;
  } while (x == 1);


Good Luck,
Kent
0
 
LVL 53

Expert Comment

by:Infinity08
ID: 20402421
>> I need an alternate way to stop this loop.  Can you help me?

What do you mean by alternate ?

What do you want the code to do ?
0
 
LVL 39

Assisted Solution

by:itsmeandnobodyelse
itsmeandnobodyelse earned 62 total points
ID: 20402625
>>>> I need an alternate way to stop this loop.

You could do:

  int x = 0;
  while (true)
  {
        cout << "x = " << x << endl;
        cin >> x;
        if (x <= 0)
              break;
  }

Note, the break statement would exit the current loop. In case of a nested loop (loop in loop) you need a break for each of the loops. Another statement for a loop is the 'continue' statement. It will 'go to' end of loop but not breaking it. So, if you want to exit the loop you should break. Or you set the end condition and call continue.

  int x = 0;
  bool goon = true;
  while (goon)
  {
       cout << " x = " << x << endl;
       cout << "Do you want to go on? [Y/N] ";
       char c;
       cin >> c;
       if (c == 'N' || c == 'n')
       {
             goon = false;
             continue;
       }  
       x = rand();  // get any randomized number
  }

Shorter is the following (not using continue)

  int x = 0;
  bool goon = true;
  while (goon)
  {
       cout << " x = " << x << endl;
       cout << "Do you want to go on? [Y/N] ";
       char c;
       cin >> c;
       goon = !(c == 'N' || c == 'n');
       x = rand();  // get any randomized number
  }

However, the difference is that x was set to a new random number if not calling continue or break.

Regards, Alex



0
Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
LVL 39

Expert Comment

by:itsmeandnobodyelse
ID: 25398644
Whatever the wished answer was. Kdo didn't post an 'alternate' answer to that the asker posted.

I would recommend to delete the q. without refund.
0
 
LVL 45

Expert Comment

by:Kent Olsen
ID: 25398977
When tied to a similar question in another thread, my answer would seem to be sufficient.  The poster first asked this:

  http://www.experts-exchange.com/Programming/Languages/CPP/Q_22999993.html

He then repeated his error in this thread.


Kent
0
 
LVL 39

Expert Comment

by:itsmeandnobodyelse
ID: 25400199
>>>> When tied to a similar question in another thread, my answer would seem to be sufficient.  

You are right, Kent.

Sorry for misinterpreting your answer here in that thread.
0

Featured Post

Secure Your Active Directory - April 20, 2017

Active Directory plays a critical role in your company’s IT infrastructure and keeping it secure in today’s hacker-infested world is a must.
Microsoft published 300+ pages of guidance, but who has the time, money, and resources to implement? Register now to find an easier way.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

C++ Properties One feature missing from standard C++ that you will find in many other Object Oriented Programming languages is something called a Property (http://www.experts-exchange.com/Programming/Languages/CPP/A_3912-Object-Properties-in-C.ht…
This article shows you how to optimize memory allocations in C++ using placement new. Applicable especially to usecases dealing with creation of large number of objects. A brief on problem: Lets take example problem for simplicity: - I have a G…
The goal of the video will be to teach the user the difference and consequence of passing data by value vs passing data by reference in C++. An example of passing data by value as well as an example of passing data by reference will be be given. Bot…
The viewer will be introduced to the member functions push_back and pop_back of the vector class. The video will teach the difference between the two as well as how to use each one along with its functionality.

756 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question