Solved

PHP Change password script issue

Posted on 2007-12-05
7
7,546 Views
Last Modified: 2012-05-05
Hi all,

i am working on a Password change script for my site. The below script works a treat all except for one thing. If a user enters an email address thats not in the database the script errors.

Warning: mysql_result() [function.mysql-result]: Unable to jump to row 0 on MySQL result index 3 in /home/user/public_html/sr_Change_Password_Script.php on line 39

As i said other than this issue the script works.

I have a page with a form that passes the POST data to this script.

The script seems to have a problem when the $result doesnt get any data. At least thats what i think based on there error

Hope you can help


<?php  
 

session_start(); 
 

include 'Connections/EE_con.php';  
 
 
 

$useremail = $_POST['user_email']; 

$password = $_POST['cur_password']; 

$newpassword = $_POST['new_password']; 

$confirmnewpassword = $_POST['con_password']; 
 

if(!$useremail){

$message = "You have not entered an email address";

header("Location: sr_Change_Password.php?message=$message");

exit();

}

else{

////////////////////////////////
 

mysql_select_db($database_EE_con, $EE_con);

     $query_rstUser = sprintf("SELECT user_password FROM users WHERE user_email='$useremail'");

         

     $result = mysql_query($query_rstUser, $EE_con) or die(mysql_error());

     $row_rstUser = mysql_fetch_assoc($result);
 
 

///////////////////////////////////////
 

if(!$result)  

{  

$message = "The username you entered does not exist";

	header("Location: sr_Change_Password.php?message=$message");

	exit();

}else

if(sha1($password)!= mysql_result($result, 0))  

{  

//echo "You entered an incorrect password";  

$message = "You entered an incorrect password";

	header("Location: sr_Change_Password.php?message=$message");

	exit();
 

}  
 

if(!$newpassword){
 

$message = "You must enter a password";

header("Location: sr_Change_Password.php?message=$message");

}
 

if($newpassword == $confirmnewpassword)  

    $sql=mysql_query("UPDATE users SET user_password='".sha1($newpassword)."' where user_email='$useremail'");  

    if($sql)  

    {  

    //echo "Congratulations You have successfully changed your password";  

	$message = "Congratulations You have successfully changed your password";

	header("Location: sr_Change_Password.php?message=$message");

exit();

    } 

else 

{  

//echo "The new password and confirm new password fields must be the same";

$message = "The new password and confirm new password fields must be the same";

	header("Location: sr_Change_Password.php?message=$message");

exit();

}   

}
 

?>

Open in new window

0
Comment
Question by:satmanuk
  • 3
  • 3
7 Comments
 
LVL 6

Accepted Solution

by:
CasUK earned 500 total points
ID: 20411349
Change line 31:

if (mysql_num_rows($result) == 0){

0
 
LVL 17

Expert Comment

by:nplib
ID: 20411966
mysql_result($result, 0) this needs another paramter,
mysql_result($result, 0, "user_password");
the mysql_result() function works as follows,

mysql_result(query_results, row_number, field);

row_number begins at 0.
0
 
LVL 17

Expert Comment

by:nplib
ID: 20411988
however since you did this,
$row_rstUser = mysql_fetch_assoc($result);

you could replace your mysql_result() function with
$row_rstUser['user_password']

so this
if(sha1($password)!= mysql_result($result, 0, "user_password"))
or
if(sha1($password)!= $row_rstUser['user_password'])

should work
0
Microsoft Certification Exam 74-409

Veeam® is happy to provide the Microsoft community with a study guide prepared by MVP and MCT, Orin Thomas. This guide will take you through each of the exam objectives, helping you to prepare for and pass the examination.

 
LVL 1

Author Comment

by:satmanuk
ID: 20412865
I tried what you said nplib but i still get the same error.

CasUK - Yours worked.

Thanks!
0
 
LVL 1

Author Closing Comment

by:satmanuk
ID: 31412840
thanks
0
 
LVL 17

Expert Comment

by:nplib
ID: 20412890
how can if(sha1($password)!= $row_rstUser['user_password']) give the same error when it's not invoking the mysql_results() function?
0
 
LVL 1

Author Comment

by:satmanuk
ID: 20413027
may be not the same error on both of your suggestions but both error'd
0

Featured Post

Enterprise Mobility and BYOD For Dummies

Like “For Dummies” books, you can read this in whatever order you choose and learn about mobility and BYOD; and how to put a competitive mobile infrastructure in place. Developed for SMBs and large enterprises alike, you will find helpful use cases, planning, and implementation.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Nothing in an HTTP request can be trusted, including HTTP headers and form data.  A form token is a tool that can be used to guard against request forgeries (CSRF).  This article shows an improved approach to form tokens, making it more difficult to…
Since pre-biblical times, humans have sought ways to keep secrets, and share the secrets selectively.  This article explores the ways PHP can be used to hide and encrypt information.
The viewer will learn how to dynamically set the form action using jQuery.
The viewer will learn how to count occurrences of each item in an array.

911 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

16 Experts available now in Live!

Get 1:1 Help Now