Solved

Slow CString creation

Posted on 2008-06-09
8
300 Views
Last Modified: 2013-11-20
After I collect up to 600,000 points of data I have to process each point into a text string and display it in an edit control and/or save it as a text file, but as I process the string the processing gets very slow very soon. I update the process after every 2k points and it gets noticabley slower after each set, untill after 10,000 it is unacceptably slow.

What is going on and what can I do to remedy?



for( i=0; i<m_DataCount; i++ )

	{

		MSG msg;

		while( ::PeekMessage( &msg, NULL, 0, 0, PM_NOREMOVE ) )

		{

			AfxGetApp()->PumpMessage();  // does a ::GetMessage() (waits...)

		}

// VOLTAGE

		cdword._dword = dwArray[i];

		wVoltage = cdword.word1;

		if( wVoltage < 100 )

			break;

	// CURRENT

		wCurrent = cdword.byte1 & 0xFC;
 

		f = wVoltage;

		str.Format("%.3f\t", f / 1000 );

		strData += str;
 

		j = wCurrent;

		f = j;

		str.Format("%.3f\t", f / 100 );

		strData += str;
 

		j = wTemperature;

		str.Format("%d\r\n", j);

		strData += str;
 

		if( i % 2000 == 0 )

		{

			str.Format("Logging complete\r\n\r\nProcessing data please wait... %dk points", i /1000 );

			m_editData.Clear();

			m_editData.SetWindowText( str );

		}

	}

	m_editData.SetWindowText( strData );

Open in new window

0
Comment
Question by:EnergyStorage
  • 3
  • 2
8 Comments
 
LVL 44

Accepted Solution

by:
AndyAinscow earned 500 total points
Comment Utility
strData += str

As the contents of strData are continually growing I suspect you have memory allocation/copy problems.

Reduce the number of times you perform the 'strData += str' action.
0
 

Author Comment

by:EnergyStorage
Comment Utility
I knew it was due to the constant changing of CString buffer size and I solved it myself using CString function GetBufferSetLength.

0
 
LVL 44

Expert Comment

by:AndyAinscow
Comment Utility
excerpt of question
>>What is going on

later comment by questioner after a comment suggesting where the problem could lie and a solution
>>I knew it was due to the constant changing of CString buffer size

Seems to be some mismatch of information in those two statements.
0
 

Author Comment

by:EnergyStorage
Comment Utility
a21748945 was not a solution.

I said "What is going on and how do I remedy this. Not Doing what need to be done is not a remedy.

I found the remedy on my own as I said above by using the CString function GetBufferSetLength().

0
 
LVL 44

Expert Comment

by:AndyAinscow
Comment Utility
In your original question you stated you did NOT know what was slow in your code.  When you know that then you can then remedy it.
I pointed out what I thought was slow and one potential change to improve the performance.
0

Featured Post

Top 6 Sources for Identifying Threat Actor TTPs

Understanding your enemy is essential. These six sources will help you identify the most popular threat actor tactics, techniques, and procedures (TTPs).

Join & Write a Comment

Suggested Solutions

Introduction: Ownerdraw of the grid button.  A singleton class implentation and usage. Continuing from the fifth article about sudoku.   Open the project in visual studio. Go to the class view – CGridButton should be visible as a class.  R…
Introduction: Dialogs (2) modeless dialog and a worker thread.  Handling data shared between threads.  Recursive functions. Continuing from the tenth article about sudoku.   Last article we worked with a modal dialog to help maintain informat…
This video will show you how to get GIT to work in Eclipse.   It will walk you through how to install the EGit plugin in eclipse and how to checkout an existing repository.
This tutorial demonstrates a quick way of adding group price to multiple Magento products.

744 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

12 Experts available now in Live!

Get 1:1 Help Now