Solved

Write to Excel

Posted on 2008-06-09
24
215 Views
Last Modified: 2010-04-23
 
I have a tamplate in Excel  2007. Column "A" is Firstname and column "B" is Lastname , and column "C" is Address. I have no problem getting data from DB. All I want to find out is how can I use my template and fill it out and save it to a new file.

column A       column B     Column C
FirstName  |    LastName   | Address

Tim             Johnsone     123 Test st. San Francisco, Ca 90000






 Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click

        Dim xlApp As New Excel.Application
        Dim wrkbook As Excel.Workbooks

        wrkbook = xlApp.Workbooks.Open("mypath\test.xlsx")

        xlApp.Range("A" & 1).Value = "Tim"
      xlapp.range("B" & ???????????????

        wrkbook.Close()
        wrkbook = Nothing
        xlApp = Nothing





    End Sub
0
Comment
Question by:VBdotnet2005
  • 13
  • 11
24 Comments
 
LVL 48

Expert Comment

by:jpaulino
Comment Utility
Hi VBdotnet2005,


I don't understand what is working and what are the ?????
0
 
LVL 48

Expert Comment

by:jpaulino
Comment Utility
You want to fill with data from the db and save with a new name in the end ?
0
 

Author Comment

by:VBdotnet2005
Comment Utility
correct...
0
 
LVL 48

Expert Comment

by:jpaulino
Comment Utility
>> I have no problem getting data from DB

You have only to do a loop on your db and fill the rows. Ex.

Dim x As Integer = 3 ' to star on 3rd row
While reader.Reads()
     xlApp.Range("A" & x).Value = reader("field1")
     xlApp.Range("B" & x).Value = reader("field1")
     xlApp.Range("C" & x).Value = reader("field1")
    x += 1
End While

Then in the end:
wrkbook.SaveAs("FileName.xlsx")
wrkbook.Close()
wrkbook = Nothing
xlApp = Nothing
0
 

Author Comment

by:VBdotnet2005
Comment Utility
Correct?

Imports Microsoft.Office.Interop

Public Class Form1

    Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click

        Dim xlApp As New Excel.Application
        Dim wrkbook As Excel.Workbooks = xlApp.Workbooks.Open("mypath\test.xlsx")
        Dim wrksheet As Excel.Worksheet = wrkbook.sheet(1)  <<<<<<<<<<<< error this line
0
 
LVL 48

Expert Comment

by:jpaulino
Comment Utility
Replace:
wrkbook.sheet(1)

With:
wrkbook.Worksheets(1)
0
 

Author Comment

by:VBdotnet2005
Comment Utility
I can't find wrkbook.Worksheets(1)
0
 

Author Comment

by:VBdotnet2005
Comment Utility
I am usring MS office 2007
0
 
LVL 48

Expert Comment

by:jpaulino
Comment Utility
Ok, I use 2003 version but you have Sheets(1)!

Right ?
0
 

Author Comment

by:VBdotnet2005
Comment Utility
I declared this wrong...


Dim wrkbook As Excel.Workbooks


to

Dim wrkbook As Excel.Workbook
0
 
LVL 48

Expert Comment

by:jpaulino
Comment Utility
Ok, I didn't notice that. In my example that i'm doing it's ok,

How's the code now ? It's working ?
0
 

Author Comment

by:VBdotnet2005
Comment Utility
I am sorry. What is  "x" >   "A" & x ? >>>>>>>  xlApp.Range("A" & x).Value = reader("field1")
0
Threat Intelligence Starter Resources

Integrating threat intelligence can be challenging, and not all companies are ready. These resources can help you build awareness and prepare for defense.

 

Author Comment

by:VBdotnet2005
Comment Utility
This is the whole code.    


Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click

        Dim xlApp As New Excel.Application
        Dim wrkbook As Excel.Workbook = xlApp.Workbooks.Open("mypath\test.xlsx")
        Dim wrksheet As Excel.Worksheet = wrkbook.Worksheets(1)


        Dim myConstring As String = "mystring"
        Dim Con As New SqlConnection(myConstring)
        Dim myCommandString As String = "select ...."
        Dim Sqlcommand As New SqlCommand(myCommandString, Con)


        Con.Open()

        Try

            Dim dr As SqlDataReader = Sqlcommand.ExecuteReader

            While dr.Read


                xlApp.Range("A" & x).Value = dr.Item("Firstname").ToString
                xlApp.Range("B" & x).Value = dr.Item("LastName").ToString
                xlApp.Range("C" & x).Value = dr.Item("Address").ToString

            End While


            dr.Close()

        Catch ex As Exception

            MessageBox.Show(ex.Message)

        Finally

            Con.Close()


        End Try



        wrkbook.SaveAs("test.xlsx")
        wrkbook.Close()
        wrkbook = Nothing
        xlApp = Nothing

    End Sub
0
 
LVL 48

Expert Comment

by:jpaulino
Comment Utility
The "x" will represent the row number.

Range("A1").Value = "something" will write "someting" to the first row/column of excel. You add a variable to write each row of your databases to each row of the worksheet.

Then you will increment the variable to write in the second row  - Range("A2")
0
 
LVL 48

Accepted Solution

by:
jpaulino earned 500 total points
Comment Utility
Try to change it to this:

Dim X as Integer = 3
While dr.Read
    xlApp.Range("A" & x).Value = dr.Item("Firstname").ToString
    xlApp.Range("B" & x).Value = dr.Item("LastName").ToString
    xlApp.Range("C" & x).Value = dr.Item("Address").ToString
    x +=1
End While
0
 

Author Comment

by:VBdotnet2005
Comment Utility
thank you so much... That works for me.
0
 
LVL 48

Expert Comment

by:jpaulino
Comment Utility
Glad I could help!

jpaulino
0
 
LVL 48

Expert Comment

by:jpaulino
Comment Utility
Just one extra ...

Sometimes excel instance keeps on memory after you close it. To avoid that "problem" you should also do this in the "Finally" on Try block, forcing the Garbage Collection to work.

Finally
   Con.Close()
   GC.Collect()
   GC.WaitForPendingFinalizers()
End Try
0
 

Author Comment

by:VBdotnet2005
Comment Utility
I tried

  Con.Close()
   GC.Collect()
   GC.WaitForPendingFinalizers()

Excel instance still show on Task manager.
0
 
LVL 48

Expert Comment

by:jpaulino
Comment Utility
Do you have that on the Finally (from the try catch block) ?
0
 

Author Comment

by:VBdotnet2005
Comment Utility
Yes. I do.
0
 
LVL 48

Expert Comment

by:jpaulino
Comment Utility
CAn you show the code you have ?
0
 

Author Comment

by:VBdotnet2005
Comment Utility
    Dim xlApp As New Excel.Application
        Dim wrkbook As Excel.Workbook = xlApp.Workbooks.Open(mypath)
        Dim wrksheet As Excel.Worksheet = wrkbook.Worksheets(1)

        Try

            Dim I As Integer = 1
            Dim re As Boolean

            While re = False

                I += 1

                myval = Trim(CStr(xlApp.Range("A" & I).Value))


                'MessageBox.Show(myval)



                If CStr(xlApp.Range("A" & I).Value) = Nothing Then

                    re = True

                End If


            End While


            wrkbook.Close()
            wrkbook = Nothing
            xlApp = Nothing

        Catch ex As Exception

            MessageBox.Show(ex.Message)  

        Finally

            GC.Collect()
            GC.WaitForPendingFinalizers()


        End Try
0
 
LVL 48

Expert Comment

by:jpaulino
Comment Utility
Have you checked if isn't from other tests ? Have your delete manually all other excel instances ?

You should also include all code in the try ... catch method. If it fails on open it doesn't do the close/GC.
0

Featured Post

How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

Join & Write a Comment

1.0 - Introduction Converting Visual Basic 6.0 (VB6) to Visual Basic 2008+ (VB.NET). If ever there was a subject full of murkiness and bad decisions, it is this one!   The first problem seems to be that people considering this task of converting…
If you need to start windows update installation remotely or as a scheduled task you will find this very helpful.
It is a freely distributed piece of software for such tasks as photo retouching, image composition and image authoring. It works on many operating systems, in many languages.
When you create an app prototype with Adobe XD, you can insert system screens -- sharing or Control Center, for example -- with just a few clicks. This video shows you how. You can take the full course on Experts Exchange at http://bit.ly/XDcourse.

744 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

17 Experts available now in Live!

Get 1:1 Help Now