Link to home
Start Free TrialLog in
Avatar of rtedi222
rtedi222

asked on

imagecreatefromjpeg Script Stops Running - Out of Memory?

I'm trying to write a script that will create thumbnails of all images that are in a specific directory.  However, when I run the script, it stops running before completion.  I believe that I've narrowed it down to the imagecreatefromjpeg function.  If I comment this out, everything prints as expected.  If I run it with this line, I make it through about 30 images before the script stops.  I am using imagedestroy() after each image creation, but this doesn't seem to help.  I realize that I'm not really doing anything with these thumbnails, but once I can get the script to execute all the way (hopefully), then I'll add some logic to save them.


I'm using a hosting company (1and1), so I am not able to make changes to my php.ini file.  Also, if I comment out all the echos, I eventually get a 500 error, but it's a generic one from my host which doesn't give me any specifics as to what's going on.  I've included my code and am open to comments and suggestions.

Thank you!!
<?php
	$strSourcePath = "[path to original images]";
	$strNewThumbPath = "[output path to thumbnails]";
 
	if (is_dir($strSourcePath)) {
	    if ($objDirHandle = opendir($strSourcePath)) {
	        while (($file = readdir($objDirHandle)) !== false) {
				if(filetype($strSourcePath . $file) == "file"){
					$strSourceFilePath = $strSourcePath . $file;
					echo "Processing $strSourceFilePath...<br>";
 
					$size = @getimagesize($strSourceFilePath);
 
					if($size){
						echo "&nbsp;&nbsp;&nbsp;";
						print_r($size);
						echo "<br>";
					} else {
						echo "&nbsp;&nbsp;&nbsp;<b>Error determining getimagesize info for $strSourceFilePath.</b><br>";
					}
 
					if($size[2] == 1){
						echo "&nbsp;&nbsp;&nbsp;$strSourceFilePath is a GIF<br>";
						$bolConvert = false;
					} elseif($size[2] == 2){
						echo "&nbsp;&nbsp;&nbsp;$strSourceFilePath is a JPG<br>";
						$bolConvert = true;
					} elseif($size[2] == 6){
						echo "&nbsp;&nbsp;&nbsp;$strSourceFilePath is a BMP<br>";
						$bolConvert = false;
					} else {
						echo "&nbsp;&nbsp;&nbsp;<b>$strSourceFilePath is an unsupported type</b><br>";
						$bolConvert = false;
					}
 
					if($bolConvert){
						header('Content-type: ' . $size['mime']);
						$objThumbnail = imagecreatetruecolor(100,100) ;
						$objImage = @imagecreatefromjpeg($strSourceFilePath) ;
 
						imagecopyresampled($objThumbnail, $objImage, 0, 0, 0, 0, 100, 100);
 
						imagedestroy($objThumbnail);
						imagedestroy($objImage);
						unset($size);
					} else {
						echo "&nbsp;&nbsp;&nbsp;<b>Did not convert $strSourceFilePath</b><br>";
					}
				echo "<hr>";
				}
	        }
	        closedir($objDirHandle);
	    }
	} else {
		die("<b>$strSourcePath is not a valid directory.</b>");
	}
?>

Open in new window

ASKER CERTIFIED SOLUTION
Avatar of AlexanderR
AlexanderR
Flag of Canada image

Link to home
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Start Free Trial
Avatar of rtedi222
rtedi222

ASKER

Please correct me if I'm wrong, but isn't imagedestroy() supposed to take care of cleaning up the memory that's used by creating images?  So if I call imagedestroy() for each image that I create, shouldn't my net usage be 0 (or close enough to it)?

Thanks!!
hard to tell unless you see the exact error.  What you should do is recreate the environment that resembles the one of your host.  Run phpinfo() on the server, look at environmental configurations and set up your own php.ini to resemble those.  Then, once you run the script on your own computer it should give a more meaningful error.

Other than memory limit it can also be execution time. Try changing it through either set_time_limit(60) or ini_set('max_execution_time', 60)
Try different numbers there.

And even though imagedestroy resets your memory, if the host has too low memory setting then even a singe image can max it out.
I believe that this is just a limitation of my host and there's nothing I can do about it.  Thanks for trying though!