Solved

# passing parameter into vb script

Posted on 2008-06-10
1,978 Views
Hi,

The attached code will convert my CSV files into XLS files, my problem is that the input file is hard coded as:strOrigFile = "C:\testing\in.csv"

I would like to be able to pass this as a parameter when I run the script, i.e.
c:\testing\script.vbs -strOrigFile = "C:\testing\in.csv"

How can I achieve this.

Also as a less important point I would like to delete the source file after teh conversion

cheers

Rob
Option Explicit

Dim fldr, f, file,strOrigFile, strFile, fso, strDirectory

Dim objExcel

strOrigFile = "C:\testing\in.csv"

'strOrigFile = "& var1"

'******************************************************

'CONVERTS THE FILE TO AN EXCEL FILE

'******************************************************

strFile = replace(strOrigFile,".csv",".xls")

Set objExcel = CreateObject("Excel.Application")

objExcel.Workbooks.Open strOrigFile

objExcel.ActiveWorkbook.SaveAs strFile, -4143

objExcel.ActiveWorkbook.Close

objExcel.Application.Quit

'******************************************************

'FORMAT THE EXCEL FILE AND SAVE IT

'******************************************************

objExcel.Workbooks.Open strFile

'Set the number format to zero D.P for specified columns

objExcel.columns("A:A").numberformat="0"

objExcel.columns("C:C").numberformat="0"

objExcel.columns("D:D").numberformat="0"

objExcel.ActiveWorkbook.SaveAs strFile, -4143

objExcel.ActiveWorkbook.Close

objExcel.Application.Quit

Set objExcel = Nothing

'msgbox "FINISHED!!!"

0
Question by:arundelr
• 5
• 3

LVL 8

Expert Comment

0

Author Comment

Hi,

Thanks for reply, I am still a little unsure. could you suggest an example using my script ?

Rob
0

LVL 85

Accepted Solution

Mike Tomlinson earned 500 total points
You access the parameters passed into your script using WScript.Arguments:
http://msdn.microsoft.com/en-us/library/z2b05k8s(VS.85).aspx

So you could do:

strOrigFile = WScript.Arguments(0)

0

Author Comment

Woo hoo - Perfect Idle_Mind - Thanks very much ;o)

Do you know how I can delete the input file ? I was trying...

strInputFile =WScript.Arguments(0)
objFSO.DeleteFile(strInputFile)

But not the correct syntax, as you amy have guessed I am new to VBS ;)
0

LVL 85

Expert Comment

It should work...try:

Set fso = CreateObject("Scripting.FileSystemObject")
fso.DeleteFile(strInputFile)
0

Author Comment

Hi,

I tried....

Set fso = CreateObject("Scripting.FileSystemObject")
strInputFile =WScript.Arguments(0)
fso.DeleteFile(strInputFile)

(I attached whole script also)

But I get error message:
Line: 61
Char: 1
Error: Variable is undefined "strInputFile"

Option Explicit

Dim fldr, f, file,strOrigFile, strFile, fso, strDirectory

Dim objExcel

'strOrigFile = "C:\testing\in.csv"

'******************************************************

'The input file name is passed at run time i.e. wscript C:\testing\csv_to_xls.vbs C:\testing\in.csv

'******************************************************

strOrigFile = WScript.Arguments(0)

'******************************************************

'CONVERTS THE FILE TO AN EXCEL FILE

'******************************************************

strFile = replace(strOrigFile,".csv",".xls")

Set objExcel = CreateObject("Excel.Application")

objExcel.Workbooks.Open strOrigFile

objExcel.ActiveWorkbook.SaveAs strFile, -4143

objExcel.ActiveWorkbook.Close

objExcel.Application.Quit

'******************************************************

'FORMAT THE EXCEL FILE AND SAVE IT

'******************************************************

objExcel.Workbooks.Open strFile

'Set the number format to zero D.P for specified columns

objExcel.columns("A:A").numberformat="0"

objExcel.columns("C:C").numberformat="0"

objExcel.columns("D:D").numberformat="0"

objExcel.ActiveWorkbook.SaveAs strFile, -4143

objExcel.ActiveWorkbook.Close

objExcel.Application.Quit

Set objExcel = Nothing

'msgbox "FINISHED!!!"

'******************************************************

'Delete the input file

'******************************************************

Set fso = CreateObject("Scripting.FileSystemObject")

strInputFile =WScript.Arguments(0)

fso.DeleteFile(strInputFile)

0

LVL 85

Assisted Solution

Mike Tomlinson earned 500 total points
You need to use YOUR variable names my friend...

Change:

Set fso = CreateObject("Scripting.FileSystemObject")
strInputFile =WScript.Arguments(0)
fso.DeleteFile(strInputFile)

To:

Set fso = CreateObject("Scripting.FileSystemObject")
fso.DeleteFile(strOrigFile)

0

Author Comment

"You need to use YOUR variable names my friend..."
*blush* - Ok, that was pretty dumb. lol

Thanks for your invaluable help ;o)

Rob
0

Author Closing Comment

Fantastic !
0

## Featured Post

### Suggested Solutions

In this article we want to have a look at the directory attributes which are used by Microsoft to store the so called Security Identifiers (SID). These SIDs plays an important role in delegating and granting permissions and in authentication of trus…
Well hello again!  Glad to see you've made it this far without giving up.  In this, the fourth installment of my popular series, I'm going to cover functions and subroutines, what they are, and why they are useful.  Just in case you stumbled onto th…
Sending a Secure fax is easy with eFax Corporate (http://www.enterprise.efax.com). First, Just open a new email message.  In the To field, type your recipient's fax number @efaxsend.com. You can even send a secure international fax — just include t…
Here's a very brief overview of the methods PRTG Network Monitor (https://www.paessler.com/prtg) offers for monitoring bandwidth, to help you decide which methods you´d like to investigate in more detail.  The methods are covered in more detail in o…