Improve company productivity with a Business Account.Sign Up

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 1572
  • Last Modified:

Modify show/hide script to close a div when open a new one

Hi,

I have a show/hide script that im using, using onmouseover to show/hide divs.

What I need help is, when user mouses over toggle2 link, it closes toggle1 div and opens toggle2 div, and so on.

At the moment all toggle divs will open and only close when you mouseover the toggle link again.

I have attached the full code im working on for ease of understanding.
<html><head>
<title>Rollover</title>
<style type="text/css">
.toggleBox {
	background: #ccc;
	margin: 10px 0;
	padding: 10px;
}
.toggleBox p.toggleLink {
	margin: 0;
	padding: 10px;
}
.toggleBox p.toggleLink a.link {
	text-decoration: underline;
	cursor: pointer;
}
.toggleBox .toggleContent {
	background: #fff;
	padding: 10px;
}
.toggleBox .toggleContent p {
	margin: 0;
}
</style>
<script type="text/javascript">
	function showhide(id){
		if (document.getElementById){
			obj = document.getElementById(id);
			if (obj.style.display == "none"){
				obj.style.display = "";
			} else {
				obj.style.display = "none";
			}
		}
	}
</script>
</head><body>
 
<div class="toggleBox">
	<p class="toggleLink"><a class="link" onmouseover="showhide('onmouseover'); return(false);">Show/hide on mouseover</a></p>
	<div class="toggleContent" id="onmouseover">
		<p>On mouseover content toggle</p>
	</div>
</div>
 
<div class="toggleBox">
	<p class="toggleLink"><a class="link" onmouseover="showhide('onmouseover2'); return(false);">Show/hide on mouseover</a></p>
	<div class="toggleContent" id="onmouseover2">
		<p>On mouseover content toggle</p>
	</div>
</div>
</body></html>

Open in new window

0
danwpeters
Asked:
danwpeters
  • 7
  • 5
1 Solution
 
danwpetersAuthor Commented:
togglle1, toggle2 is referring to onmouseover, onmouseover2 id's.
0
 
bluefezteamCommented:
Hmm well your function is only targetting the id it has been passed, it's unaware of the prescence of anything else in the document only what it's told.

If you know you have a set amount of boxes you can look at the ID being passed in and then alter the states of the other boxes.

On the principle that only 1 box is ever open at 1 time, then you can adapt your existing function to look at the state of the current box - it's already in there # if (obj.style.display == "none") # this determines if it's there or not (visible) if it's currently not visible then it opens it...

You need to just adapt it to close all boxes (which you can do because you have the IDs) and then run the existing line

obj.style.display = "";

which makes the current box (the one you want to open) visible.

Next time you click a different box, all boxes close (so the 1st one you opened) and then your script opens the current box (the new one)
0
 
bluefezteamCommented:
what Im basically trying to say is the element of your function (below) needs to close ALL your boxes first and then it will open the one you want.

If none are open it just opens it - this will give the effect that when a box is open it will close all of them and open the new one because thats the only box the function knows to operate (open)
if (obj.style.display == "none"){
 document.getElementById("box1").style.display = ""; 
 document.getElementById("box2").style.display = ""; 
 document.getElementById("box3").style.display = ""; 
 obj.style.display = ""; // this makes current box visible
} else {
 obj.style.display = "none";
}

Open in new window

0
Get 10% Off Your First Squarespace Website

Ready to showcase your work, publish content or promote your business online? With Squarespace’s award-winning templates and 24/7 customer service, getting started is simple. Head to Squarespace.com and use offer code ‘EXPERTS’ to get 10% off your first purchase.

 
danwpetersAuthor Commented:
Hi, thanks, but this doesn't seem to be working correctly, I get how your adapted code works, but am really only starting with JavaScript, could you help me a little more please?
0
 
bluefezteamCommented:
Yeah sure let me figure out the mechanics and I will get back to you with a working model - my example was more of a guidline.
0
 
bluefezteamCommented:
as a quick glance this should achieve something instantly:

when I mouse over any box they both shut and there on in only 1 opens at a time

hope that helps.
<html><head>
<title>Rollover</title>
<style type="text/css">
.toggleBox {
	background: #ccc;
	margin: 10px 0;
	padding: 10px;
}
.toggleBox p.toggleLink {
	margin: 0;
	padding: 10px;
}
.toggleBox p.toggleLink a.link {
	text-decoration: underline;
	cursor: pointer;
	display:block;
}
.toggleBox .toggleContent {
	background: #fff;
	padding: 10px;
}
.toggleBox .toggleContent p {
	margin: 0;
}
</style>
<script type="text/javascript">
	function showhide(id){
		if (document.getElementById){
			obj1 = document.getElementById("onmouseover");
			obj2 = document.getElementById("onmouseover2");
 
			obj = document.getElementById(id);
			if (obj.style.display == "none"){
				obj1.style.display = "none";
				obj2.style.display = "none";
 
				obj.style.display = "";
			} else {
				obj1.style.display = "none";
				obj2.style.display = "none";
 
				obj.style.display = "none";
			}
		}
	}
</script>
</head><body>
 
<div class="toggleBox">
	<p class="toggleLink"><a class="link" onmouseover="showhide('onmouseover'); return(false);">Show/hide on mouseover</a></p>
	<div class="toggleContent" id="onmouseover">
		<p>On mouseover content toggle</p>
	</div>
</div>
 
<div class="toggleBox">
	<p class="toggleLink"><a class="link" onmouseover="showhide('onmouseover2'); return(false);">Show/hide on mouseover</a></p>
	<div class="toggleContent" id="onmouseover2">
		<p>On mouseover content toggle</p>
	</div>
</div>
</body></html>

Open in new window

0
 
bluefezteamCommented:
If you need to add more divs then they need to be added to the function, it all stems from the fact that the original function only targetted the div it was passed during mouseover.

The function was given no other info to act on so it didnt know about the other items.
0
 
danwpetersAuthor Commented:
Thanks, is there any way of stopping the box from hiding if you mouse over an already active link?
0
 
bluefezteamCommented:
hey thats a seperate question, I only get 100 points :0P

The easiest option is to not to bother with mouseover, it's too fiddly especially if you accidentally touch the area. Opt for onClick instead - much more accurate to a users needs - when a user clicks it you know for a fact that they want to open or close that box.


<div class="toggleBox">
	<p class="toggleLink"><a class="link" onclick="showhide('onmouseover'); return(false);">Show/hide on mouseover</a></p>
	<div class="toggleContent" id="onmouseover">
		<p>On mouseover content toggle</p>
	</div>
</div>
 
<div class="toggleBox">
	<p class="toggleLink"><a class="link" onclick="showhide('onmouseover2'); return(false);">Show/hide on mouseover</a></p>
	<div class="toggleContent" id="onmouseover2">
		<p>On mouseover content toggle</p>
	</div>
</div>

Open in new window

0
 
bluefezteamCommented:
If you post that as a new question (which it is), I can receive additional points for further assistance.

I would say the onClick is much better for the user anyway.
0
 
danwpetersAuthor Commented:
Awsome help ;-)
0
 
danwpetersAuthor Commented:
I will try and opt for an onclick probably, thanks again ;-)
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Upgrade your Question Security!

Your question, your audience. Choose who sees your identity—and your question—with question security.

  • 7
  • 5
Tackle projects and never again get stuck behind a technical roadblock.
Join Now