?
Solved

Multiple Threads in C#

Posted on 2008-06-10
6
Medium Priority
?
1,983 Views
Last Modified: 2013-11-07
I am working on a class library that uses methods to create new threads that fire events when they are completed. Here's how it works.
1. Application calls method ResizeImageAsync(inputFile, outputFile, width, height);
2. The ResizeImageAsync() creates a new thread that runs in low priority with the IsBackground property = true.
3. The thread resizes the image and writes it to a folder based on the outputFile parameter.
3. The thread calls an event called OnResize(outputFile). The outputFile parameter is the value of the ResizeImageAsync() outputFile parameter.

The problem I am having is the ResizeImageAsync() method will be called multiple times at once. When I call it more than 30 times the computer hangs. I think it's because I am creating too many threads at once.
I haven't done very much multi-threading yet for an application so I'm not sure of which System.Threading class I should use to pool the threads so they are managed properly. I could just be disposing of the threads improperly as well.

I've attached some of the code in the application.
public event ResizeCompletedDelegate OnResize;
 
        public void ResizeImageMaxAsync(string imagePath, string outputPath, int maxWidth, int maxHeight)
        {
            Thread thread = new Thread(delegate()
                                           {
                                               this.ResizeImageMax(imagePath, outputPath, maxWidth, maxHeight);
 
                                               // Fire the completed event
                                               this.InvokeOnResize(outputPath);
                                           });
            thread.Priority = ThreadPriority.Lowest;
            thread.IsBackground = true;
            thread.Start();
        }
 
        private void InvokeOnResize(string filePath)
        {
            ResizeCompletedDelegate resizeDelegate = this.OnResize;
            if (resizeDelegate != null)
            {
                resizeDelegate(filePath);
            }
        }
 
 
// Application Usage Section.
 
// This is the event that will fire. It just writes out the path to the location of the resized image.
editor.OnResize += delegate(string outputFile)
        {
            Console.WriteLine("File: {0} Completed Resize", outputFile);
        };
 
// This is just an example of looping through multiple instances of the ResizeImageAbsoluteAsync method. It returns immediatelly after the thread is created and not when the thread has finished.
for (int i = 0; i < 60; i++)
{
    editor.ResizeImageAbsoluteAsync(imagePath, String.Format(outputPath, Guid.NewGuid().ToString()), 250, 250);
}

Open in new window

0
Comment
Question by:DuNuNuBatman
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 4
  • 2
6 Comments
 
LVL 12

Accepted Solution

by:
jandromeda earned 1500 total points
ID: 21752373
Use the ThreadPool to spawn new threads.
0
 

Author Comment

by:DuNuNuBatman
ID: 21752383
Also, is there a way I can limit the number of threads executed at one time. Ideally, it should be based on the number of cores the machine has because I don't want to be resizing 20 images at once. I want them to start returning as soon as possible.
0
 
LVL 12

Expert Comment

by:jandromeda
ID: 21752409
0
NFR key for Veeam Backup for Microsoft Office 365

Veeam is happy to provide a free NFR license (for 1 year, up to 10 users). This license allows for the non‑production use of Veeam Backup for Microsoft Office 365 in your home lab without any feature limitations.

 
LVL 12

Expert Comment

by:jandromeda
ID: 21752440
You can limit the number of threads using the SetMaxThreads() method of the ThreadPool class.
0
 

Author Comment

by:DuNuNuBatman
ID: 21752792
It doesn't look like I can set the thread priority using the ThreadPool class. Do you think creating a thread in the thread pool would be an issue?
I've been running it and it seems to be working correctly, but I don't know if that could cause problems.
Thread thread = new Thread(delegate()
                                                        {
                                                            this.ResizeImageMax(imagePath, outputPath, maxWidth, maxHeight);
 
                                                            // Fire the completed event
                                                            this.InvokeOnResize(outputPath);
                                                        });

Open in new window

0
 
LVL 12

Expert Comment

by:jandromeda
ID: 21752998
Well as far as I know you cannot set the thread priority when you are using ThreadPool but this class provides an efficient thread management functionality. If you use the approach you are using right now you will have to limit the number of threads created at a particular instance of time. But this functionality is already built into ThreadPool and since it is a framework class I think it is trouble free.
0

Featured Post

Free Tool: Subnet Calculator

The subnet calculator helps you design networks by taking an IP address and network mask and returning information such as network, broadcast address, and host range.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Introduction Hi all and welcome to my first article on Experts Exchange. A while ago, someone asked me if i could do some tutorials on object oriented programming. I decided to do them on C#. Now you may ask me, why's that? Well, one of the re…
A long time ago (May 2011), I have written an article showing you how to create a DLL using Visual Studio 2005 to be hosted in SQL Server 2005. That was valid at that time and it is still valid if you are still using these versions. You can still re…
Monitoring a network: how to monitor network services and why? Michael Kulchisky, MCSE, MCSA, MCP, VTSP, VSP, CCSP outlines the philosophy behind service monitoring and why a handshake validation is critical in network monitoring. Software utilized …
In this video, Percona Director of Solution Engineering Jon Tobin discusses the function and features of Percona Server for MongoDB. How Percona can help Percona can help you determine if Percona Server for MongoDB is the right solution for …
Suggested Courses

770 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question