Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people, just like you, are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
Solved

Multiple Threads in C#

Posted on 2008-06-10
6
1,960 Views
Last Modified: 2013-11-07
I am working on a class library that uses methods to create new threads that fire events when they are completed. Here's how it works.
1. Application calls method ResizeImageAsync(inputFile, outputFile, width, height);
2. The ResizeImageAsync() creates a new thread that runs in low priority with the IsBackground property = true.
3. The thread resizes the image and writes it to a folder based on the outputFile parameter.
3. The thread calls an event called OnResize(outputFile). The outputFile parameter is the value of the ResizeImageAsync() outputFile parameter.

The problem I am having is the ResizeImageAsync() method will be called multiple times at once. When I call it more than 30 times the computer hangs. I think it's because I am creating too many threads at once.
I haven't done very much multi-threading yet for an application so I'm not sure of which System.Threading class I should use to pool the threads so they are managed properly. I could just be disposing of the threads improperly as well.

I've attached some of the code in the application.
public event ResizeCompletedDelegate OnResize;
 
        public void ResizeImageMaxAsync(string imagePath, string outputPath, int maxWidth, int maxHeight)
        {
            Thread thread = new Thread(delegate()
                                           {
                                               this.ResizeImageMax(imagePath, outputPath, maxWidth, maxHeight);
 
                                               // Fire the completed event
                                               this.InvokeOnResize(outputPath);
                                           });
            thread.Priority = ThreadPriority.Lowest;
            thread.IsBackground = true;
            thread.Start();
        }
 
        private void InvokeOnResize(string filePath)
        {
            ResizeCompletedDelegate resizeDelegate = this.OnResize;
            if (resizeDelegate != null)
            {
                resizeDelegate(filePath);
            }
        }
 
 
// Application Usage Section.
 
// This is the event that will fire. It just writes out the path to the location of the resized image.
editor.OnResize += delegate(string outputFile)
        {
            Console.WriteLine("File: {0} Completed Resize", outputFile);
        };
 
// This is just an example of looping through multiple instances of the ResizeImageAbsoluteAsync method. It returns immediatelly after the thread is created and not when the thread has finished.
for (int i = 0; i < 60; i++)
{
    editor.ResizeImageAbsoluteAsync(imagePath, String.Format(outputPath, Guid.NewGuid().ToString()), 250, 250);
}

Open in new window

0
Comment
Question by:DuNuNuBatman
  • 4
  • 2
6 Comments
 
LVL 12

Accepted Solution

by:
jandromeda earned 500 total points
ID: 21752373
Use the ThreadPool to spawn new threads.
0
 

Author Comment

by:DuNuNuBatman
ID: 21752383
Also, is there a way I can limit the number of threads executed at one time. Ideally, it should be based on the number of cores the machine has because I don't want to be resizing 20 images at once. I want them to start returning as soon as possible.
0
 
LVL 12

Expert Comment

by:jandromeda
ID: 21752409
0
Space-Age Communications Transitions to DevOps

ViaSat, a global provider of satellite and wireless communications, securely connects businesses, governments, and organizations to the Internet. Learn how ViaSat’s Network Solutions Engineer, drove the transition from a traditional network support to a DevOps-centric model.

 
LVL 12

Expert Comment

by:jandromeda
ID: 21752440
You can limit the number of threads using the SetMaxThreads() method of the ThreadPool class.
0
 

Author Comment

by:DuNuNuBatman
ID: 21752792
It doesn't look like I can set the thread priority using the ThreadPool class. Do you think creating a thread in the thread pool would be an issue?
I've been running it and it seems to be working correctly, but I don't know if that could cause problems.
Thread thread = new Thread(delegate()
                                                        {
                                                            this.ResizeImageMax(imagePath, outputPath, maxWidth, maxHeight);
 
                                                            // Fire the completed event
                                                            this.InvokeOnResize(outputPath);
                                                        });

Open in new window

0
 
LVL 12

Expert Comment

by:jandromeda
ID: 21752998
Well as far as I know you cannot set the thread priority when you are using ThreadPool but this class provides an efficient thread management functionality. If you use the approach you are using right now you will have to limit the number of threads created at a particular instance of time. But this functionality is already built into ThreadPool and since it is a framework class I think it is trouble free.
0

Featured Post

Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Exception Handling is in the core of any application that is able to dignify its name. In this article, I'll guide you through the process of writing a DRY (Don't Repeat Yourself) Exception Handling mechanism, using Aspect Oriented Programming.
Calculating holidays and working days is a function that is often needed yet it is not one found within the Framework. This article presents one approach to building a working-day calculator for use in .NET.
This video shows how to quickly and easily add an email signature for all users on Exchange 2016. The resulting signature is applied on a server level by Exchange Online. The email signature template has been downloaded from: www.mail-signatures…

791 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question