Solved

Multiple Threads in C#

Posted on 2008-06-10
6
1,966 Views
Last Modified: 2013-11-07
I am working on a class library that uses methods to create new threads that fire events when they are completed. Here's how it works.
1. Application calls method ResizeImageAsync(inputFile, outputFile, width, height);
2. The ResizeImageAsync() creates a new thread that runs in low priority with the IsBackground property = true.
3. The thread resizes the image and writes it to a folder based on the outputFile parameter.
3. The thread calls an event called OnResize(outputFile). The outputFile parameter is the value of the ResizeImageAsync() outputFile parameter.

The problem I am having is the ResizeImageAsync() method will be called multiple times at once. When I call it more than 30 times the computer hangs. I think it's because I am creating too many threads at once.
I haven't done very much multi-threading yet for an application so I'm not sure of which System.Threading class I should use to pool the threads so they are managed properly. I could just be disposing of the threads improperly as well.

I've attached some of the code in the application.
public event ResizeCompletedDelegate OnResize;
 
        public void ResizeImageMaxAsync(string imagePath, string outputPath, int maxWidth, int maxHeight)
        {
            Thread thread = new Thread(delegate()
                                           {
                                               this.ResizeImageMax(imagePath, outputPath, maxWidth, maxHeight);
 
                                               // Fire the completed event
                                               this.InvokeOnResize(outputPath);
                                           });
            thread.Priority = ThreadPriority.Lowest;
            thread.IsBackground = true;
            thread.Start();
        }
 
        private void InvokeOnResize(string filePath)
        {
            ResizeCompletedDelegate resizeDelegate = this.OnResize;
            if (resizeDelegate != null)
            {
                resizeDelegate(filePath);
            }
        }
 
 
// Application Usage Section.
 
// This is the event that will fire. It just writes out the path to the location of the resized image.
editor.OnResize += delegate(string outputFile)
        {
            Console.WriteLine("File: {0} Completed Resize", outputFile);
        };
 
// This is just an example of looping through multiple instances of the ResizeImageAbsoluteAsync method. It returns immediatelly after the thread is created and not when the thread has finished.
for (int i = 0; i < 60; i++)
{
    editor.ResizeImageAbsoluteAsync(imagePath, String.Format(outputPath, Guid.NewGuid().ToString()), 250, 250);
}

Open in new window

0
Comment
Question by:DuNuNuBatman
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 4
  • 2
6 Comments
 
LVL 12

Accepted Solution

by:
jandromeda earned 500 total points
ID: 21752373
Use the ThreadPool to spawn new threads.
0
 

Author Comment

by:DuNuNuBatman
ID: 21752383
Also, is there a way I can limit the number of threads executed at one time. Ideally, it should be based on the number of cores the machine has because I don't want to be resizing 20 images at once. I want them to start returning as soon as possible.
0
 
LVL 12

Expert Comment

by:jandromeda
ID: 21752409
0
How Do You Stack Up Against Your Peers?

With today’s modern enterprise so dependent on digital infrastructures, the impact of major incidents has increased dramatically. Grab the report now to gain insight into how your organization ranks against your peers and learn best-in-class strategies to resolve incidents.

 
LVL 12

Expert Comment

by:jandromeda
ID: 21752440
You can limit the number of threads using the SetMaxThreads() method of the ThreadPool class.
0
 

Author Comment

by:DuNuNuBatman
ID: 21752792
It doesn't look like I can set the thread priority using the ThreadPool class. Do you think creating a thread in the thread pool would be an issue?
I've been running it and it seems to be working correctly, but I don't know if that could cause problems.
Thread thread = new Thread(delegate()
                                                        {
                                                            this.ResizeImageMax(imagePath, outputPath, maxWidth, maxHeight);
 
                                                            // Fire the completed event
                                                            this.InvokeOnResize(outputPath);
                                                        });

Open in new window

0
 
LVL 12

Expert Comment

by:jandromeda
ID: 21752998
Well as far as I know you cannot set the thread priority when you are using ThreadPool but this class provides an efficient thread management functionality. If you use the approach you are using right now you will have to limit the number of threads created at a particular instance of time. But this functionality is already built into ThreadPool and since it is a framework class I think it is trouble free.
0

Featured Post

Instantly Create Instructional Tutorials

Contextual Guidance at the moment of need helps your employees adopt to new software or processes instantly. Boost knowledge retention and employee engagement step-by-step with one easy solution.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

For those of you who don't follow the news, or just happen to live under rocks, Microsoft Research released a beta SDK (http://www.microsoft.com/en-us/download/details.aspx?id=27876) for the Xbox 360 Kinect. If you don't know what a Kinect is (http:…
Today I had a very interesting conundrum that had to get solved quickly. Needless to say, it wasn't resolved quickly because when we needed it we were very rushed, but as soon as the conference call was over and I took a step back I saw the correct …
Are you ready to implement Active Directory best practices without reading 300+ pages? You're in luck. In this webinar hosted by Skyport Systems, you gain insight into Microsoft's latest comprehensive guide, with tips on the best and easiest way…

730 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question