Solved

StreamWriter Close method

Posted on 2008-06-10
5
551 Views
Last Modified: 2013-12-17
I have a class that has streamwriter object declared on class level. sw is created in the class constructorI have methods that write to a file using sw. Something like:

internal class WriteData
{
    StreamWriter sw;
    // rest of the code
}

internal static class GlobalClass
{
    internal static WriteData writeData;
}

This way GlobalClass is accessible throghout the application. The problem is next:

1) How can I close streamwriter object, I need it to be closed when writeData is going to be destroyed? Calling sw.Close() in writeData destructor doesn't work.
2) is there any way I can check weather streamwriter object is "open", that is, weather something has been written to a file, other than the usual class level boolean variable that will be set to true when the method for writing data has been called?

If this looks confusing, I will explain better what you didn't understand.

Thanks,
Goran
0
Comment
Question by:Priest04
  • 3
5 Comments
 
LVL 18

Accepted Solution

by:
jcoehoorn earned 500 total points
Comment Utility
> "This way GlobalClass is accessible throghout (sic) the application."

Actually, because of the 'internal' modifier it's only available in that assembly.  If you move the code to a class library project the rest of the application won't be able to use it.

1) Your WriteData class should implement the IDisposable pattern (google it).  Call sw.Close() in your Dispose() method.  sw.Close should close the stream, though I have heard of cases where windows still thinks the file is locked later- I think it's a bug in MS' implementation of the class.  

2) I'm assuming you open the stream in the constructor?  If that's the case, don't worry about it, though you might try checking that sw.BaseStream.CanWrite returns True.

0
 
LVL 18

Author Comment

by:Priest04
Comment Utility
>> Actually, because of the 'internal' modifier it's only available in that assembly.  If you move the code to a class library project the rest of the application won't be able to use it.

That was the intention.

Do you know why is sw already closed when object's desctructor is called, but can be called in Dispose method?
0
 
LVL 18

Expert Comment

by:jcoehoorn
Comment Utility
Because .Net doesn't do 'destructors'.  When implemented correctly, you can call an IDisposable's Dispose() method as many times as you want without causing an error.
0
 
LVL 12

Expert Comment

by:renjurdevan
Comment Utility
you can open stream inside using block so once you came out of using block it will automatically disposed since it implements IDispose

and inside using block use try catch .. finally and in finally block close stream

so code will be like

using (create streamwriter here sw)
{
try {
...
...
...
}
catch (Exception ex)
{
...
}
finally
{
sw.close();
}
}
0
 
LVL 18

Expert Comment

by:jcoehoorn
Comment Utility
No need for the finally block or even to call sw.Close() if it was created with a using statement.  The using statement will make sure it's disposed.

But since the streamwriter is declared as a member of a class, he probably doesn't want a using statement here.
0

Featured Post

6 Surprising Benefits of Threat Intelligence

All sorts of threat intelligence is available on the web. Intelligence you can learn from, and use to anticipate and prepare for future attacks.

Join & Write a Comment

Wouldn’t it be nice if you could test whether an element is contained in an array by using a Contains method just like the one available on List objects? Wouldn’t it be good if you could write code like this? (CODE) In .NET 3.5, this is possible…
A long time ago (May 2011), I have written an article showing you how to create a DLL using Visual Studio 2005 to be hosted in SQL Server 2005. That was valid at that time and it is still valid if you are still using these versions. You can still re…
Illustrator's Shape Builder tool will let you combine shapes visually and interactively. This video shows the Mac version, but the tool works the same way in Windows. To follow along with this video, you can draw your own shapes or download the file…
This tutorial demonstrates a quick way of adding group price to multiple Magento products.

763 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

10 Experts available now in Live!

Get 1:1 Help Now