Coldfusion query help URGENT

Erik,

You are missing an AND statement between the "EmployeeID = #getPairs.GTLID#" and the "CourseID". Try attached code.

<cfset courseList = "">
<cfif getPairs.CourseID eq 1634>
	<cfif (courseList) IS NOT "">
		<cfset courseList = "#courseList#,1647, 1648">
	<cfelse>
		<cfset courseList = "1647, 1648">
	</cfif>
</cfif>
<cfif getPairs.CourseID eq 1635>
	<cfif (courseList) IS NOT "">
		<cfset courseList = "#courseList#,1645,1646">
	<cfelse>
		<cfset courseList = "1645,1646">
	</cfif>
</cfif>
<cfif getPairs.CourseID eq 1636>
	<cfif (courseList) IS NOT "">
		<cfset courseList = "#courseList#,1649,1650">
	<cfelse>
		<cfset courseList = "1649,1650">
	</cfif>
</cfif>
<cfif getPairs.CourseID eq 1632>
	<cfif (courseList) IS NOT "">
		<cfset courseList = "#courseList#,1651,1652">
	<cfelse>
		<cfset courseList = "1651,1652">
	</cfif>
</cfif>
<cfif getPairs.CourseID eq 1637>
	<cfif (courseList) IS NOT "">
		<cfset courseList = "#courseList#,1653,1654">
	<cfelse>
		<cfset courseList = "1653,1654">
	</cfif>
</cfif>
<cfif getPairs.CourseID eq 1633>
	<cfif (courseList) IS NOT "">
		<cfset courseList = "#courseList#,1655,1656">
	<cfelse>
		<cfset courseList = "1655,1656">
	</cfif>
</cfif>
 
<cfquery name="getStepsCompleted" datasource="cfelsunrise" dbtype="ODBC">
	SELECT max(CompletionDate) as completiondate,
		CourseID
	FROM employeetraining
	WHERE EmployeeID = #getPairs.GTLID# 
		AND CourseID IN (#courseList#)
	GROUP BY CourseID 
</cfquery>

Select allOpen in new window

i did not miss anyhting
If you look at the condition that where it gets added

Am I missing something? In the code you included in your question, the only AND clause is commented out. Also, if you are going to add an AND clause and a bunch of OR clauses, then you probably need to use parenthesis around all the OR statements or the AND clause is escaped in the second OR.

What you have is something like:

condition1 AND condition2 OR condition3 OR condition4

Which is the same as saying:

(condition1 AND condition2)
OR
(condition3)
OR
(condition4)

This works if you are trying to get information for the employee or the course. If I understand what you want (getting info for employee and course), then it should be more like:

(condition1) AND (condition2 OR condition3 OR condition4)

... which produces the logic:

(condition1 AND condition2)
OR
(condition1 AND condition3)
OR
(condition1 AND condition4)

The query is pretty straight forward and I can't really think of anything else it could be.

Erik,

If the "getPairs.CourseID" is supposed to return multiple values, then the problem will be in the way you output that from the "getPairs" query. Is it an array or list? If so, then you can try something like:

<cfset courseList = #ArrayToList(getPairs.CourseID, ",")#>
<cfset courseList = #REReplace(courseList, "1634", "1647,1648", "ALL")#>
<cfset courseList = #REReplace(courseList, "1635", "1645,1646", "ALL")#>
<cfset courseList = #REReplace(courseList, "1636", "1649,1650", "ALL")#>
<cfset courseList = #REReplace(courseList, "1632", "1651,1652", "ALL")#>
<cfset courseList = #REReplace(courseList, "1637", "1653,1654", "ALL")#>
<cfset courseList = #REReplace(courseList, "1633", "1655,1656", "ALL")#>

<cfquery name="getStepsCompleted" datasource="cfelsunrise" dbtype="ODBC">
      SELECT max(CompletionDate) as completiondate,CourseID
      FROM employeetraining
      WHERE EmployeeID = #getPairs.GTLID# AND
            (CourseID in (#courseList#)
      GROUP BY CourseID
</cfquery>

Otherwise, you may have to address the way the first query returns its values.

Sorry ... missing parenthesis after "(CourseID in (#courseList#)". Should be:

(CourseID in (#courseList#))

it is an array