[Last Call] Learn how to a build a cloud-first strategyRegister Now

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 190
  • Last Modified:

Coldfusion query help URGENT

I am trying to build the dynamic cfquery but does not seems to be working correctly it works fine when there is a asingle course but when multiple it does not .
Please help

<cfquery name="getStepsCompleted" datasource="cfelsunrise" dbtype="ODBC">
					select max(CompletionDate) as completiondate,CourseID
					from employeetraining
					where EmployeeID = #getPairs.GTLID# 
					<!---<cfif getPairs.CourseID eq 1600>
						and CourseID in (1600)
					</cfif>--->
					<cfif getPairs.CourseID eq 1634>
						or CourseID in (1647, 1648)
					</cfif>
					<cfif getPairs.CourseID eq 1635>
						or CourseID in (1645,1646)
						</cfif>
					<cfif getPairs.CourseID eq 1636>
						or CourseID in (1649,1650)
					</cfif>
					<cfif getPairs.CourseID eq 1632>
						or CourseID in (1651,1652)
					</cfif>
					<cfif getPairs.CourseID eq 1637>
						or CourseID in (1653,1654)
				</cfif>
					<cfif getPairs.CourseID eq 1633>
						or CourseID in (1655,1656)
					</cfif>
						group by CourseID 
				</cfquery>

Open in new window

0
erikTsomik
Asked:
erikTsomik
  • 5
  • 2
1 Solution
 
msfletchCommented:
Erik,

You are missing an AND statement between the "EmployeeID = #getPairs.GTLID#" and the "CourseID". Try attached code.
<cfset courseList = "">
<cfif getPairs.CourseID eq 1634>
	<cfif (courseList) IS NOT "">
		<cfset courseList = "#courseList#,1647, 1648">
	<cfelse>
		<cfset courseList = "1647, 1648">
	</cfif>
</cfif>
<cfif getPairs.CourseID eq 1635>
	<cfif (courseList) IS NOT "">
		<cfset courseList = "#courseList#,1645,1646">
	<cfelse>
		<cfset courseList = "1645,1646">
	</cfif>
</cfif>
<cfif getPairs.CourseID eq 1636>
	<cfif (courseList) IS NOT "">
		<cfset courseList = "#courseList#,1649,1650">
	<cfelse>
		<cfset courseList = "1649,1650">
	</cfif>
</cfif>
<cfif getPairs.CourseID eq 1632>
	<cfif (courseList) IS NOT "">
		<cfset courseList = "#courseList#,1651,1652">
	<cfelse>
		<cfset courseList = "1651,1652">
	</cfif>
</cfif>
<cfif getPairs.CourseID eq 1637>
	<cfif (courseList) IS NOT "">
		<cfset courseList = "#courseList#,1653,1654">
	<cfelse>
		<cfset courseList = "1653,1654">
	</cfif>
</cfif>
<cfif getPairs.CourseID eq 1633>
	<cfif (courseList) IS NOT "">
		<cfset courseList = "#courseList#,1655,1656">
	<cfelse>
		<cfset courseList = "1655,1656">
	</cfif>
</cfif>
 
<cfquery name="getStepsCompleted" datasource="cfelsunrise" dbtype="ODBC">
	SELECT max(CompletionDate) as completiondate,
		CourseID
	FROM employeetraining
	WHERE EmployeeID = #getPairs.GTLID# 
		AND CourseID IN (#courseList#)
	GROUP BY CourseID 
</cfquery>

Open in new window

0
 
erikTsomikSystem Architect, CF programmer Author Commented:
i did not miss anyhting
If you look at the condition that where it gets added
0
 
msfletchCommented:
Am I missing something? In the code you included in your question, the only AND clause is commented out. Also, if you are going to add an AND clause and a bunch of OR clauses, then you probably need to use parenthesis around all the OR statements or the AND clause is escaped in the second OR.

What you have is something like:

condition1 AND condition2 OR condition3 OR condition4

Which is the same as saying:

(condition1 AND condition2)
OR
(condition3)
OR
(condition4)

This works if you are trying to get information for the employee or the course. If I understand what you want (getting info for employee and course), then it should be more like:

(condition1) AND (condition2 OR condition3 OR condition4)

... which produces the logic:

(condition1 AND condition2)
OR
(condition1 AND condition3)
OR
(condition1 AND condition4)

The query is pretty straight forward and I can't really think of anything else it could be.
0
Prepare for your VMware VCP6-DCV exam.

Josh Coen and Jason Langer have prepared the latest edition of VCP study guide. Both authors have been working in the IT field for more than a decade, and both hold VMware certifications. This 163-page guide covers all 10 of the exam blueprint sections.

 
msfletchCommented:
Erik,

If the "getPairs.CourseID" is supposed to return multiple values, then the problem will be in the way you output that from the "getPairs" query. Is it an array or list? If so, then you can try something like:

<cfset courseList = #ArrayToList(getPairs.CourseID, ",")#>
<cfset courseList = #REReplace(courseList, "1634", "1647,1648", "ALL")#>
<cfset courseList = #REReplace(courseList, "1635", "1645,1646", "ALL")#>
<cfset courseList = #REReplace(courseList, "1636", "1649,1650", "ALL")#>
<cfset courseList = #REReplace(courseList, "1632", "1651,1652", "ALL")#>
<cfset courseList = #REReplace(courseList, "1637", "1653,1654", "ALL")#>
<cfset courseList = #REReplace(courseList, "1633", "1655,1656", "ALL")#>

<cfquery name="getStepsCompleted" datasource="cfelsunrise" dbtype="ODBC">
      SELECT max(CompletionDate) as completiondate,CourseID
      FROM employeetraining
      WHERE EmployeeID = #getPairs.GTLID# AND
            (CourseID in (#courseList#)
      GROUP BY CourseID
</cfquery>

Otherwise, you may have to address the way the first query returns its values.
0
 
msfletchCommented:
Sorry ... missing parenthesis after "(CourseID in (#courseList#)". Should be:

(CourseID in (#courseList#))
0
 
erikTsomikSystem Architect, CF programmer Author Commented:
it is an array
0
 
msfletchCommented:
In that case, an EQ will not work in the WHERE clause. Easiest is to convert it to a list so you can then swap out the CourseIDs as you do currently in the WHERE clause, and then simply include the list in the IN statement.

Did the included code snippet not work?
<cfset courseList = #ArrayToList(getPairs.CourseID, ",")#>
<cfset courseList = #REReplace(courseList, "1634", "1647,1648", "ALL")#>
<cfset courseList = #REReplace(courseList, "1635", "1645,1646", "ALL")#>
<cfset courseList = #REReplace(courseList, "1636", "1649,1650", "ALL")#>
<cfset courseList = #REReplace(courseList, "1632", "1651,1652", "ALL")#>
<cfset courseList = #REReplace(courseList, "1637", "1653,1654", "ALL")#>
<cfset courseList = #REReplace(courseList, "1633", "1655,1656", "ALL")#>
 
<cfquery name="getStepsCompleted" datasource="cfelsunrise" dbtype="ODBC">
      SELECT max(CompletionDate) as completiondate,CourseID
      FROM employeetraining
      WHERE EmployeeID = #getPairs.GTLID# 
            AND (CourseID in (#courseList#))
      GROUP BY CourseID 
</cfquery>

Open in new window

0

Featured Post

NEW Veeam Agent for Microsoft Windows

Backup and recover physical and cloud-based servers and workstations, as well as endpoint devices that belong to remote users. Avoid downtime and data loss quickly and easily for Windows-based physical or public cloud-based workloads!

  • 5
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now