• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 257
  • Last Modified:

How to optimize my code to make it more flexible to add more item in the future

PHP

i have 2 php file
one is config.php and another is main.php

i want to insert data to diffrent file name based on UID given

i had done code for this but i think it is not flexible enough
code snippet is my code

Code i create is not user friendly or is not dynamic but static

expample
if i want to add more file like
$file4 = TEST4_TEXT;

at the moment my UID is 1,2,3

what happen if i want to add UID 4?

The SWITCH cannot read UID 4 and $file4
how to modified it?



--config.php--
$file1 = TEST1_TEXT;
$file2 = TEST2_TEXT;
$file3 = TEST3_TEXT;
 
 
--main.php--
switch($UID)
   {
 case 1: $fn = $file1; break;
 case 2: $fn = $file2; break;
 case 3: $fn = $file3; break;
   }
file_put_contents('c:\\'.$fn.'.txt',$data1,FILE_APPEND);
}

Open in new window

0
firekiller15
Asked:
firekiller15
  • 3
  • 2
1 Solution
 
bansidharCommented:
easiest method if you have a logic for the name of the text file:

--main.php--
$fn = "TEST{$UID}_TEXT";
file_put_contents('c:\\'.$fn.'.txt',$data1,FILE_APPEND);

You don't  need a config.php here. Here for any new $UID a new file is created.

Method 2:
If you want more  flexibility in naming file names and you are sure about the UIDs. In this you just add another UID in the config.php
--config.php--
$file[1] = "TEST1_TEXT";
$file[2] = "TEST2_TEXT";
$file[3] = "TEST3_TEXT";
$file[4] = "TEST4_TEXT";
 
-- main.php --
include ('config.php');
$fn=(isset($file[$UID]))?$file[$UID]:'unknownUID';
file_put_contents('c:\\'.$fn.'.txt',$data1,FILE_APPEND);

Open in new window

0
 
firekiller15Author Commented:
How about if UID is known?
i can be 1 or 10 o100 how>
0
 
bansidharCommented:
in Method 2: just add the file name in the config.php like if you want for UID=23 add the line no need to change the main.php

$file[23] = "TEST23_TEXT";

this will create TEXT23_TEXT.txt when it hits UID 23.

in Method 1: you don't have to do anything, it will automatically create TEXT23_TEXT.txt
0
 
firekiller15Author Commented:
that mean if i have data as follow in database table
UID  AMOUNT  TYPE  
23     5               A
26     6               A

is the data 23,5,A will go to TEST23_TEXT?
and
26,6,A should not got to TEST23_TEXT
0
 
firekiller15Author Commented:
why only test1 and test2 output on the drive test3 is not shown
0

Featured Post

[Webinar] Improve your customer journey

A positive customer journey is important in attracting and retaining business. To improve this experience, you can use Google Maps APIs to increase checkout conversions, boost user engagement, and optimize order fulfillment. Learn how in this webinar presented by Dito.

  • 3
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now