Solved

MSSQL query changed to MySQL shows not valid mysql resource

Posted on 2008-06-12
6
557 Views
Last Modified: 2008-08-05
Alright

I worked on this for hours and I'm stuck. Below I pasted the script from a working MSSQL login which I changed to use with MySQL. I know that there are syntax differences and the hours I spent was replacing some of them in this script but I've got no where.

I keep getting invalid mysql result resource. Usually on ($result=mysql_query($sql);) however it changes to other lines depending the script.

A fix would be great I'm assuming its a quick thing I cant believe I cant get it working from my MySql book and online!
session_start();
  $user="##";
  $host="##";
  $password="##";
  $database="##";
 
mysql_connect("$host", "$user", "$password")or die("cannot connect");
mysql_select_db("$database")or die("cannot select DB");
 
$sql="SELECT * FROM users WHERE username='$_POST[myusername]' AND pass='$_POST[mypassword]'";
$result=mysql_query($sql);
 
// mysql_num_row is counting table row
$count=mysql_num_rows($result);
// If result matched $myusername and $mypassword, table row must be 1 row
 
if($count==1) //Login details were found so auth
{

Open in new window

0
Comment
Question by:Ryan Bayne
  • 3
  • 3
6 Comments
 
LVL 17

Accepted Solution

by:
nanharbison earned 300 total points
ID: 21774686
If you are using variables for MySQL functions, don't use quotes. So change
mysql_connect("$host", "$user", "$password")
to
mysql_connect($host, $user, $password)
and change this:
$sql="SELECT * FROM users WHERE username='$_POST[myusername]' AND pass='$_POST[mypassword]'";

to this:
$sql="SELECT * FROM users WHERE username='".$_POST['myusername']."' AND pass='".$_POST['mypassword']."'";

because if you are using post and get variables you have to separate them from the code with a double quote and a dot. I also think you need to add single quotes to $_POST[myusername] inside the brackets, the way I did it in the changed version. I always forget if you HAVE to do it.
0
 
LVL 17

Expert Comment

by:nanharbison
ID: 21774689
the use of double and single quotes, and having to set off variables that are in the form $_POST[] and $_SESSION[], etc always slays me!
0
 
LVL 2

Author Comment

by:Ryan Bayne
ID: 21774799
Well your changes are correct and as you will see in my code below I needed to change the quotes.

I've arrived at a point I did reach myself prior to this question but ended up starting again maybe this time you can help me.

// mssql_num_row is counting table row
$count=mysql_num_rows($result);

That line results in... mysql_num_rows(): supplied argument is not a valid MySQL result resource in
I did think there was a different way to do this with mysql but I'm thinking I dreamed that up!

ideas? thanks so far
<?php
//Processes attempted login
//Retrieves users access permission and fowards to required page depending on that users authorisation
session_start();
 
  $user="##";
  $host="##";
  $password="##";
  $database="##";
 
mysql_connect($host, $user, $password)or die("cannot connect");
mysql_select_db("$database")or die("cannot select DB");
 
$sql='SELECT * FROM users WHERE username="$_POST[myusername]" AND pass="$_POST[mypassword]"';
$result=mysql_query($sql);
 
// mssql_num_row is counting table row
$count=mysql_num_rows($result);
// If result matched $myusername and $mypassword, table row must be 1 row
 
		
if($count==1 && $level=='closed')//Send to account closed page
{
	$_SESSION['auth']="yes";
	header("location: index.php?pagecell=closed.php");
}
else if($count==1 && $level=='master')//Send to web master page
{
	$_SESSION['auth']="yes";
	header("location: index.php?pagecell=admin/webmaster.php");
}
else if($count==1 && $level=='admin')//Send to basic admin area
{
	$_SESSION['auth']="yes";
	header("location: index.php?pagecell=closed.php");
}
else if($count==1 && $level=='member')//Send to member page
{
	$_SESSION['auth']="yes";
	header("location: index.php?pagecell=closed.php");
}
else
{
	header("location: index.php?cell=pagecells/loginfail.php");
	exit();
}
 
?> 

Open in new window

0
Ransomware-A Revenue Bonanza for Service Providers

Ransomware – malware that gets on your customers’ computers, encrypts their data, and extorts a hefty ransom for the decryption keys – is a surging new threat.  The purpose of this eBook is to educate the reader about ransomware attacks.

 
LVL 2

Author Comment

by:Ryan Bayne
ID: 21774882
I think thats it done. Had to mess around with the quotes and stuff a bit more. Actually I better review what I done I cant remember lol

THANKS
<?php
//Processes attempted login
//Retrieves users access permission and fowards to required page depending on that users authorisation
session_start();
 
  $user="root";
  $host="localhost";
  $password="25130217cmt";
  $database="WebTG2008";
 
mysql_connect($host, $user, $password)or die("cannot connect");
mysql_select_db("$database")or die("cannot select DB");
 
$sql='SELECT * FROM users WHERE username="$_POST[myusername]" AND password="$_POST[mypassword]"';
 
$result=mysql_query($sql);
 
// mssql_num_row is counting table row
$count = mysql_num_rows($result);
// If result matched $myusername and $mypassword, table row must be 1 row
 
		
if($count==1 && $level=='closed')//Send to account closed page
{
	$_SESSION['auth']="yes";
	header("location: index.php?pagecell=closed.php");
}
else if($count==1 && $level=='master')//Send to web master page
{
	$_SESSION['auth']="yes";
	header("location: index.php?pagecell=admin/webmaster.php");
}
else if($count==1 && $level=='admin')//Send to basic admin area
{
	$_SESSION['auth']="yes";
	header("location: index.php?pagecell=closed.php");
}
else if($count==1 && $level=='member')//Send to member page
{
	$_SESSION['auth']="yes";
	header("location: index.php?pagecell=closed.php");
}
else
{
	header("location: index.php?cell=pagecells/loginfail.php");
	exit();
}
 
?> 

Open in new window

0
 
LVL 2

Author Comment

by:Ryan Bayne
ID: 21774888
oops put database details. dont worry its a test db only on testing environment with no data
0
 
LVL 17

Expert Comment

by:nanharbison
ID: 21777404
So you got the mysql_num_rows to work? You get that error when there is something wrong with the query or there is no data returned. You might be better off saying:
if ($count = mysql_num_rows($result)) {

      do something

}


0

Featured Post

Free learning courses: Active Directory Deep Dive

Get a firm grasp on your IT environment when you learn Active Directory best practices with Veeam! Watch all, or choose any amount, of this three-part webinar series to improve your skills. From the basics to virtualization and backup, we got you covered.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

More Fun with XML and MySQL – Parsing Delimited String with a Single SQL Statement Are you ready for another of my SQL tidbits?  Hopefully so, as in this adventure, I will be covering a topic that comes up a lot which is parsing a comma (or other…
I have been using r1soft Continuous Data Protection (http://www.r1soft.com/linux-cdp/) for many years now with the mySQL Addon and wanted to share a trick I have used several times. For those of us that don't have the luxury of using all transact…
Email security requires an ever evolving service that stays up to date with counter-evolving threats. The Email Laundry perform Research and Development to ensure their email security service evolves faster than cyber criminals. We apply our Threat…

828 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question