Solved

MSSQL query changed to MySQL shows not valid mysql resource

Posted on 2008-06-12
6
554 Views
Last Modified: 2008-08-05
Alright

I worked on this for hours and I'm stuck. Below I pasted the script from a working MSSQL login which I changed to use with MySQL. I know that there are syntax differences and the hours I spent was replacing some of them in this script but I've got no where.

I keep getting invalid mysql result resource. Usually on ($result=mysql_query($sql);) however it changes to other lines depending the script.

A fix would be great I'm assuming its a quick thing I cant believe I cant get it working from my MySql book and online!
session_start();

  $user="##";

  $host="##";

  $password="##";

  $database="##";

 

mysql_connect("$host", "$user", "$password")or die("cannot connect");

mysql_select_db("$database")or die("cannot select DB");
 

$sql="SELECT * FROM users WHERE username='$_POST[myusername]' AND pass='$_POST[mypassword]'";

$result=mysql_query($sql);

 

// mysql_num_row is counting table row

$count=mysql_num_rows($result);

// If result matched $myusername and $mypassword, table row must be 1 row

 

if($count==1) //Login details were found so auth

{

Open in new window

0
Comment
Question by:Ryan Bayne
  • 3
  • 3
6 Comments
 
LVL 17

Accepted Solution

by:
nanharbison earned 300 total points
ID: 21774686
If you are using variables for MySQL functions, don't use quotes. So change
mysql_connect("$host", "$user", "$password")
to
mysql_connect($host, $user, $password)
and change this:
$sql="SELECT * FROM users WHERE username='$_POST[myusername]' AND pass='$_POST[mypassword]'";

to this:
$sql="SELECT * FROM users WHERE username='".$_POST['myusername']."' AND pass='".$_POST['mypassword']."'";

because if you are using post and get variables you have to separate them from the code with a double quote and a dot. I also think you need to add single quotes to $_POST[myusername] inside the brackets, the way I did it in the changed version. I always forget if you HAVE to do it.
0
 
LVL 17

Expert Comment

by:nanharbison
ID: 21774689
the use of double and single quotes, and having to set off variables that are in the form $_POST[] and $_SESSION[], etc always slays me!
0
 
LVL 2

Author Comment

by:Ryan Bayne
ID: 21774799
Well your changes are correct and as you will see in my code below I needed to change the quotes.

I've arrived at a point I did reach myself prior to this question but ended up starting again maybe this time you can help me.

// mssql_num_row is counting table row
$count=mysql_num_rows($result);

That line results in... mysql_num_rows(): supplied argument is not a valid MySQL result resource in
I did think there was a different way to do this with mysql but I'm thinking I dreamed that up!

ideas? thanks so far
<?php

//Processes attempted login

//Retrieves users access permission and fowards to required page depending on that users authorisation

session_start();
 

  $user="##";

  $host="##";

  $password="##";

  $database="##";

 

mysql_connect($host, $user, $password)or die("cannot connect");

mysql_select_db("$database")or die("cannot select DB");
 

$sql='SELECT * FROM users WHERE username="$_POST[myusername]" AND pass="$_POST[mypassword]"';

$result=mysql_query($sql);

 

// mssql_num_row is counting table row

$count=mysql_num_rows($result);

// If result matched $myusername and $mypassword, table row must be 1 row
 

		

if($count==1 && $level=='closed')//Send to account closed page

{

	$_SESSION['auth']="yes";

	header("location: index.php?pagecell=closed.php");

}

else if($count==1 && $level=='master')//Send to web master page

{

	$_SESSION['auth']="yes";

	header("location: index.php?pagecell=admin/webmaster.php");

}

else if($count==1 && $level=='admin')//Send to basic admin area

{

	$_SESSION['auth']="yes";

	header("location: index.php?pagecell=closed.php");

}

else if($count==1 && $level=='member')//Send to member page

{

	$_SESSION['auth']="yes";

	header("location: index.php?pagecell=closed.php");

}

else

{

	header("location: index.php?cell=pagecells/loginfail.php");

	exit();

}
 

?> 

Open in new window

0
How your wiki can always stay up-to-date

Quip doubles as a “living” wiki and a project management tool that evolves with your organization. As you finish projects in Quip, the work remains, easily accessible to all team members, new and old.
- Increase transparency
- Onboard new hires faster
- Access from mobile/offline

 
LVL 2

Author Comment

by:Ryan Bayne
ID: 21774882
I think thats it done. Had to mess around with the quotes and stuff a bit more. Actually I better review what I done I cant remember lol

THANKS
<?php

//Processes attempted login

//Retrieves users access permission and fowards to required page depending on that users authorisation

session_start();
 

  $user="root";

  $host="localhost";

  $password="25130217cmt";

  $database="WebTG2008";

 

mysql_connect($host, $user, $password)or die("cannot connect");

mysql_select_db("$database")or die("cannot select DB");
 

$sql='SELECT * FROM users WHERE username="$_POST[myusername]" AND password="$_POST[mypassword]"';
 

$result=mysql_query($sql);

 

// mssql_num_row is counting table row

$count = mysql_num_rows($result);

// If result matched $myusername and $mypassword, table row must be 1 row
 

		

if($count==1 && $level=='closed')//Send to account closed page

{

	$_SESSION['auth']="yes";

	header("location: index.php?pagecell=closed.php");

}

else if($count==1 && $level=='master')//Send to web master page

{

	$_SESSION['auth']="yes";

	header("location: index.php?pagecell=admin/webmaster.php");

}

else if($count==1 && $level=='admin')//Send to basic admin area

{

	$_SESSION['auth']="yes";

	header("location: index.php?pagecell=closed.php");

}

else if($count==1 && $level=='member')//Send to member page

{

	$_SESSION['auth']="yes";

	header("location: index.php?pagecell=closed.php");

}

else

{

	header("location: index.php?cell=pagecells/loginfail.php");

	exit();

}
 

?> 

Open in new window

0
 
LVL 2

Author Comment

by:Ryan Bayne
ID: 21774888
oops put database details. dont worry its a test db only on testing environment with no data
0
 
LVL 17

Expert Comment

by:nanharbison
ID: 21777404
So you got the mysql_num_rows to work? You get that error when there is something wrong with the query or there is no data returned. You might be better off saying:
if ($count = mysql_num_rows($result)) {

      do something

}


0

Featured Post

What Is Threat Intelligence?

Threat intelligence is often discussed, but rarely understood. Starting with a precise definition, along with clear business goals, is essential.

Join & Write a Comment

Foreword This is an old article.  Instead of using the MySQL extension that was used in the original code examples, please choose one of the currently supported database extensions instead.  More information is available here: MySQLi / PDO (http://…
Password hashing is better than message digests or encryption, and you should be using it instead of message digests or encryption.  Find out why and how in this article, which supplements the original article on PHP Client Registration, Login, Logo…
Get a first impression of how PRTG looks and learn how it works.   This video is a short introduction to PRTG, as an initial overview or as a quick start for new PRTG users.
Here's a very brief overview of the methods PRTG Network Monitor (https://www.paessler.com/prtg) offers for monitoring bandwidth, to help you decide which methods you´d like to investigate in more detail.  The methods are covered in more detail in o…

708 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

19 Experts available now in Live!

Get 1:1 Help Now