Solved

Dynamic SQL INSERT Error

Posted on 2008-06-13
4
176 Views
Last Modified: 2010-03-19
I am trying to create some dynamic SQL, when I hard code values in it works fine but when I try and put variables in I get the error message:

Msg 207, Level 16, State 1, Line 8
Invalid column name 'JewsonTest'.

Which is refering to:

SET @BranchCSVFileName = JewsonTest (this is a table name)

Can someone please tell me where I am going wrong??

My code is as follows:

DECLARE @BranchCSVFileName varchar(255)

DECLARE @lat numeric(18,6)

DECLARE @lon numeric(18,6)

DECLARE @MaxDistance int

DECLARE @dynamicdistancesql varchar(1000)
 

SET @BranchCSVFileName = JewsonTest

SET @lat = 51.400444

SET @lon = -1.318205

SET @MaxDistance = 10

SET @dynamicdistancesql = 'INSERT INTO '+@BranchCSVFileName+' (DistanceMiles, Postcode, Lat, Lon)

SELECT * FROM (SELECT CAST(dbo.Distance('+@lat+', '+@lon+', Lat, Lon) as decimal (10,1)) As DistanceMiles, [Postcode], [Lat], [Lon]

FROM [Postcodes]

WHERE (Lat <> 0) AND (Lon <> 0)) As T WHERE DistanceMiles<='+@MaxDistance+' ORDER BY DistanceMiles'

Exec (@dynamicdistancesql)

Open in new window

0
Comment
Question by:james1977
  • 2
4 Comments
 
LVL 43

Accepted Solution

by:
TimCottee earned 200 total points
ID: 21777509
Hello james1977,

It still needs to be quoted as it is a string value:
Set @BranchCSVFileName = 'JewsonTest'

Regards,

TimCottee
0
 
LVL 75

Expert Comment

by:Aneesh Retnakaran
ID: 21778560

DECLARE @BranchCSVFileName varchar(255)

DECLARE @lat varchar(40)  ---numeric(18,6)   change 1 

DECLARE @lon varchar(40)  ---numeric(18,6)   change 2

DECLARE @MaxDistance varchar(10) --- int     change 3

DECLARE @dynamicdistancesql varchar(1000)

 

SET @BranchCSVFileName = 'JewsonTest'

SET @lat = 51.400444

SET @lon = -1.318205

SET @MaxDistance = 10

SET @dynamicdistancesql = 'INSERT INTO '+@BranchCSVFileName  +' (DistanceMiles, Postcode, Lat, Lon)

SELECT * FROM (SELECT CAST(dbo.Distance('+@lat+', '+@lon+', Lat, Lon) as decimal (10,1)) As DistanceMiles, [Postcode], [Lat], [Lon]

FROM [Postcodes]

WHERE (Lat <> 0) AND (Lon <> 0)) As T WHERE DistanceMiles<='+@MaxDistance+' ORDER BY DistanceMiles'

EXEC( @dynamicdistancesql ) 

Open in new window

0
 

Author Comment

by:james1977
ID: 21778918
Ah I think i've got it, once I did as you suggested it came up with an error converting varchar to numeric so I changed all my variables to varchar and it ran fine.

Thanks very much for your helping hand.
DECLARE @BranchCSVFileName varchar(255)

DECLARE @lat varchar(20)

DECLARE @lon varchar(20)

DECLARE @MaxDistance varchar(10)

DECLARE @dynamicdistancesql varchar(1000)
 

SET @BranchCSVFileName = 'JewsonTest'

SET @lat = 51.400444

SET @lon = -1.318205

SET @MaxDistance = 10

SET @dynamicdistancesql = 'INSERT INTO '+@BranchCSVFileName+' (DistanceMiles, Postcode, Lat, Lon)

SELECT * FROM (SELECT CAST(dbo.Distance('+@lat+', '+@lon+', Lat, Lon) as decimal (10,1)) As DistanceMiles, [Postcode], [Lat], [Lon]

FROM [Postcodes]

WHERE (Lat <> 0) AND (Lon <> 0)) As T WHERE DistanceMiles<='+@MaxDistance+' ORDER BY DistanceMiles'

Exec (@dynamicdistancesql)

Open in new window

0
 

Author Comment

by:james1977
ID: 21778947
Sorry aneeshattingal i had already sorted the problem before you posted, just got delayed replying due to some other work.

Thanks for your input guys.

James.
0

Featured Post

PRTG Network Monitor: Intuitive Network Monitoring

Network Monitoring is essential to ensure that computer systems and network devices are running. Use PRTG to monitor LANs, servers, websites, applications and devices, bandwidth, virtual environments, remote systems, IoT, and many more. PRTG is easy to set up & use.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

So every once in a while at work I am asked to export data from one table and insert it into another on a different server.  I hate doing this.  There's so many different tables and data types.  Some column data needs quoted and some doesn't.  What …
INTRODUCTION: While tying your database objects into builds and your enterprise source control system takes a third-party product (like Visual Studio Database Edition or Red-Gate's SQL Source Control), you can achieve some protection using a sing…
You have products, that come in variants and want to set different prices for them? Watch this micro tutorial that describes how to configure prices for Magento super attributes. Assigning simple products to configurable: We assigned simple products…
The Email Laundry PDF encryption service allows companies to send confidential encrypted  emails to anybody. The PDF document can also contain attachments that are embedded in the encrypted PDF. The password is randomly generated by The Email Laundr…

932 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

19 Experts available now in Live!

Get 1:1 Help Now