Solved

Help speeding up a loop

Posted on 2008-06-14
3
181 Views
Last Modified: 2010-04-23
Hi All

The following loop that loops through and generates all possible postcodes in the UK.

How can I change the attached code so that the outer part of each loop is not repeated?

Ie.

The loop has 4 parts...

The outer loop goes through a list of districts....
             
     The Next part generates (1) 1 Digit
         The inner part will Generate 1 Digit followed by 2 Characters

     The Next part generates (2) 2 Digits
         The inner part will Generate 1 Digit followed by 2 Characters

     The Next part generates (3) 1 Digit & 1 Character
         The inner part will Generate 1 Digit followed by 2 Characters


How would I remove the repeating outer part from each loop?

So that I would only require 1 loop that does something along the lines of

The outer loop goes through a list of districts....
             The Next part generates (1) 1 Digit
             The Next part generates (2) 2 Digits
             The Next part generates (3) 1 Digit & 1 Character
                          The inner will Generate 1 Digit followed by 2 Characters

The main thing is though I still have to be able to have each loop outputing the format like so

Distric    1 Digit     1 Digit & 2 Characters
Distric    2 Digit     1 Digit & 2 Characters
Distric    1 Digit & 1 Character     1 Digit & 2 Characters

Any help would be great

many thanks
Steve
For Each r1 As String In District

            s1 = r1
 

            For Each r2 As String In Digit1

                s2 = s1 & r2 & " "

                For Each r3 As String In Digit1

                    s3 = s2 & r3

                    For Each r4 As String In Alpha2

                             '......do stuff

                    Next

                Next

            Next
 

            'Pass 2

            For Each r2 As String In Digit2

                s2 = s1 & r2 & " "

                For Each r3 As String In Digit1

                    s3 = s2 & r3

                    For Each r4 As String In Alpha2

                             '......do stuff

                    Next

                Next

            Next
 

            'Pass 3

            For Each r2 As String In Digit1

                s2 = s1 & r2

                For Each r3 As String In Alpha1

                    s3 = s1 & s2 & r3 & " "

                    For Each r4 As String In Digit1

                        s4 = s3 & r4

                        For Each r5 As String In Alpha2

                             '......do stuff

                        Next

                    Next

                Next

            Next

        Next

Open in new window

0
Comment
Question by:Stephen Manderson
  • 2
3 Comments
 
LVL 142

Accepted Solution

by:
Guy Hengel [angelIII / a3] earned 500 total points
ID: 21784672
in short, 2 methods:

do the inner loops once, and save the "results" in a collection/array/whatever is fit to hold the information.
then, run the "outer" loop and use that collection/array/whatever to work on it...

OR

do the inner loops, and put the "outer" loop as most-inner loop, so for each item generated, run the "outer loop" ...
0
 
LVL 19

Author Comment

by:Stephen Manderson
ID: 21785228
Thanks, was thinking along them lines.

Generated a list for the district, middle and end :-) got my 300 + mil combinations now.. opened another question about resuming the loop if stopped if you can help?
0
 
LVL 19

Author Comment

by:Stephen Manderson
ID: 21785282
0

Featured Post

DevOps Toolchain Recommendations

Read this Gartner Research Note and discover how your IT organization can automate and optimize DevOps processes using a toolchain architecture.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

It’s quite interesting for me as I worked with Excel using vb.net for some time. Here are some topics which I know want to share with others whom this might help. First of all if you are working with Excel then you need to Download the Following …
Wouldn’t it be nice if you could test whether an element is contained in an array by using a Contains method just like the one available on List objects? Wouldn’t it be good if you could write code like this? (CODE) In .NET 3.5, this is possible…
Internet Business Fax to Email Made Easy - With eFax Corporate (http://www.enterprise.efax.com), you'll receive a dedicated online fax number, which is used the same way as a typical analog fax number. You'll receive secure faxes in your email, fr…
Learn how to create flexible layouts using relative units in CSS.  New relative units added in CSS3 include vw(viewports width), vh(viewports height), vmin(minimum of viewports height and width), and vmax (maximum of viewports height and width).

911 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

22 Experts available now in Live!

Get 1:1 Help Now