Error in inserting record

I have code as listed below. This code is working perfectly if i use MS Access (oleDbConnection) but it giving me error when i convert to use sql server 2005 express edition.
protected void btnAdd_Click(object sender, EventArgs e)
    {
 
        SqlConnection conNwind;
        SqlCommand cmdSelect, cmdSelectID;
        SqlDataReader dtrCustomer;
 
 
        string connStr = ConfigurationManager.ConnectionStrings["ConnectionNWind"].ConnectionString;
        conNwind = new SqlConnection(connStr);
 
 
        conNwind.Open();
 
        string select = "Select * from Customers where CustomerID=@ID";
        cmdSelectID = new SqlCommand(select, conNwind);
 
        cmdSelectID.Parameters.AddWithValue("@ID", txtId.Text);
        dtrCustomer = cmdSelectID.ExecuteReader();
 
 
        if (dtrCustomer.Read())
        {
            Label1.Text = "ID already exist!";
 
        }
 
        else
        {
            string strInsert = "Insert into Customers(CustomerID,Companyname,Contactname,Phone) values(@customerId,@companyname,@contactname,@phone)";
 
            cmdSelect = new SqlCommand(strInsert, conNwind);
 
            cmdSelect.Parameters.AddWithValue("@customerId", txtId.Text);
            cmdSelect.Parameters.AddWithValue("@companyname", txtCompanyName.Text);
            cmdSelect.Parameters.AddWithValue("@contactname", txtContactName.Text);
            cmdSelect.Parameters.AddWithValue("@phone", txtPhone.Text);
 
            int intAdd = cmdSelect.ExecuteNonQuery();
 
            if (intAdd != 0)
                Label1.Text = "Record successfully added into database!";
 
            else
                Label1.Text = "Record not added into database!";
        }
 
        dtrCustomer.Close();
        conNwind.Close();
 
    }

Open in new window

nisha_Asked:
Who is Participating?

Improve company productivity with a Business Account.Sign Up

x
 
DhaestConnect With a Mentor Commented:
Where do you get that error ? Can you try this.
protected void btnAdd_Click(object sender, EventArgs e)
    {
 
        SqlConnection conNwind;
        SqlCommand cmdSelect, cmdSelectID;
        SqlDataReader dtrCustomer;
 
 
        string connStr = ConfigurationManager.ConnectionStrings["ConnectionNWind"].ConnectionString;
        conNwind = new SqlConnection(connStr);
 
 
        conNwind.Open();
 
        string select = "Select * from Customers where CustomerID=@ID";
        cmdSelectID = new SqlCommand(select, conNwind);
 
        cmdSelectID.Parameters.AddWithValue("@ID", txtId.Text);
        dtrCustomer = cmdSelectID.ExecuteReader();
 
 
        if (dtrCustomer.Read())
        {
            Label1.Text = "ID already exist!";
            dtrCustomer.Close();
        }
 
        else
        {
            dtrCustomer.Close();
            string strInsert = "Insert into Customers(CustomerID,Companyname,Contactname,Phone) values(@customerId,@companyname,@contactname,@phone)";
 
            cmdSelect = new SqlCommand(strInsert, conNwind);
 
            cmdSelect.Parameters.AddWithValue("@customerId", txtId.Text);
            cmdSelect.Parameters.AddWithValue("@companyname", txtCompanyName.Text);
            cmdSelect.Parameters.AddWithValue("@contactname", txtContactName.Text);
            cmdSelect.Parameters.AddWithValue("@phone", txtPhone.Text);
 
            int intAdd = cmdSelect.ExecuteNonQuery();
 
            if (intAdd != 0)
                Label1.Text = "Record successfully added into database!";
 
            else
                Label1.Text = "Record not added into database!";
        }
         
        conNwind.Close();
 
    }

Open in new window

0
 
DhaestCommented:
Where do you get an error and what error do you get when you change it to sql server 2005 express edition?
0
 
nisha_Author Commented:
Error message : There is already an open DataReader associated with this Command which must be closed first.
0
Upgrade your Question Security!

Your question, your audience. Choose who sees your identity—and your question—with question security.

 
AUmidhCommented:
make a try of the following
add this statement dtrCustomer.Close();
before the following.
string strInsert = "Insert into Customers(CustomerID,Companyname,Contactname,Phone) values(@customerId,@companyname,@contactname,@phone)";

I am not sure about this but may be.


0
 
elimesikaCommented:
Try
     SqlConnection conNwind;
        SqlCommand cmdSelect, cmdSelectID;
        SqlDataReader dtrCustomer;
 
 
        string connStr = ConfigurationManager.ConnectionStrings["ConnectionNWind"].ConnectionString;
        conNwind = new SqlConnection(connStr);
 
 
        conNwind.Open();
 
        string select = "Select * from Customers where CustomerID=@ID";
        cmdSelectID = new SqlCommand(select, conNwind);
 
        cmdSelectID.Parameters.AddWithValue("@ID", txtId.Text);
        dtrCustomer = cmdSelectID.ExecuteReader();
 
 
        if (dtrCustomer.Read())
        {
            Label1.Text = "ID already exist!";
            dtrCustomer.Close();
            conNwind.Close();
 	    return;
        }
 
        else
        {
            dtrCustomer.Close();
            string strInsert = "Insert into Customers(CustomerID,Companyname,Contactname,Phone) values(@customerId,@companyname,@contactname,@phone)";
 
            cmdSelect = new SqlCommand(strInsert, conNwind);
 
            cmdSelect.Parameters.AddWithValue("@customerId", txtId.Text);
            cmdSelect.Parameters.AddWithValue("@companyname", txtCompanyName.Text);
            cmdSelect.Parameters.AddWithValue("@contactname", txtContactName.Text);
            cmdSelect.Parameters.AddWithValue("@phone", txtPhone.Text);
 
            int intAdd = cmdSelect.ExecuteNonQuery();
 
            if (intAdd != 0)
                Label1.Text = "Record successfully added into database!";
 
            else
                Label1.Text = "Record not added into database!";
                
            conNwind.Close();
        }
 

Open in new window

0
 
nisha_Author Commented:
putting dtrCustomer.Read() before insert statement make the program work. But why i should do like that since my insert statement not using data reader.
0
 
DhaestCommented:
A datareader opens a transaction. As long as it's not commited (or closed), the connection will be exclusive used by your datareader.
0
 
nisha_Author Commented:
Then how it can work in MS Access even i closed the datareader after insert statement?
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.