Solved

Appending file contents to a new file

Posted on 2008-06-16
5
2,384 Views
Last Modified: 2012-05-05
I'm just starting out with Python but I'm stuck already and can't proceed unless I understand how this works.  I'm trying to append the contents of two files to a new file.  Each of the two source files has only a few simple lines of text (words separated by spaces) with Unix line returns, but no commas or other delimiters (I will try to work with more complex files later).  

I understand that these strings are read in as lists but cannot find a way to print lists that are read from a file. I tried using "for line in src1:" followed by a print statement but got a syntax error.  My most recent attempt at a script is attached below.  The errors are:  

File "./test.py", line 11, in ?
    print src1.read(output1)
TypeError: an integer is required

File "./test.py", line 12, in ?
    src1.write(output1)
TypeError: argument 1 must be string or read-only character buffer, not list

I don't think I should need to define a method unless I'm trying to strip quotation marks, line returns or white spaces.  Let me know what I'm missing, thanks

#! /usr/bin/python
 

import string, sys, fileinput
 

src1=open('my_src1.txt', 'r')

output1 = src1.readlines()

src2=open('my_src2.txt', 'r')

output2 = src2.readlines()

dest = open( 'my_dest.txt', 'a' )

print src1.read(output1)  

src1.write(output1)

src1.close()

print src2.read(output2)

src2.write(output2)

src2.close()

dest.close()

Open in new window

0
Comment
Question by:sara_bellum
5 Comments
 
LVL 24

Expert Comment

by:fridom
ID: 21791723
print src1.read(output1)  
How should that work?

and well if you have a list you have to walk the list and print the contents line by line or you may look is there's something like write_lines or the like to output a complete list.

Regards
Friedrich
0
 
LVL 14

Accepted Solution

by:
RichieHindle earned 500 total points
ID: 21791845
Here you go.

Note that the code really does *append* to my_dest.txt, so if you run it twice you get my_src1.txt+my_src2.txt+my_src1.txt+my_src2.txt in my_dest.txt.

If you want each run to empty my_dest.txt before writing to it, change open('my_dest.txt', 'a') to open('my_dest.txt', 'w').

#! /usr/bin/python

 

import string, sys, fileinput

 

src1=open('my_src1.txt', 'r')

output1 = src1.read()

src1.close()
 

src2=open('my_src2.txt', 'r')

output2 = src2.read()

src2.close()
 

dest = open('my_dest.txt', 'a')

dest.write(output1)  

dest.write(output2)

dest.close()

Open in new window

0
 
LVL 17

Expert Comment

by:ramrom
ID: 21794000
print src1.read(output1) is a pretty confused expression

You already read the file contents into output1. All you need is print output1.

src1.read() would return an empty string, since src1 is at end of file.

If you pass a parameter to read() it must be an integer, since that parameter is the # of bytes to read.

Also aim (in future questions) to omit inessential information (in this case the discussion of what is in the files).

I also suggest you read the tutorials in the topic area (in this case files) you are working in. The explanations and examples should help you get it right the first time.

Of course we are glad to help.
0
 

Author Closing Comment

by:sara_bellum
ID: 31467497
Thanks!  I had read a number of tutorials, but the more I read, the more confused I got, so I could no longer see what information you really needed - it was good to just see an answer that works
0
 

Author Comment

by:sara_bellum
ID: 21798627
I ended up using a slightly modified form of the answer which I post here for reference / in case it helps anyone.  This does add annoying ^M line returns, but I can remove those with sed.
#! /usr/bin/python

 

import string, sys, fileinput
 

src1 = open('header.dat', 'r')

output1 = src1.read()

src1.close()
 

src2 = open('sample.dat', 'r')

output2 = src2.readlines()

src2.close()

del output2[0:3+1]
 

dest = open('sample_form.dat', 'w')

dest.write(output1)  

dest.writelines(output2)

dest.close()

Open in new window

0

Featured Post

How to improve team productivity

Quip adds documents, spreadsheets, and tasklists to your Slack experience
- Elevate ideas to Quip docs
- Share Quip docs in Slack
- Get notified of changes to your docs
- Available on iOS/Android/Desktop/Web
- Online/Offline

Join & Write a Comment

Have you ever been frustrated by having to click seven times in order to retrieve a small bit of information from the web, always the same seven clicks, scrolling down and down until you reach your target? When you know the benefits of the command l…
Join Greg Farro and Ethan Banks from Packet Pushers (http://packetpushers.net/podcast/podcasts/pq-show-93-smart-network-monitoring-paessler-sponsored/) and Greg Ross from Paessler (https://www.paessler.com/prtg) for a discussion about smart network …
Learn the basics of strings in Python: declaration, operations, indices, and slicing. Strings are declared with quotations; for example: s = "string": Strings are immutable.: Strings may be concatenated or multiplied using the addition and multiplic…
Learn the basics of modules and packages in Python. Every Python file is a module, ending in the suffix: .py: Modules are a collection of functions and variables.: Packages are a collection of modules.: Module functions and variables are accessed us…

746 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

12 Experts available now in Live!

Get 1:1 Help Now