Solved

Please check this simple function...

Posted on 2008-06-16
14
154 Views
Last Modified: 2010-04-01
As per subject...

Thanks,
Uni
/*********************************************************************************

This returns a corrected iterator, ensuring that if we want to increase

aInitialIterator by aIncreaseBy, we don't go out of the highest bounds of

aHaystack.

*********************************************************************************/

vector<BIT>::iterator getCorrectedHighIterator(vector<BIT> &aHaystack, const vector<BIT>::iterator &aInitialIterator, const unsigned int aIncreaseBy){

	if(aHaystack.end()-aInitialIterator<aIncreaseBy)

		return aHaystack.end();

	return(aInitialIterator+aIncreaseBy);

}

/********************************************************************************/

Open in new window

0
Comment
Question by:Unimatrix_001
  • 6
  • 5
  • 3
14 Comments
 
LVL 53

Accepted Solution

by:
Infinity08 earned 60 total points
ID: 21793457
Looks good to me.

Do you experience problems with it ?
0
 
LVL 40

Assisted Solution

by:evilrix
evilrix earned 40 total points
ID: 21793472
Being picky now: This will probably fail in a nasty way if the iterator is not for the same vector as that passed in :)
0
 
LVL 3

Author Comment

by:Unimatrix_001
ID: 21793501
>>Do you experience problems with it ?
None yet, although I thought I'd tested my other question code fully but found that to cause problems! :D

>>Being picky now: This will probably fail in a nasty way if the iterator is not for the same vector as that passed in :)
Hehe, that's not a problem - but thanks anyways.

Is a 50 50 split with you two okay - I got the two e-mails at exactly the same time...?
0
 
LVL 53

Expert Comment

by:Infinity08
ID: 21793525
>> Is a 50 50 split with you two okay

Fine by me :)


I have been meaning to make the comment evilrix made a few times before, but I assumed you'd be aware of that ;)
0
 
LVL 40

Expert Comment

by:evilrix
ID: 21793524
Also, why not template it, then it'd be generic for all container types, no? Also, I'd change it so it only works with iterators and doesn't worry about the container... it doesn't need to doe it? end() can be passed in as another iterator. This is normally how STL algos work (just with iterators).
0
 
LVL 40

Expert Comment

by:evilrix
ID: 21793535
>> Is a 50 50 split with you two okay - I got the two e-mails at exactly the same time...?
Whatever you think best Uri  -- that works for me... although I don't feel like either of us really earned anything here :)
0
 
LVL 3

Author Comment

by:Unimatrix_001
ID: 21793551
I've increse points to 100, doing a 60/40 split to Infinity (taking him at his word of trying a few times before the comment came though ;)

Ah the template is too much hassle for this - it is only a very small program, but I guess in the long run if I was going to make heavy use of it I would agree.

>>although I don't feel like either of us really earned anything here :)
You've put my mind at ease, that's enough for me! :)
0
Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

 
LVL 40

Expert Comment

by:evilrix
ID: 21793590
>> Ah the template is too much hassle for this
Eh?
template <typename T>

typename T::iterator getCorrectedHighIterator(

	T &aHaystack,

	const typename T::iterator &aInitialIterator,

	const unsigned int aIncreaseBy

	)

{

	if(aHaystack.end()-aInitialIterator<aIncreaseBy)

		return aHaystack.end();

	return(aInitialIterator+aIncreaseBy);

}

Open in new window

0
 
LVL 3

Author Comment

by:Unimatrix_001
ID: 21793600
>>Eh?
Meh, I'm not very good at templates... besides you're a sage! You can just think something near a computer and it happens! :D
0
 
LVL 40

Expert Comment

by:evilrix
ID: 21793613
>> Meh, I'm not very good at templates...
Sure you are -- you just don't know it yet :)

>> besides you're a sage!
I prefer sage and onion myself :)

>> You can just think something near a computer and it happens! :D
I tried this, I thought of lovely dancing girls -- nothing :(
0
 
LVL 3

Author Comment

by:Unimatrix_001
ID: 21793663
>>Sure you are -- you just don't know it yet :)
Maybe one day... :)

>>I tried this, I thought of lovely dancing girls -- nothing :(
Hehehe, maybe they don't like sage and onion, try seperately... :D

Cheers mate. :)
Uni
0
 
LVL 40

Expert Comment

by:evilrix
ID: 21793681
Cheer Uri, a pleasure as always :)
0
 
LVL 53

Expert Comment

by:Infinity08
ID: 21793744
>> (taking him at his word of trying a few times before the comment came though ;)

Ah no, that was not what I intended ... I meant that I thought about making the same comment evilrix did a few times before (in your previous questions), but I never did. I'm glad evilrix did :)
0
 
LVL 3

Author Comment

by:Unimatrix_001
ID: 21793764
Ah okay - sorry, my bad... :)
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Written by John Humphreys C++ Threading and the POSIX Library This article will cover the basic information that you need to know in order to make use of the POSIX threading library available for C and C++ on UNIX and most Linux systems.   [s…
  Included as part of the C++ Standard Template Library (STL) is a collection of generic containers. Each of these containers serves a different purpose and has different pros and cons. It is often difficult to decide which container to use and …
The viewer will learn additional member functions of the vector class. Specifically, the capacity and swap member functions will be introduced.
The viewer will be introduced to the member functions push_back and pop_back of the vector class. The video will teach the difference between the two as well as how to use each one along with its functionality.

863 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

24 Experts available now in Live!

Get 1:1 Help Now