Want to win a PS4? Go Premium and enter to win our High-Tech Treats giveaway. Enter to Win

x
?
Solved

How to backout records from insert with delete

Posted on 2008-06-17
9
Medium Priority
?
211 Views
Last Modified: 2010-03-20
I ran the following insert query:
Insert into FileOne
   (CNumber,
     ID,
    DCode)
Select
    a.Cnumber
   a.ID
   a.DCode
FROM PFILE a
    INNER JOIN TFile b
   on a.ID = b.ID

The problem is that the field DCode in PFILE a contained nulls which violated the constraint in FileOne that says nulls are not allowed on DCode.  The query ran until it hit the nulls, then errored out.  I've changed the query to add "WHERE DCode is not Null"  but now there are records in FileOne that have been inserted and I can't rerun the query because there are duplicates in FileOne.  I think I can safely back out the records I added with the following:

DELETE * From FileOne a
     INNER JOIN Pfile b
    ON a.ID = b.ID

Does this sound right?  Will this delete work to remove only the records inserted in the first query?


0
Comment
Question by:dkcoop03
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 4
  • 4
9 Comments
 
LVL 2

Expert Comment

by:howyue
ID: 21809801
u don need to backout ur record that u have previously inserted.
in ur select statement u just select records that are not in table FileOne

Insert into FileOne (CNumber,ID,DCode)
Select a.Cnumber, a.ID, a.DCode
FROM PFILE a
INNER JOIN TFile b on a.ID = b.ID
WHERE c.Cnumber NOT IN (Select CNumber From FileOne) --specify ur primary key here

Open in new window

0
 
LVL 1

Expert Comment

by:sqlconsumer
ID: 21810994
Are you sure that the Records were commited to FileOne? If your query failed the transaction should get roled back.

To check...

SELECT * FROM FileOne f1
WHERE f1.ID IN
(SELECT fp.ID FROM PFILE pf INNER JOIN TFILE tf ON pf.ID = tf.ID)

This will return any records that have been added by your query.

You can then use the sub query for your delete statement. Always create a select query first, then delete.

Hope this helps
0
 

Author Comment

by:dkcoop03
ID: 21812335
If the table was rolled back wouldn't I be allowed to rerun the query?  I'm running the query to check if records were added now but it will probably take awhile.
0
Microsoft Certification Exam 74-409

VeeamĀ® is happy to provide the Microsoft community with a study guide prepared by MVP and MCT, Orin Thomas. This guide will take you through each of the exam objectives, helping you to prepare for and pass the examination.

 
LVL 1

Expert Comment

by:sqlconsumer
ID: 21812473
Yep you should be able to rerun the corrected query.

How long does the select query take to run? do you have any indexes on the table?
0
 

Author Comment

by:dkcoop03
ID: 21812603
There are about 130million records but the query finished and yes the records are in the table.  So now if I use the subquery ((SELECT fp.ID FROM PFILE pf INNER JOIN TFILE tf ON pf.ID = tf.ID) I should be able to remove the records correct?  Yes there are indexes on the table.
0
 

Author Comment

by:dkcoop03
ID: 21812767
I think this code will do it if I put it at the end of the insert query
WHERE c.IDr NOT IN (Select ID From FileOne) --specify ur primary key here

But I'm confused about which primary key I'm testing.  Here it says c.Cnumber but there is no alias c.  Should it be a.Cnumber -- am I testing against the key from PFILE and does it matter that I've joined PFile to Tfile for the original insert
 
0
 
LVL 1

Expert Comment

by:sqlconsumer
ID: 21812778
Yep use the sub query in your WHERE clause and you will only delete these records.

I recommend reading up on BEGIN TRANSACTION, COMMIT TRANSACTION and ROLLBACK TRANSACTION. They might save you a lot of bother in the future.
0
 

Author Comment

by:dkcoop03
ID: 21812984
I will definitely read up on these topics.  I would like to confirm what I should be doing:

FROM PFILE a
    INNER JOIN TFile b
   on a.ID = b.ID
  WHERE FileOne.ID not in
(SELECT fp.ID FROM PFILE pf INNER JOIN TFILE tf ON pf.ID = tf.ID)

Does this look correct?
0
 
LVL 1

Accepted Solution

by:
sqlconsumer earned 2000 total points
ID: 21813569
Not quite,

Try something more like

DELETE FROM FileOne
WHERE FileOne.ID IN
(SELECT fp.ID FROM PFILE pf INNER JOIN TFILE tf ON pf.ID = tf.ID)

The number of rows deleted should be exactly the same as the number of rows return by the query

SELECT * FROM FileOne f1
WHERE f1.ID IN
(SELECT fp.ID FROM PFILE pf INNER JOIN TFILE tf ON pf.ID = tf.ID)
0

Featured Post

VIDEO: THE CONCERTO CLOUD FOR HEALTHCARE

Modern healthcare requires a modern cloud. View this brief video to understand how the Concerto Cloud for Healthcare can help your organization.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Ready to get certified? Check out some courses that help you prepare for third-party exams.
One of the most important things in an application is the query performance. This article intends to give you good tips to improve the performance of your queries.
Via a live example combined with referencing Books Online, show some of the information that can be extracted from the Catalog Views in SQL Server.
Via a live example, show how to shrink a transaction log file down to a reasonable size.

604 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question