Solved

More CPtrArray sorting problems!

Posted on 2008-06-18
5
808 Views
Last Modified: 2013-11-20
Ah hello.

A follow up to a previous question about sorting CPtrArrays.  Consider this code:


class CMyClass
{
public:
      CMyClass ( DWORD d ) : m_dw ( d ) {}
      ~CMyClass() {}
      DWORD m_dw;
      CString s;
};

typedef int (__cdecl *GENERICCOMPAREFN)(const void * elem1, const void * elem2);
typedef int (__cdecl *STRINGCOMPAREFN)(const CMyClass * elem1, const CMyClass * elem2);

class CMyArray : public CPtrArray
{
public:
      void Sort(GENERICCOMPAREFN pfnCompare = Compare)
      {
            qsort ( GetData(), GetSize(), sizeof ( CMyClass ), ( GENERICCOMPAREFN ) pfnCompare );
      }
protected:

      static int __cdecl Compare(const void * pMyClass1, const void * pMyClass2 )
      {
            if ( !pMyClass1 || !pMyClass2 ) return 0;
            CMyClass* pActualMyClass1 = *(CMyClass**)pMyClass1;
            CMyClass* pActualMyClass2 = *(CMyClass**)pMyClass2;

            return pActualMyClass1 ->m_dw < pActualMyClass2 ->m_dw;
      }
};

int main()
{
      CMyArray m_array;

      m_array.Add ( ( void*) new CMyClass ( 1 ) );
      m_array.Add ( ( void*) new CMyClass ( 3 ) );
      m_array.Add ( ( void*) new CMyClass ( 2 ) );

            m_array.Sort();

            return 0;
}

I am finding that whenever I have a CString member in the class object contained in my array, the code generates an access violation in the Compare() functoin.  More specifically, the first time the function is called by qsort(), I get my two pointers pActualMyClass1 and pActualMyClass2 both valid.  The second time however, pMyClass1 is always 0xcdcdcdcd.  So the attempt to access m_dw fails.

If I remove the CString member, this does not happen.

Can someone please tell me What is going on here, and how to get around it?  I need my CString member.

TIA
0
Comment
Question by:mrwad99
  • 2
  • 2
5 Comments
 
LVL 31

Accepted Solution

by:
Zoppo earned 125 total points
ID: 21813646
Hi mrwad99,

I guess this line is wrong:

>             qsort ( GetData(), GetSize(), sizeof ( CMyClass ), ( GENERICCOMPAREFN ) pfnCompare );

instead of 'sizeof ( CMyClass )' you should pass 'sizeof ( CMyClass* )' since you compare pointers to CMyClass, not instances of CMyClass.

Hope that helps,

ZOPPO
0
 
LVL 19

Author Comment

by:mrwad99
ID: 21813883
Thank you ZOPPO :o)
0
 
LVL 31

Expert Comment

by:Zoppo
ID: 21813907
You're welcome ...
0
 
LVL 19

Expert Comment

by:alb66
ID: 21813914
Zoppo is right. The previous case(without CString) worked only because
sizeof(DWORD) == sizeof(void*)
0
 
LVL 19

Author Comment

by:mrwad99
ID: 21813932
Ah, I see!  Thanks for the follow up alb66.
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Introduction: Ownerdraw of the grid button.  A singleton class implentation and usage. Continuing from the fifth article about sudoku.   Open the project in visual studio. Go to the class view – CGridButton should be visible as a class.  R…
Many modern programming languages support the concept of a property -- a class member that combines characteristics of both a data member and a method.  These are sometimes called "smart fields" because you can add logic that is applied automaticall…
The viewer will be introduced to the member functions push_back and pop_back of the vector class. The video will teach the difference between the two as well as how to use each one along with its functionality.
This video will show you how to get GIT to work in Eclipse.   It will walk you through how to install the EGit plugin in eclipse and how to checkout an existing repository.

867 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

22 Experts available now in Live!

Get 1:1 Help Now