Want to win a PS4? Go Premium and enter to win our High-Tech Treats giveaway. Enter to Win

x
?
Solved

Missing Comma Error while inserting record dynamically

Posted on 2008-06-18
7
Medium Priority
?
1,850 Views
Last Modified: 2008-06-18
Hi Experts,
I am trying to create a table dynamically and then insert data into it.
the CREATE command runs successfully while the INSERT errors out. It says that there are a few missing commas. Can someone help?
EXECUTE IMMEDIATE 'CREATE TABLE ' || TBL_TABLE_NAME ||
                     '(INDICATOR_ID NUMBER(20),MASTER_INDICATOR_ID NUMBER(20),USER_ROLE_ID NUMBER(20), TREE_ORDER NUMBER(20), ORGANIZATION_UNIT VARCHAR2(100), USER_FIRST_NAME VARCHAR2(30), USER_LAST_NAME VARCHAR2(30), HIERARCHY_LEVEL VARCHAR2(100), MAX_DEVIATION NUMBER(20,4), DEVIATION_TYPE VARCHAR2(1),UNIT_OF_EXPRESSION VARCHAR2(30), PLAN_VALUE NUMBER(20, 2),ACTUAL_VALUE NUMBER(20, 2), ACTION_PLAN VARCHAR2(1))';
 
   TREE_ORDER := 0;
   FOR I IN 1 .. RESULT_INDICATOR_RECORDSET.COUNT LOOP
   
      EXECUTE IMMEDIATE 'INSERT INTO ' || TBL_TABLE_NAME ||' VALUES('||RESULT_INDICATOR_RECORDSET(I)|| 
                        ' ,' ||RESULT_PARENT_RECORDSET(I)|| 
                        ' ,' ||RESULT_USER_RECORDSET(I)||
                        ' ,' ||TREE_ORDER||
                        ' ,' ||ORG_UNIT_RECORDSET(I)||
                        ' ,' ||USER_FIRST_NAME_RECORDSET(I)||
                        ' ,' ||USER_LAST_NAME_RECORDSET(I)||
                        ' ,' ||USER_ZONE_RECORDSET(I)||
                        ' ,' ||MAX_DEVIATION_RECORDSET(I)||
                        ' ,' ||DEVIATION_TYPE_RECORDSET(I)||
                        ' ,' ||UOM_TYPE_RECORDSET(I)||
                        ' ,' ||PLAN_VALUE_RECORDSET(I)||
                        ' ,' ||ACTUAL_VALUE_RECORDSET(I)||
                        ' ,' ||ACTION_PLAN_RECORDSET(I)||')';

Open in new window

0
Comment
Question by:110210
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
7 Comments
 
LVL 6

Expert Comment

by:Ritesh_Garg
ID: 21817641
Try this:
EXECUTE IMMEDIATE 'CREATE TABLE ' || TBL_TABLE_NAME ||
                     '(INDICATOR_ID NUMBER(20),MASTER_INDICATOR_ID NUMBER(20),USER_ROLE_ID NUMBER(20), TREE_ORDER NUMBER(20), ORGANIZATION_UNIT VARCHAR2(100), USER_FIRST_NAME VARCHAR2(30), USER_LAST_NAME VARCHAR2(30), HIERARCHY_LEVEL VARCHAR2(100), MAX_DEVIATION NUMBER(20,4), DEVIATION_TYPE VARCHAR2(1),UNIT_OF_EXPRESSION VARCHAR2(30), PLAN_VALUE NUMBER(20, 2),ACTUAL_VALUE NUMBER(20, 2), ACTION_PLAN VARCHAR2(1))';
 
   TREE_ORDER := 0;
   FOR I IN 1 .. RESULT_INDICATOR_RECORDSET.COUNT LOOP
   
      EXECUTE IMMEDIATE 'INSERT INTO ' || TBL_TABLE_NAME ||' VALUES('||NVL(RESULT_INDICATOR_RECORDSET(I),'NULL')|| 
                        ' ,' ||NVL(RESULT_PARENT_RECORDSET(I),'NULL')|| 
                        ' ,' ||NVL(RESULT_USER_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(TREE_ORDER,'NULL')||
                        ' ,' ||NVL(ORG_UNIT_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(USER_FIRST_NAME_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(USER_LAST_NAME_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(USER_ZONE_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(MAX_DEVIATION_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(DEVIATION_TYPE_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(UOM_TYPE_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(PLAN_VALUE_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(ACTUAL_VALUE_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(ACTION_PLAN_RECORDSET(I),'NULL')||')';

Open in new window

0
 
LVL 74

Accepted Solution

by:
sdstuber earned 2000 total points
ID: 21817677
what is the actual error?  "a few missing commas"  is not an oracle error message  :)

in the mean time,  try rewriting the inserts like this.  

       EXECUTE IMMEDIATE 'INSERT INTO ' || tbl_table_name
                      || ' VALUES(:b1,:b2,:b3,:b4,:b5,:b6,:b7,:b8,:b9,:b10,:b11,:b12,:b13,:b14)'
            USING result_indicator_recordset(i), result_parent_recordset(i),
                  result_user_recordset(i), tree_order, org_unit_recordset(i),
                  user_first_name_recordset(i), user_last_name_recordset(i),
                  user_zone_recordset(i), max_deviation_recordset(i),
                  deviation_type_recordset(i), uom_type_recordset(i),
                  plan_value_recordset(i), actual_value_recordset(i),
                  action_plan_recordset(i);
0
 
LVL 74

Expert Comment

by:sdstuber
ID: 21817689
the reason I changed it to use the "USING" is even though your statement is dynamic,  you can still take advantage of bind variables.  And, the more times you loop, the more effective USING bind variables will be.

Plus, it makes the statement easier to debug since there is only one dynamic piece left in it now.
0
Free Backup Tool for VMware and Hyper-V

Restore full virtual machine or individual guest files from 19 common file systems directly from the backup file. Schedule VM backups with PowerShell scripts. Set desired time, lean back and let the script to notify you via email upon completion.  

 

Author Comment

by:110210
ID: 21817741
No. It doesn't seem to work. It says trying to insert string for numeric values, when I change all the 'NULL' to either '' or 0..it reverts back to the old error
0
 
LVL 14

Expert Comment

by:ajexpert
ID: 21817757
Hi,
You can easily findout which statement is erroring out.
Here is some addition to your existing code
  lv_sql  VARCHAR2(4000);
  
  lv_sql  :=  'INSERT INTO ' || TBL_TABLE_NAME ||' VALUES('||NVL(RESULT_INDICATOR_RECORDSET(I),'NULL')|| 
                        ' ,' ||NVL(RESULT_PARENT_RECORDSET(I),'NULL')|| 
                        ' ,' ||NVL(RESULT_USER_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(TREE_ORDER,'NULL')||
                        ' ,' ||NVL(ORG_UNIT_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(USER_FIRST_NAME_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(USER_LAST_NAME_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(USER_ZONE_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(MAX_DEVIATION_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(DEVIATION_TYPE_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(UOM_TYPE_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(PLAN_VALUE_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(ACTUAL_VALUE_RECORDSET(I),'NULL')||
                        ' ,' ||NVL(ACTION_PLAN_RECORDSET(I),'NULL')||')';
 
 
 BEGIN
 EXECUTE IMMEDIATE lv_sql;
 EXCEPTION
 WHEN OTHERS THEN
   DBMS_OUTPUT.PUT_LINE lv_sql;
 END;   

Open in new window

0
 

Author Comment

by:110210
ID: 21817787
thanks all for the help.

sdstuber, your solution worked(and still works) well.
The actual error was ORA-00917 missing comma.
0
 
LVL 74

Expert Comment

by:sdstuber
ID: 21819088
glad I could help
0

Featured Post

Veeam Disaster Recovery in Microsoft Azure

Veeam PN for Microsoft Azure is a FREE solution designed to simplify and automate the setup of a DR site in Microsoft Azure using lightweight software-defined networking. It reduces the complexity of VPN deployments and is designed for businesses of ALL sizes.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Working with Network Access Control Lists in Oracle 11g (part 2) Part 1: http://www.e-e.com/A_8429.html Previously, I introduced the basics of network ACL's including how to create, delete and modify entries to allow and deny access.  For many…
I remember the day when someone asked me to create a user for an application developement. The user should be able to create views and materialized views and, so, I used the following syntax: (CODE) This way, I guessed, I would ensure that use…
This video shows, step by step, how to configure Oracle Heterogeneous Services via the Generic Gateway Agent in order to make a connection from an Oracle session and access a remote SQL Server database table.
This videos aims to give the viewer a basic demonstration of how a user can query current session information by using the SYS_CONTEXT function

610 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question