Improve company productivity with a Business Account.Sign Up

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 869
  • Last Modified:

Proper way to create a instance of Zend_DB_Select in Zend Framework

I need some advice on the "proper" way to create a zend_db_select class.  I use to have the following old code that used Db_Table_Abstract to do a fetch.    I'm trying to use Db_Select so that I can create custom queries at the same time keeping things object oriented.  Right now I'm getting the following error


Parse error: syntax error, unexpected T_VARIABLE, expecting T_FUNCTION in /home/sean/Zend/workspaces/psi-inv-zf/library/Fetchshortview.php on line 4

As you can tell I'm a noob with ZF, any input would be appreciated.
// OLD CODE *************************************************************************************
 
require_once 'Zend/Db/Table/Abstract.php';
 
class Items extends Zend_Db_Table_Abstract {
	/**
	 * The default table name 
	 */
	protected $_name = 't_items';
 
} 
 
public function showallAction()
    {
    	$this->view->title = "Showing All Inventory";
	     	$items = new Items();
		$this->view->items = $items->fetchAll();	
    }
 
 
// NEW CODE ***********************************************************************
 
class Fetchshortview {
	$query = $db->select();
	$query ->from('v_itemshort', array('id','nickname','serial'));
 
}
 
 public function showallAction()
    {
    	$this->view->title = "Showing All Inventory";
	    $items = new Fetchshortview();
		$this->view->items = $items->fetchAll($query);
		
    }

Open in new window

0
sean-keys
Asked:
sean-keys
  • 5
  • 3
1 Solution
 
RoonaanCommented:
your showAllAction function is not inside your class. You might need to just move the curly brace.
0
 
sean-keysAuthor Commented:
I should have been more specific class Fetchshortview exists in Fetchshortview.php  and

public function showallAction()  exists in IndexController.php  

0
 
RoonaanCommented:
There cannot be any code directly inside a class without a function. I am actually ashamed I didn't see that at first glance..

class Fetchshortview {
        $query = $db->select();
        $query ->from('v_itemshort', array('id','nickname','serial'));
}

You could have

class Fetchshortview extends Items {
  function fetchAll() {
    $query = $this->getDefaultAdapter()->select();
    $query ->from('v_itemshort', array('id','nickname','serial'));
    return parent::fetchAll($query);
  }
}

But then you could just easier define a fetchShortList inside your Items class and not use the extra class:

function fetchShortList() {
    $query = $this->getDefaultAdapter()->select();
    $query ->from('v_itemshort', array('id','nickname','serial'));
    return $this->fetchAll($query);
}
0
Free Tool: Site Down Detector

Helpful to verify reports of your own downtime, or to double check a downed website you are trying to access.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

 
sean-keysAuthor Commented:
I took your advice and included my function inside the Items class.

I changed "return $this->fetchAll($query);"   to " $this->fetchAll($query); "    because I have a view script running after it .    Now I get this error, I have a feeling its something simple that I'm over looking.



Fatal error: Uncaught exception 'Zend_Db_Statement_Exception' with message 'SQLSTATE[42601]: Syntax error: 7 ERROR: syntax error at end of input LINE 1: SELECT "t_items".* FROM "t_items" WHERE ( ^' in /usr/share/php/Zend/Db/Statement/Pdo.php:238 Stack trace: #0 /usr/share/php/Zend/Db/Statement.php(283): Zend_Db_Statement_Pdo->_execute(Array) #1 /usr/share/php/Zend/Db/Adapter/Abstract.php(405): Zend_Db_Statement->execute(Array) #2 /usr/share/php/Zend/Db/Adapter/Pdo/Abstract.php(205): Zend_Db_Adapter_Abstract->query(Object(Zend_Db_Table_Select), Array) #3 /usr/share/php/Zend/Db/Table/Abstract.php(1184): Zend_Db_Adapter_Pdo_Abstract->query(Object(Zend_Db_Table_Select)) #4 /usr/share/php/Zend/Db/Table/Abstract.php(1039): Zend_Db_Table_Abstract->_fetch(Object(Zend_Db_Table_Select)) #5 /home/sean/Zend/workspaces/psi-inv-zf/application/default/models/Items.php(21): Zend_Db_Table_Abstract->fetchAll(Object(Zend_Db_Select)) #6 /home/sean/Zend/workspaces/psi-inv-zf/application/defaul in /usr/share/php/Zend/Db/Statement/Pdo.php on line 238


//START VIEW SCRIPT **************************************
 
<p><a>Displaying Short View</a></p>
<table>
<tr>
     <th>nickname</th>
     <th>serial</th>
     <th>&nbsp;</th>
</tr>
<?php foreach($this->items as $item) : ?>
<tr>
     <td><?php echo $this->escape($item->nickname);?></td>
     <td><?php echo $this->escape($item->serial);?></td>
     <td>
          <a href="<?php echo $this->url(array('controller'=>'index',
              'action'=>'edit', 'id'=>$item->id));?>">Edit</a>
          <a href="<?php echo $this->url(array('controller'=>'index',
              'action'=>'delete', 'id'=>$item->id));?>">Delete</a>
     </td>
</tr>
<?php endforeach; ?>
</table>
// END VIEW SCRIPT *************************************
 
New code
 
 public function showallAction()
    {
    	$this->view->title = "Showing All PSI Inventory";
	    $items = new Items();
		$this->view->items = $items->fetchShortList();
    }
 
 
 
 
require_once 'Zend/Db/Table/Abstract.php';
 
class Items extends Zend_Db_Table  {
	/**
	 * Returns ShortView Data
	 */
	protected $_name = 't_items';
	
	function fetchShortList() {
    $query = $this->getDefaultAdapter()->select();
	$query ->from('t_items', array('id','nickname','serial'));
    $this->fetchAll($query);
	//return $this->fetchAll($query);
 
	}
}

Open in new window

0
 
sean-keysAuthor Commented:
adding    echo $query->__toString();

Reveals that my query is somehow wrong.

SELECT "t_items".* FROM "t_items"


require_once 'Zend/Db/Table/Abstract.php';
 
class Items extends Zend_Db_Table   {
	/**
	 * Returns ShortView Data
	 */
	protected $_name = 't_items';
	
	function fetchShortList() {
  
    $query = $this->getDefaultAdapter()->select();
    $query ->from('t_items', array('id','nickname','serial'));
    $this->fetchAll($query);
    echo $query->__toString();
 
	}
}

Open in new window

0
 
RoonaanCommented:
Try using:

$query ->from(array('items' => 't_items'), array('id','nickname','serial'));
0
 
sean-keysAuthor Commented:
I ended up with this, but without your guidance I wouldn't have been able to accomplish this.
public function showallAction()
    {
    	$this->view->title = "Showing All Inventory";
	    
    	$items = new Items();
	   	$select = $items->select();
	   	$select->where('id= 6'); //just a test
		$this->view->items = $items->fetchAll($select);
 
}
 
 
require_once 'Zend/Db/Table/Abstract.php';
 
class Items extends Zend_Db_Table_Abstract  {
	/**
	 * Returns ShortView Data
	 */
	protected $_name = 't_items';
	
	
}

Open in new window

0
 
sean-keysAuthor Commented:
Thanks for all of your effort.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Get your problem seen by more experts

Be seen. Boost your question’s priority for more expert views and faster solutions

  • 5
  • 3
Tackle projects and never again get stuck behind a technical roadblock.
Join Now