Solved

'Must declare the scalar variable " Error with asp.net gridview

Posted on 2008-06-20
6
2,487 Views
Last Modified: 2010-04-21
I am trying to add the delete function to a grid view and am getting the 'Must declare the scalar variable "@SaleRef" error. I have looked at other forums and the common problem seems to be not delclaring the parameter and not having DataKeyNames set. I think I have done this (see code).

I've looked at this for so long I can't see where I've gone wrong...

Thanks for your help
<form id="form1" runat="server">

    <div>

<asp:SqlDataSource ID="SqlDataSource1" 

     Runat="server"

     ConnectionString="Server=mysqlserver; Database=mydb; User ID=myuserid; Password=mypass;"

					DeleteCommand="DELETE FROM [SaleRef] WHERE [SaleRef] = @SaleRef"

					SelectCommand="SELECT [SaleRef], [ClosingDate], [ClosingTime] FROM [SaleDetails]"

            providerName="System.Data.SqlClient">

			<DeleteParameters>

                <asp:Parameter Name="SaleRef" Type="Int32" />

            </DeleteParameters>

</asp:SqlDataSource>
 

    </div>

        <asp:GridView ID="GridView1" runat="server" AutoGenerateColumns="False" BackColor="#FFE0C0"

            BorderColor="black" BorderStyle="Solid" BorderWidth="5px" DataKeyNames="SaleRef"

            DataSourceID="SqlDataSource1" EmptyDataText="There are no sales" Font-Names="Verdana"

            Font-Size="Small" GridLines="None">

			<Columns>

                <asp:CommandField ShowDeleteButton="True" ButtonType="Button" DeleteText="Delete Sale" />

				<asp:BoundField DataField="SaleRef" HeaderText="Sale #" />

                <asp:BoundField DataField="closingdate" HeaderText="Closing Date" HtmlEncode="False" />

                <asp:BoundField DataField="closingtime" HeaderText="Closing Time" HtmlEncode="False" />

            </Columns>

            <HeaderStyle BackColor="Green" Font-Size="small" Font-Underline="True" ForeColor="White" />

            <AlternatingRowStyle BackColor="#E0E0E0" />

        </asp:GridView>

    </form>

Open in new window

0
Comment
Question by:kirkheaton25
  • 3
  • 2
6 Comments
 
LVL 43

Expert Comment

by:TimCottee
ID: 21829956
Hello kirkheaton25,

                  <asp:Parameter Name="SaleRef" Type="Int32" />
Should be
                  <asp:Parameter Name="@SaleRef" Type="Int32" />

Regards,

TimCottee
0
 
LVL 1

Author Comment

by:kirkheaton25
ID: 21829999
Thanks, however after making that change I now get the message:
Invalid object name 'SaleRef'. Any ideas?
0
 
LVL 21

Expert Comment

by:naspinski
ID: 21830010
Tim, I think he is ok with his declaration.

I think what you are missing is a way to declare your SaleRef, you never state which one to delete.

Usually this is in a SessionParameter, ControlParameter or QueryStringParameter.  Yours is simply a Parameter so the program does not know which one to delete.  You have to make sure you specify that.
0
Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

 
LVL 1

Author Comment

by:kirkheaton25
ID: 21830459
Hi Naspinski,
Isn't the SaleRef value being sent through the postback when I click the delete button?
(From the grid source code: __doPostBack('GridView1','Delete$2')".)
Is this a ControlParameter, it shouldn't be SessionParameter or QueryStringParameter should it?
0
 
LVL 21

Accepted Solution

by:
naspinski earned 500 total points
ID: 21830508
You are corerct, I didn't realize you were populating them automatically.  I think I see what the problem is.  Your DeleteCOmmand is: "DELETE FROM [SaleRef] WHERE [SaleRef] = @SaleRef"
But it looks like your DB is SaleDetails, so I think the SaleRef we are looking at is the first one, which is not correct at all.  It should be
DELETE FROM [SaleDetails] WHERE [SaleRef] = @SaleRef

Open in new window

0
 
LVL 1

Author Closing Comment

by:kirkheaton25
ID: 31469108
Many Thanks for your help. I was too busy looking at the paramters and got caught out with a schoolboy sql mistake!
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

I recently went through the process of creating a Calendar Control of events with the basis of using a database to keep track of the dates that are selectable, one requirement was to have the selected date pop-up in a simple lightbox.  At first this…
International Data Corporation (IDC) prognosticates that before the current the year gets over disbursing on IT framework products to be sent in cloud environs will be $37.1B.
This is used to tweak the memory usage for your computer, it is used for servers more so than workstations but just be careful editing registry settings as it may cause irreversible results. I hold no responsibility for anything you do to the regist…
Learn how to create flexible layouts using relative units in CSS.  New relative units added in CSS3 include vw(viewports width), vh(viewports height), vmin(minimum of viewports height and width), and vmax (maximum of viewports height and width).

867 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

18 Experts available now in Live!

Get 1:1 Help Now