Still celebrating National IT Professionals Day with 3 months of free Premium Membership. Use Code ITDAY17

x
?
Solved

Help with programming project, writing to a txt file

Posted on 2008-06-20
4
Medium Priority
?
231 Views
Last Modified: 2010-04-21
With some previous help I have almost finished this programming project. I am at the final part of writing txt to a file from an array. I can get it to write once but for some reason it won't write all iterations of the text. It writes the first name and quits. I have a loop but it doesn't seem to make a difference. Can someone tell me where I am screwing up? I am getting pretty frustrated with Java. This is the last assignment for the class and I feel I should be seeing these mistakes myself...

It's the very last part from "create a file" I assume is wrong but I included the rest in case I screwed it up somewhere else.

Thanks in advance
public class TestName {
   
       public static void main(String[] args) throws Exception {
      // Create a File instance
         java.io.File file = new java.io.File("names.txt");
      
         java.util.Scanner input = new java.util.Scanner(file);
      
         Name[] nameArray = new Name[10];
      
         //System.out.println(input.delimiter());
      
      // Read data from a file
         int index = 0;
         while (input.hasNext()) {
            String first = input.next();
            String middle = input.next();
            String last = input.next();
         
            Name name = new Name(first, middle, last);
         
            nameArray[index++] = name;
         }
      
         printNameArray(nameArray);
         printOutPut(nameArray);
      
      // Close the file
         input.close();
      }
   
       public static void printNameArray(Name[] nameArray) {
         Name name;
         String first;
         String middle;
         String last;
         for (int i = 0; i < nameArray.length; i++) {
            name = nameArray[i];
            first = name.getFirst();
            middle = name.getMiddle();
            last = name.getLast();
         
            System.out.println(nameArray[i].getFirst() + " " + nameArray[i].getMiddle() +  " " + nameArray[i].getLast() + " " +  nameArray[i].initials());
         
         
         
         
         
         
         }
      }
       public static void printOutPut(Name[] nameArray) throws Exception {
         java.io.File outfile = new java.io.File("output.txt");
         if (outfile.exists()) {
            System.out.println("File already exists");
            System.exit(0);
         }
         
         // Create a file
         java.io.PrintWriter output = new java.io.PrintWriter(outfile);
         Name name;
         String first;
         String middle;
         String last;
         for (int i = 0; i < nameArray.length; i++) {
            name = nameArray[i];
            first = name.getFirst();
            middle = name.getMiddle();
            last = name.getLast();
            
            output.print(nameArray[i].getLast() + ", " + nameArray[i].getFirst() + " " + nameArray[i].getMiddle() + "\n");
                       
                    
            // Close the file
            output.close();            
            //System.out.println(nameArray[i].getFirst() + " " + nameArray[i].getMiddle() +  " " + nameArray[i].getLast() + " " +  nameArray[i].initials());
            
            
            
            
            
            
         }
                 
      }
   }

Open in new window

0
Comment
Question by:Hueydude
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 3
4 Comments
 
LVL 86

Expert Comment

by:CEHJ
ID: 21831011
You close 'output' in the loop. Should  close after it
0
 
LVL 86

Accepted Solution

by:
CEHJ earned 500 total points
ID: 21831032
i.e. change

                for (int i = 0; i < nameArray.length; i++) {
                        name = nameArray[i];
                        first = name.getFirst();
                        middle = name.getMiddle();
                        last = name.getLast();

                        output.print(nameArray[i].getLast() + ", " +
                                nameArray[i].getFirst() + " " + nameArray[i].getMiddle() + "n");

                        // Close the file
                        output.close();

                }

to
                for (int i = 0; i < nameArray.length; i++) {
                        name = nameArray[i];
                        first = name.getFirst();
                        middle = name.getMiddle();
                        last = name.getLast();
 
                        output.print(nameArray[i].getLast() + ", " +
                                nameArray[i].getFirst() + " " + nameArray[i].getMiddle() + "n");
 
                } 
 
                // Close the file
                output.close();

Open in new window

0
 

Author Closing Comment

by:Hueydude
ID: 31469140
See, that's what ticks me off about this class. I should have been able to figure that out on my own!!

Thanks for the help!!
0
 
LVL 86

Expert Comment

by:CEHJ
ID: 21831340
:-) You'll get to know which dogs can bite in time ;-)
0

Featured Post

Build and deliver software with DevOps

A digital transformation requires faster time to market, shorter software development lifecycles, and the ability to adapt rapidly to changing customer demands. DevOps provides the solution.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

For beginner Java programmers or at least those new to the Eclipse IDE, the following tutorial will show some (four) ways in which you can import your Java projects to your Eclipse workbench. Introduction While learning Java can be done with…
Java had always been an easily readable and understandable language.  Some relatively recent changes in the language seem to be changing this pretty fast, and anyone that had not seen any Java code for the last 5 years will possibly have issues unde…
Viewers learn about the “for” loop and how it works in Java. By comparing it to the while loop learned before, viewers can make the transition easily. You will learn about the formatting of the for loop as we write a program that prints even numbers…
Viewers will learn one way to get user input in Java. Introduce the Scanner object: Declare the variable that stores the user input: An example prompting the user for input: Methods you need to invoke in order to properly get  user input:
Suggested Courses

721 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question