wally_davis
asked on
Need a C# Expert to review code: I want to delete a single Wkstn obj from AD.
I'm relatively new to C# Programming and I've created a small Windows App to delete single and multiple workstation objects from Active Directory. I want to make sure the program is written correctly before I test. I certainly don't want to delete the wrong objects and get terminate from my Job. I need a C# Expert to evaluate.
With utmost gratitude,
WD
With utmost gratitude,
WD
if (radioSingleObj.Checked)
{
if (textBoxSingle.Text == "")
{
MessageBox.Show("You need to enter a workstation name", "Input Required", MessageBoxButtons.OK, MessageBoxIcon.Exclamation);
}
else
{
string objectName = textBoxSingle.Text;
MessageBox.Show(objectName);
string strPath = "LDAP://OU=Workstations,OU=BAND,DC=Corp,DC=BankofAmerica,DC=Com";
DirectoryEntry entry = null;
entry = new DirectoryEntry(strPath);
DirectorySearcher wkstnSearcher = new DirectorySearcher(entry);
wkstnSearcher.Filter = "(&(objectClass=computer)(|(cn=" + objectName + ")))";
wkstnSearcher.ClientTimeout.Seconds.Equals(30);
SearchResult searchWkstn = wkstnSearcher.FindOne();
if (wkstnSearcher.CacheResults)
{
labelWkstnObjStatus.Text = "Workstation object was located";
entry.Properties["cn"].Remove(objectName);
entry.CommitChanges();
entry.Close();
}
else
{
labelWkstnObjStatus.Text = "Unabled to locate Workstation object";
}
}
}
First, are you able to create dummy entries that you can test code against?
ASKER
Unfortunately I am not. But, we a good number of Disabled workstations in our immense AD Database and was able to run a test on a couple. I did attempt to test it and here's the problem I ran into:
I can delete a Wkstn object from Active Directory Computer and Users tool but not my C# app. When it hits the line of code "entry.CommitChanges();, it gives me the following error:
UnAuthorizedAccessExceptio n was unhandled; General Access denied error".
I've both passed in the Username/Password credentials/parameters and have also removed the passing in of the USERNAME and Password Parameters and I get the same results.
I don't have rights/permissions to mange our AD environment and the NTDSUTIL as someone suggested is not an option.
I figured since AD Users and Computers tool allows me to delete a Wkstn object that I'm probably just missing something within my code or could be overlooking. However, if there is something in AD that could prevent my code from deleting the object, I'm all EARS and would appreciate any insight.
I can delete a Wkstn object from Active Directory Computer and Users tool but not my C# app. When it hits the line of code "entry.CommitChanges();, it gives me the following error:
UnAuthorizedAccessExceptio
I've both passed in the Username/Password credentials/parameters and have also removed the passing in of the USERNAME and Password Parameters and I get the same results.
I don't have rights/permissions to mange our AD environment and the NTDSUTIL as someone suggested is not an option.
I figured since AD Users and Computers tool allows me to delete a Wkstn object that I'm probably just missing something within my code or could be overlooking. However, if there is something in AD that could prevent my code from deleting the object, I'm all EARS and would appreciate any insight.
>>I've both passed in the Username/Password credentials/parameters
I can't see how you attempt this. What did you use to specify the credentials? Is it a user that has access to delete ActiveDirectory entities?
I can't see how you attempt this. What did you use to specify the credentials? Is it a user that has access to delete ActiveDirectory entities?
ASKER
yes. I passed in both my Username and Password (to the line of code below, p.s. see another excerpt of code below) as I have access to move, edit and delete Wkstn objects.
entry = new DirectoryEntry(strPath2, "USERNAME", "PASSWORD");
entry = new DirectoryEntry(strPath2, "USERNAME", "PASSWORD");
//string strPath = "LDAP://OU=AACOUNT,OU=FISHSUP,DC=HOLLY,DC=CREEK,DC=com";
string strPath2 = "LDAP://OU=FISHSUP,DC=HOLLY,DC=CREEK,DC=com";
DirectoryEntry entry = null;
entry = new DirectoryEntry(strPath2, "USERNAME", "PASSWORD");
DirectorySearcher wkstnSearcher = new DirectorySearcher(entry);
wkstnSearcher.Filter = "(&(objectClass=computer)(|(cn=" + objectName + ")))";
wkstnSearcher.ClientTimeout.Seconds.Equals(30);
SearchResult searchWkstn = wkstnSearcher.FindOne();
if (wkstnSearcher.CacheResults)
{
labelWkstnObjStatus.Text = "Workstation object was located";
entry.Properties["cn"].Remove(objectName);
entry.CommitChanges();
entry.Close();
}
else
{
labelWkstnObjStatus.Text = "Unabled to locate Workstation object";
}
Small, unimportant note:
All reference instances inherit from System.Object, which gives you Equals. It returns a boolean, which you are ignoring in this case:
wkstnSearcher.ClientTimeou t.Seconds. Equals(30) ;
Try this:
wkstnSearcher.ClientTimeou t.Seconds = 30;
All reference instances inherit from System.Object, which gives you Equals. It returns a boolean, which you are ignoring in this case:
wkstnSearcher.ClientTimeou
Try this:
wkstnSearcher.ClientTimeou
I don't see anything on the surface--you have an LDAP path (I assume it is valid, and the one that has the computers), and you have user credentials that has rights to manage objects. Do you have the correct user credentials? At first glance, it doesn't look like it from the exception that you are getting.
ASKER
TheLearnedOne,
I changed the line of code to this, --> wkstnSearcher.ClientTimeou t.Seconds = 30; and it gives me this error, "Error 1, Property or indexer 'System.TimeSpan.Seconds' cannot be assigned to -- it is read only".
Second, I discovered that there is a third parameter I could pass in to the line of code --> "entry = new DirectoryEntry(strPath2, "USERNAME", "PASSWORD", AuthenticationTypes authentication type);
It's a Bitwise value but I wouldn't know what to enter in so I'm going to see if I can find the values defined somewhere on the Internet. I know I'm using the correct credentials because I have deleted some Workstation objects from AD using the Active Directorys Users and Computers MMC Tool. Any further help would be appreciated. I feel like we're close on this one with the AuthenticationTypes.
I changed the line of code to this, --> wkstnSearcher.ClientTimeou
Second, I discovered that there is a third parameter I could pass in to the line of code --> "entry = new DirectoryEntry(strPath2, "USERNAME", "PASSWORD", AuthenticationTypes authentication type);
It's a Bitwise value but I wouldn't know what to enter in so I'm going to see if I can find the values defined somewhere on the Internet. I know I'm using the correct credentials because I have deleted some Workstation objects from AD using the Active Directorys Users and Computers MMC Tool. Any further help would be appreciated. I feel like we're close on this one with the AuthenticationTypes.
ASKER
TheLearnedOne,
Here's something I found on the Experts-Exchange website that pretty much indicates I'm not passing in my user credentials correctly. I already have one search Filter. Is it possible to have a second? If not, since I'm new to C#, would you be able to show me how I could add or use this code to replace what I have already in order to authenticate my user credentials properly to allow me to delete the computer object properly??
Here's something I found on the Experts-Exchange website that pretty much indicates I'm not passing in my user credentials correctly. I already have one search Filter. Is it possible to have a second? If not, since I'm new to C#, would you be able to show me how I could add or use this code to replace what I have already in order to authenticate my user credentials properly to allow me to delete the computer object properly??
Well, in that case it should be correct. To however authenticate a user, you can't use the code without modification. Firstly, you need to specify more detail on the query filter
mySearcher.Filter = String.Format("(&(objectClass=user)(objectCategory=person)(cn={0}))", userId);
Secondly , use FindOne instead of FindAll
SearchResult result = searcher.FindOne();
if ( result != null )
{
String userPath = "LDAP://LDAPServer/" + (String) result.Properties["distinguishedName"][0];
DirectoryEntry user = new DirectoryEntry( userPath, userId, password );
try
{
user.RefreshCache();
}
catch (ComException ex)
{
// exception is thrown when password is wrong
// check the error number
}
finally
{
if ( user != null ) { user.Close(); user.Disposed(); }
}
}
ASKER CERTIFIED SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.