?
Solved

Fetch Next From Cursor 2 values into 2 variables

Posted on 2008-06-23
5
Medium Priority
?
6,057 Views
Last Modified: 2012-05-05
I am trying to create a UDF.  My code is attached.

For each row retrieved by the SELECT statement there will be 2 values.  

What is the corret syntax to access both retrieved values?  What should I use instead of:
            FETCH NEXT FROM BusinessCommentCursor
            INTO @Business_Comment, @Employee_Name

ALTER FUNCTION [dbo].[Assemble_Business_Comments]
	(@Apps_Cat_ID int)
	RETURNS varchar(8000)
	AS
	BEGIN
		DECLARE @Employee_Name varchar(100)
		DECLARE @Business_Comment varchar(8000)
		DECLARE @Business_Comments varchar(8000)
		DECLARE BusinessCommentCursor CURSOR READ_ONLY FOR
		SELECT Tbl_Survey_Business_Respondents.Respondent_Comment, Tbl_Client_Employees.Employee_Name
			FROM Tbl_Survey_Business_Respondents INNER JOIN
                      Tbl_Client_Employees ON 
                      Tbl_Survey_Business_Respondents.Lookup_To_Tbl_Client_Employees_For_Business_Respondent = Tbl_Client_Employees.ID
			WHERE (Tbl_Survey_Business_Respondents.Apps_Cat_ID = @Apps_Cat_ID)
		OPEN BusinessCommentCursor
 
		FETCH NEXT FROM BusinessCommentCursor
		INTO @Business_Comment, @Employee_Name
 
		WHILE @@FETCH_STATUS = 0
		BEGIN
			IF @Business_Comment is not null 
				SET @Business_Comments = @Business_Comments + CHAR(13) + CHAR(10) + CHAR(13) + CHAR(10) + @Employee_Name
				SET @Business_Comments = @Business_Comments + CHAR(13) + CHAR(10) + @Business_Comment
			FETCH NEXT FROM BusinessCommentCursor
			INTO @Business_Comment, @Employee_Name
		END
		CLOSE BusinessCommentCursor
		DEALLOCATE BusinessCommentCursor
		IF @Business_Comment is null
			SET @Business_Comments = N'None provided'
      RETURN (@Business_Comments)
	END

Open in new window

0
Comment
Question by:wsturdev
  • 3
  • 2
5 Comments
 
LVL 143

Expert Comment

by:Guy Hengel [angelIII / a3]
ID: 21849702
the syntax is correct... however, you cannot use cursors in functions if I rmember correctly...
now, you have quite some logic errors in the code...

let me suggest this code:
ALTER FUNCTION [dbo].[Assemble_Business_Comments]
      (@Apps_Cat_ID int)
      RETURNS varchar(8000)
      AS
      BEGIN
        DECLARE @res VARCHAR(8000) 
        SELECT @res = COALESCE(@res + CHAR(13) + CHAR(10) + CHAR(13) + CHAR(10) , '') 
                    + c.Employee_Name 
                    + COALESCE( CHAR(13) + CHAR(10) + r.Respondent_Comment, '' )
          FROM Tbl_Survey_Business_Respondents r
          INNER JOIN Tbl_Client_Employees c
             ON r.Lookup_To_Tbl_Client_Employees_For_Business_Respondent = c.ID
          WHERE r.Apps_Cat_ID = @Apps_Cat_ID 

         IF @res is null
           SET @res = N'None provided'
          RETURN (@res)
        END

Open in new window

0
 
LVL 1

Author Comment

by:wsturdev
ID: 21849756
I guess my logic was kind of primitive!!!!

I am now getting this error:
Msg 402, Level 16, State 1, Procedure Assemble_Business_Comments, Line 9
The data types char and ntext are incompatible in the add operator.
0
 
LVL 1

Author Comment

by:wsturdev
ID: 21849774
Clicked Submit too soon...  Respondent_Comment is defined as ntext.
0
 
LVL 143

Accepted Solution

by:
Guy Hengel [angelIII / a3] earned 2000 total points
ID: 21849801
is this sql 2005?
then, change the NTEXT to NVARCHAR(MAX), and your VARCHAR(8000) in the function to NVARCHAR(MAX).
0
 
LVL 1

Author Closing Comment

by:wsturdev
ID: 31469913
Thanks!!
0

Featured Post

What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Composite queries are used to retrieve the results from joining multiple queries after applying any filters. UNION, INTERSECT, MINUS, and UNION ALL are some of the operators used to get certain desired results.​
One of the most important things in an application is the query performance. This article intends to give you good tips to improve the performance of your queries.
This video shows how to quickly and easily deploy an email signature for all users in Office 365 and prevent it from being added to replies and forwards. (the resulting signature is applied on the server level in Exchange Online) The email signat…
With just a little bit of  SQL and VBA, many doors open to cool things like synchronize a list box to display data relevant to other information on a form.  If you have never written code or looked at an SQL statement before, no problem! ...  give i…
Suggested Courses

850 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question