Solved

double check my code please?

Posted on 2008-06-23
2
154 Views
Last Modified: 2010-04-23
3rd part of my stock quote question...just want to make sure this looks clean to a trained eyeball... :^)
Imports System.IO
Imports System.Net
 
Public Class frmMain
    WithEvents tmr As New Timer
    Const strURL As String = "stocksite"
 
    Private Sub frmMain_Shown(ByVal sender As Object, ByVal e As System.EventArgs) Handles Me.Shown
        Me.Size = New Size(90, 20)
        Me.BackColor = Color.FromArgb(37, 95, 220)
        Me.Location = New Point(0, Screen.PrimaryScreen.Bounds.Height - Me.Height)
        lnkQuote.BackColor = Me.BackColor
    End Sub
 
    Private Sub frmMain_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
        tmr.Interval = 600000
        tmr.Enabled = True
        tmr.Start()
        UpdateQuote()
    End Sub
 
    Private Sub tmr_Tick(ByVal sender As Object, ByVal e As System.EventArgs) Handles tmr.Tick
        UpdateQuote()
    End Sub
 
    Sub UpdateQuote()
        Dim client As WebClient = New WebClient
        client.Proxy = New WebProxy("myproxy", True)
        client.Proxy.Credentials = CredentialCache.DefaultCredentials
        Dim data() As Byte = client.DownloadData(strURL)
        Dim strData As String = System.Text.Encoding.ASCII.GetString(data)
 
        'Function to parse strData and get the quote information...
 
        lnkQuote.Text = strQuote
 
        If strChange.Substring(0, 1) = "+" Then lblChg.ForeColor = Color.Lime
        If strChange.Substring(0, 1) = "-" Then lblChg.ForeColor = Color.Red
        lblChg.Text = strChange
    End Sub
End Class

Open in new window

0
Comment
Question by:sirbounty
2 Comments
 
LVL 67

Author Comment

by:sirbounty
ID: 21850481
Only thing I was thinking was to add a try/catch block when downloading the page...
0
 
LVL 47

Accepted Solution

by:
Wayne Taylor (webtubbs) earned 250 total points
ID: 21853278
Hi sirbounty!

Looks good to me. Maybe specify the parameters when setting the proxy, so it doesn't confuse True for the port number (-1). It probably won't (haven't tested it), but better to be safe than sorry....

    client.Proxy = New WebProxy(Address:="myproxy", BypassOnLocal:=True)

Wayne
0

Featured Post

Announcing the Most Valuable Experts of 2016

MVEs are more concerned with the satisfaction of those they help than with the considerable points they can earn. They are the types of people you feel privileged to call colleagues. Join us in honoring this amazing group of Experts.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Well, all of us have seen the multiple EXCEL.EXE's in task manager that won't die even if you call the .close, .dispose methods. Try this method to kill any excels in memory. You can copy the kill function to create a check function and replace the …
Introduction As chip makers focus on adding processor cores over increasing clock speed, developers need to utilize the features of modern CPUs.  One of the ways we can do this is by implementing parallel algorithms in our software.   One recent…
The Email Laundry PDF encryption service allows companies to send confidential encrypted  emails to anybody. The PDF document can also contain attachments that are embedded in the encrypted PDF. The password is randomly generated by The Email Laundr…
Finds all prime numbers in a range requested and places them in a public primes() array. I've demostrated a template size of 30 (2 * 3 * 5) but larger templates can be built such 210  (2 * 3 * 5 * 7) or 2310  (2 * 3 * 5 * 7 * 11). The larger templa…

820 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question