double check my code please?

3rd part of my stock quote question...just want to make sure this looks clean to a trained eyeball... :^)
Imports System.IO
Imports System.Net
 
Public Class frmMain
    WithEvents tmr As New Timer
    Const strURL As String = "stocksite"
 
    Private Sub frmMain_Shown(ByVal sender As Object, ByVal e As System.EventArgs) Handles Me.Shown
        Me.Size = New Size(90, 20)
        Me.BackColor = Color.FromArgb(37, 95, 220)
        Me.Location = New Point(0, Screen.PrimaryScreen.Bounds.Height - Me.Height)
        lnkQuote.BackColor = Me.BackColor
    End Sub
 
    Private Sub frmMain_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
        tmr.Interval = 600000
        tmr.Enabled = True
        tmr.Start()
        UpdateQuote()
    End Sub
 
    Private Sub tmr_Tick(ByVal sender As Object, ByVal e As System.EventArgs) Handles tmr.Tick
        UpdateQuote()
    End Sub
 
    Sub UpdateQuote()
        Dim client As WebClient = New WebClient
        client.Proxy = New WebProxy("myproxy", True)
        client.Proxy.Credentials = CredentialCache.DefaultCredentials
        Dim data() As Byte = client.DownloadData(strURL)
        Dim strData As String = System.Text.Encoding.ASCII.GetString(data)
 
        'Function to parse strData and get the quote information...
 
        lnkQuote.Text = strQuote
 
        If strChange.Substring(0, 1) = "+" Then lblChg.ForeColor = Color.Lime
        If strChange.Substring(0, 1) = "-" Then lblChg.ForeColor = Color.Red
        lblChg.Text = strChange
    End Sub
End Class

Open in new window

LVL 67
sirbountyAsked:
Who is Participating?
 
Wayne Taylor (webtubbs)Connect With a Mentor Commented:
Hi sirbounty!

Looks good to me. Maybe specify the parameters when setting the proxy, so it doesn't confuse True for the port number (-1). It probably won't (haven't tested it), but better to be safe than sorry....

    client.Proxy = New WebProxy(Address:="myproxy", BypassOnLocal:=True)

Wayne
0
 
sirbountyAuthor Commented:
Only thing I was thinking was to add a try/catch block when downloading the page...
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.