Solved

template function w/ type & non-type parameters

Posted on 2008-06-24
5
510 Views
Last Modified: 2013-12-14
I have the following class definitions:

template<unsigned dim>
class Vector
{ ... };

template<unsigned dim>
class Displacement : public Vector<dim>
{ ... };
template<unsigned dim>
class Velocity : public Vector<dim>
{ ... };
template<unsigned dim>
class Acceleration : public Vector<dim>
{ ... };

etc.

Now I want to overload binary operators +, - , *, /. But I don't want to write member functions for all vector types. (there are too many.) So I wrote the following template function:
      template<typename T, unsigned dim>
      T<dim> operator + (const T<dim> & t0, const T<dim> & t1)                 <<<< C2988 on this line
      {
            T<dim> ret;
            for (int i=0; i<dim; i++)
                  ret[i] = t0[i] + t1[i];
      }
But I get compiler error C2988 (unrecognizable template declaration/definition; Visual Studio Pro 2008). The help page (http://msdn.microsoft.com/en-us/library/f69a8fb8.aspx) is pretty useless.
Is it possible to write template like above (of course, w/o syntax errors) or do I have no choice but to copy-paste for all types derived from Vector<dim>?
0
Comment
Question by:jhshukla
  • 4
5 Comments
 
LVL 86

Expert Comment

by:jkr
ID: 21862056
Hmmm, I guess you meant the following:
      template<typename T, unsigned dim>

      T operator + (const T & t0[dim], const T & t1[dim])

      {

            T ret[dim];

            for (int i=0; i<dim; i++)

                  ret[i] = t0[i] + t1[i];

      }

Open in new window

0
 
LVL 9

Author Comment

by:jhshukla
ID: 21862464
no I did not mean that.
The code you suggested would create (well, it is reference. so technically not "create" but let me use that term here anyways) an array of T's. I want one variable of type T<dim>.

and if [] inside the function confused you, it is using overloaded [] operator. to be more elaborate this is how Vector class is defined:
	template<unsigned dim>

	class Vector

	{

	public:

		Vector(double *init = NULL)

		{

			if (init == NULL)

				memset(components, 0, sizeof(components));

			else

				memcpy(components, init, sizeof(components));

		}

		~Vector(void) {}
 

		inline double operator[](int i) const { return components[i]; }

		inline double & operator[](int i) { return components[i]; }
 

/*

		these commented out functions are the ones I want to mimic using

		templates

		inline Vector<dim> operator/(double div) const

		{

			Vector<dim> ret;

			for (int i=0; i<dim; i++)

				ret[i] = components[i] / div;

		}

		inline Vector<dim> operator*(double mul) const

		{

			Vector<dim> ret;

			for (int i=0; i<dim; i++)

				ret[i] = components[i] * mul;

		}
 

		inline Vector<dim> operator+(Vector<dim> that) const

		{

			Vector<dim> ret;

			for (int i=0; i<dim; i++)

				ret[i] = components[i] + that[i];

		}

		inline Vector<dim> operator-(Vector<dim> that) const

		{

			Vector<dim> ret;

			for (int i=0; i<dim; i++)

				ret[i] = components[i] - that[i];

		}

*/

		inline double MagnitudeSq() const

		{ return dot(*this, *this); }

		inline double Magnitude() const

		{ return sqrt(MagnitudeSq()); }

		inline static double dot(const Vector<dim> & v0, const Vector<dim> & v1)

		{

			double accum = 0;

			for (int i=0; i<dim; i++)

				accum += v0[i]*v1[i];

			return accum;

		}
 

	private:

		double components[dim];

	};

Open in new window

0
 
LVL 9

Author Comment

by:jhshukla
ID: 21862492
Forgot to mention that T will always be a derived class of Vector<dim>.

I expect to be able to use the template like this:
Displacement<3> d1, d2, d3;
d3 = d1 + d2;

The addition statement will cause the following function to be instantiated:
Displacement<3> operator + (const Displacement<3> &t0, const Displacement<3> &t1)
{ ... }

I found something called "template template parameter." no, it is not a typo. the word "template" is repeated. but cannot get it to work. e.g.
http://publib.boulder.ibm.com/infocenter/macxhelp/v6v81/topic/com.ibm.vacpp6m.doc/language/ref/clrc16template_template_parameters.htm
and with some explanation: http://www.informit.com/articles/article.aspx?p=376878

I modified the function template after reading InformIT article but I get even more errors now:
      template<template<unsigned dim> T>
      T operator + (const T & t0, const T & t1)
      {
            T ret;
            for (int i=0; i<dim; i++)
                  ret[i] = t0[i] + t1[i];
      }
0
 
LVL 9

Author Comment

by:jhshukla
ID: 21862571
update. I made a mistake above. it is supposed to be the following:
      template<template<unsigned dim> class T>
      T operator + (const T & t0, const T & t1)                   <<< C3205 here
      {
            T ret;
            for (int i=0; i<dim; i++)
                  ret[i] = t0[i] + t1[i];
      }

however, now I am getting the error: "C3205: argument list for template template parameter 'T' is missing."
If I replace it with T<dim> it says "error C2065: 'dim' : undeclared identifier."
      template<template<unsigned dim> class T>
      T<dim> operator + (const T<dim> & t0, const T<dim> & t1)
      {
            T<dim> ret;
            for (int i=0; i<dim; i++)
                  ret[i] = t0[i] + t1[i];
      }
0
 
LVL 9

Accepted Solution

by:
jhshukla earned 0 total points
ID: 21862696
phew. finally figured it out.

found clue here: http://hal.iwr.uni-heidelberg.de/lehre/prosem-06/Popov.pdf
scroll to p11

// This works:

	template<template<unsigned> class T, unsigned dim>

	T<dim> operator + (const T<dim> & t0, const T<dim> & t1)

	{

		T<dim> ret;

		for (int i=0; i<dim; i++)

			ret[i] = t0[i] + t1[i];

		return ret;

	}
 

// This should work too (template parameters are switched. nothing big):

	template<unsigned dim, template<unsigned> class T>

	T<dim> operator + (const T<dim> & t0, const T<dim> & t1)

	{

		T<dim> ret;

		for (int i=0; i<dim; i++)

			ret[i] = t0[i] + t1[i];

		return ret;

	}
 

// after this we can use statements like:

Displacement<3> d1, d2, d3;

d3 = d1 + d2;

Velocity<2> v1, v2, v3;

v1 = v2 + v3;

Open in new window

0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

This article shows you how to optimize memory allocations in C++ using placement new. Applicable especially to usecases dealing with creation of large number of objects. A brief on problem: Lets take example problem for simplicity: - I have a G…
How to install Selenium IDE and loops for quick automated testing. Get Selenium IDE from http://seleniumhq.org Go to that link and select download selenium in the right hand columnThat will then direct you to their download page.From that page s…
The viewer will learn how to user default arguments when defining functions. This method of defining functions will be contrasted with the non-default-argument of defining functions.
This is Part 3 in a 3-part series on Experts Exchange to discuss error handling in VBA code written for Excel. Part 1 of this series discussed basic error handling code using VBA. http://www.experts-exchange.com/videos/1478/Excel-Error-Handlin…

910 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

22 Experts available now in Live!

Get 1:1 Help Now