Dynamic Order Clause

I am trying to set up a stored procedure based on what the user selects, will sort the result set by the following:
Low to high
High to low
Name

And this is what I have


DECLARE @bigCategoryId INT
DECLARE @intPageLen INT
DECLARE @intPageIndex INT
DECLARE @strSortOrder VARCHAR(10)
DECLARE @intStartRowIndex INT
   
    SET @strSortOrder = 'nme'
    SET @bigCategoryId = 50
    SET @intpagelen = 16
    SET @intPageIndex = 1
    SET @intStartRowIndex = ((@intPageIndex-1) * @intPageLen) + 1;
      
      --Pull back the product listing
    WITH ProductListing AS (
        SELECT ROW_NUMBER() OVER (ORDER BY sic.id ASC) AS row, sic.id,
                   rtrim(sic.invtid) AS invtid,prd.descr,
            dbo.func_priceproduct_getprice_itemonly(prd.invtid,1) AS price
            FROM siteitemcategory sic WITH (NOLOCK)
            INNER JOIN products prd ON prd.invtid = sic.invtid
            WHERE sitecategories_id
            IN (SELECT id FROM siteCategories WHERE menu_parent = @bigCategoryId OR id = @bigCategoryId)
    )
   
    SELECT row,id,invtid,descr, price
            FROM productlisting
            WHERE Row
                        BETWEEN @intStartRowIndex AND @intStartRowIndex+@intPageLen-1
ORDER BY CASE WHEN @strSortOrder = 'low' THEN price
              WHEN @strSortOrder = 'high' THEN price
              WHEN @strSortOrder = 'nme' THEN descr
              ELSE descr
              END


However I am getting the following message all the time
Msg 235, Level 16, State 0, Line 15
Cannot convert a char value to money. The char value has incorrect syntax.

I know right now the desc is at the end of the case statement, but I was hoping to make this part of the case statement result.

I really am trying to avoid writing dynamic sql for this or putting a if clause in place based on the value of the sort type. Any help would be appreciated. Thanks.
JDEE8297Asked:
Who is Participating?

Improve company productivity with a Business Account.Sign Up

x
 
patriktConnect With a Mentor Commented:
If you want to fix paging problem you have to put the CASE... inside OVER (ORDER BY ...).
If you need changing ASC / DESC only dynamic SQL will help you.

Patrik
0
 
patriktCommented:
The CASE in order is not good. For this I suggest to put your CASE as new column into ProductListing (say named Sort). Than just ORDER BY Sort.
Secondly you have to conver all columns tosame type so Sort column will be strict typed (nvarchar for ex.). Be carefull that you will sort on character data, not numeric so order can change depending on format.

Patrik
0
 
JDEE8297Author Commented:
Sorry, you lost me with putting a new column into productlisting and do the sort on that. Not exactly sure how you would do that.
0
Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

 
patriktCommented:
I'll try, you will test :)
DECLARE @bigCategoryId INT
DECLARE @intPageLen INT
DECLARE @intPageIndex INT
DECLARE @strSortOrder VARCHAR(10)
DECLARE @intStartRowIndex INT
    
    SET @strSortOrder = 'nme'
    SET @bigCategoryId = 50 
    SET @intpagelen = 16
    SET @intPageIndex = 1
    SET @intStartRowIndex = ((@intPageIndex-1) * @intPageLen) + 1;
      
      --Pull back the product listing
    WITH ProductListing AS (
        SELECT ROW_NUMBER() OVER (ORDER BY sic.id ASC) AS row, sic.id,
                   rtrim(sic.invtid) AS invtid,prd.descr, 
            dbo.func_priceproduct_getprice_itemonly(prd.invtid,1) AS price,
			CASE WHEN @strSortOrder = 'low' THEN cast(price as nvarchar(100))  --other convert should be there
              WHEN @strSortOrder = 'high' THEN cast(price as nvarchar(100))
              WHEN @strSortOrder = 'nme' THEN descr 
              ELSE descr
              END as Sort 
            FROM siteitemcategory sic WITH (NOLOCK)
            INNER JOIN products prd ON prd.invtid = sic.invtid
            WHERE sitecategories_id 
            IN (SELECT id FROM siteCategories WHERE menu_parent = @bigCategoryId OR id = @bigCategoryId)
    )
    
    SELECT row,id,invtid,descr, price 
            FROM productlisting 
            WHERE Row 
                        BETWEEN @intStartRowIndex AND @intStartRowIndex+@intPageLen-1
	ORDER BY Sort

Open in new window

0
 
patriktCommented:
I just spoted big problem in your solution. You are doing pageing based on sic.id and then you sort. It will sort only the page content and it is probably not your desired behavior. When doing pageing you should sort first and after that select one page.

Patrik
0
 
JDEE8297Author Commented:
I am starting to think this is not going to work the way I want it to, I tried what you sent over.

Since I alias the price column I had to change it to the following lines
            CASE WHEN @strSortOrder = 'low' THEN cast(dbo.func_priceproduct_getprice_itemonly(prd.invtid,1) as nvarchar(100))  --other convert should be there
              WHEN @strSortOrder = 'high' THEN cast(dbo.func_priceproduct_getprice_itemonly(prd.invtid,1) as nvarchar(100))

Once that was done I was able to get results, however, still doesn't matter whether I put in low or high or nme...since on this line

  SELECT row,id,invtid,descr, price
            FROM productlisting
            WHERE Row
                        BETWEEN @intStartRowIndex AND @intStartRowIndex+@intPageLen-1
      ORDER BY Sort

I need to tell it if it is "low" then the order clause would be ORDER BY Sort desc or ORDER BY Sort ASC if I want it by high prices.

to the last remark you made where you spotted a big problem in solution. I was thinking of using this

    WITH ProductListing AS (
        SELECT TOP 100 PERCENT ROW_NUMBER() OVER (ORDER BY sic.id ASC) AS row, sic.id,
                   rtrim(sic.invtid) AS invtid,prd.descr,
            dbo.func_priceproduct_getprice_itemonly(prd.invtid,1) AS price,
                  CASE WHEN @strSortOrder = 'low' THEN cast(dbo.func_priceproduct_getprice_itemonly(prd.invtid,1) as nvarchar(100))  --other convert should be there
              WHEN @strSortOrder = 'high' THEN cast(dbo.func_priceproduct_getprice_itemonly(prd.invtid,1) as nvarchar(100))
              WHEN @strSortOrder = 'nme' THEN descr
              ELSE descr
              END as Sort
            FROM siteitemcategory sic WITH (NOLOCK)
            INNER JOIN products prd ON prd.invtid = sic.invtid
            WHERE sitecategories_id
            IN (SELECT id FROM siteCategories WHERE menu_parent = @bigCategoryId OR id = @bigCategoryId)
            ORDER BY SORT
    )

However, I think I will still send up my same problem, may be I wrong, what do you think.
      DECLARE @bigCategoryId INT
DECLARE @intPageLen INT
DECLARE @intPageIndex INT
DECLARE @strSortOrder VARCHAR(10)
DECLARE @intStartRowIndex INT
    
    SET @strSortOrder = 'low'
    SET @bigCategoryId = 50 
    SET @intpagelen = 16
    SET @intPageIndex = 1
    SET @intStartRowIndex = ((@intPageIndex-1) * @intPageLen) + 1;
      
      --Pull back the product listing
    WITH ProductListing AS (
        SELECT ROW_NUMBER() OVER (ORDER BY sic.id ASC) AS row, sic.id,
                   rtrim(sic.invtid) AS invtid,prd.descr, 
            dbo.func_priceproduct_getprice_itemonly(prd.invtid,1) AS price,
			CASE WHEN @strSortOrder = 'low' THEN cast(dbo.func_priceproduct_getprice_itemonly(prd.invtid,1) as nvarchar(100))  --other convert should be there
              WHEN @strSortOrder = 'high' THEN cast(dbo.func_priceproduct_getprice_itemonly(prd.invtid,1) as nvarchar(100))
              WHEN @strSortOrder = 'nme' THEN descr 
              ELSE descr
              END as Sort 
            FROM siteitemcategory sic WITH (NOLOCK)
            INNER JOIN products prd ON prd.invtid = sic.invtid
            WHERE sitecategories_id 
            IN (SELECT id FROM siteCategories WHERE menu_parent = @bigCategoryId OR id = @bigCategoryId)
    )
    
    SELECT row,id,invtid,descr, price 
            FROM productlisting 
            WHERE Row 
                        BETWEEN @intStartRowIndex AND @intStartRowIndex+@intPageLen-1
	ORDER BY Sort 

Open in new window

0
 
JDEE8297Author Commented:
figured it was going to be that. Thank you for your help.
0
 
JDEE8297Author Commented:
thank you for your help.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.