Solved

SQL stored procedure datetime question

Posted on 2008-06-25
9
2,635 Views
Last Modified: 2010-04-21
Hi i have a stored procddue please see attched

to execute the procedure i need to use

execute empcount 'Dec 1 2007', 'dec 31 2008'

the problem is the application that send the execute command want to use

exec empcount(2000-01-01 00:00:00.000000000,
2000-01-01 00:00:00.000000000)

can i tweak the procedure to accept these values?

--Declare Start and End variables (these can also be passed into a stored procedure)
DECLARE @startdate 	smalldatetime,
	@endDate   	smalldatetime
 
--this drops the hours and minutes and sets them to 00:00
Set @startdate  = convert(varchar,'Nov 1, 2008' ,111)
Set @endDate  = convert(varchar,'Dec 31 2008' ,111)
 
--Declare EnD Date tmp variable to be used in the loop
DECLARE @tmpEndDate	smalldatetime
--Declare tmp table to act as a temporary holding place for your data
DECLARE @tmpTable	TABLE(
			StartDate	smalldatetime,
			EndDate		smalldatetime,
			noemp 		integer)
--Set @startdate to beginning of month span
Set @startdate =  DATEADD(dd,-(DAY(DATEADD(m,1,@startdate))-1),@startdate)
--set @endDate to end of month span
Set @endDate =  DATEADD(dd, -DAY(DATEADD(m,1,@endDate)), DATEADD(m,1,@endDate))
 
--loop through each month
While @startdate < @endDate
BEGIN
         --set @tmpEndDate to last minute of month
	Set @tmpEndDate = dateadd(n,-1,dateadd(m,1,@startdate))
         --insert values in table
	Insert into @tmpTable(StartDate,EndDate,noemp) 
		Select @startdate as startdate, @tmpEndDate as enddate, NoEmployees as noemp 
		      from CTContracts 
		      Where Fromdate  <= @tmpEndDate And  EndDate >= @startdate
		      and LKContractTypeID = 8
         --increment @startdate 
	Set @startdate = dateadd(m,1,@startdate)
END
 
--Now you can do what you want with the results
Select * from @tmpTable
Select Min(StartDate) as StartDate, Max(EndDate) as EndDate, Sum(noemp) as noemp from @tmpTable

Open in new window

0
Comment
Question by:ac_davis2002
9 Comments
 
LVL 2

Accepted Solution

by:
pierky earned 500 total points
ID: 21864795
Well,

this syntax is wrong
exec empcount(2000-01-01 00:00:00.000000000, 2000-01-01 00:00:00.000000000)

At least you have to remove "(" and ")" and add quotes to the date:

exec empcount '2000-01-01 00:00:00.000000000', '2000-01-01 00:00:00.000000000'

If you can run this command (and if input date is always in this format) you can change the stored-procedure in this way:

CREATE PROCEDURE empcount (
@strStart varchar(30),
@strStop varchar(30)
) AS
 
DECLARE @startdate 	smalldatetime
DECLARE @endDate   	smalldatetime
SET @startdate = CONVERT( datetime, LEFT( @strStart, 23 ), 121 )
SET @endDate = CONVERT( datetime, LEFT( @strStop, 23 ), 121 )
 
[...]

Open in new window

0
 
LVL 2

Expert Comment

by:HengTime
ID: 21864809
you could pass the parameters (the dates)  as nvarchar  and then convert them to datetime

have a look at this. its the convert syntax

http://msdn.microsoft.com/en-us/library/ms187928.aspx

the style you need I think would be 121 which is odbc canonical with millisecs
0
 
LVL 143

Expert Comment

by:Guy Hengel [angelIII / a3]
ID: 21864994
if the parameter is already datetime (or smalldatetime), you don't need to convert them "again" to varchar or datetime!

>exec empcount(2000-01-01 00:00:00.000000000, 2000-01-01 00:00:00.000000000)
I must assume that it actually calls the proc like this:
exec empcount('2000-01-01 00:00:00.000000000', '2000-01-01 00:00:00.000000000')

in which case, if the parameter is datetime, it will accept it (smalldatetime might be a problem)
0
PRTG Network Monitor: Intuitive Network Monitoring

Network Monitoring is essential to ensure that computer systems and network devices are running. Use PRTG to monitor LANs, servers, websites, applications and devices, bandwidth, virtual environments, remote systems, IoT, and many more. PRTG is easy to set up & use.

 

Author Comment

by:ac_davis2002
ID: 21865012
Hi chaps

pierky, i can remove thr brackets but I need to insert a quote
in otherwords I can send this
2000-01-01 00:00:00.000000000, 2000-01-01 00:00:00.000000000

but need a way of inserting quotes

'2000-01-01 00:00:00.000000000', '2000-01-01 00:00:00.000000000'
0
 
LVL 2

Expert Comment

by:pierky
ID: 21865264
The syntax

exec empcount 2000-01-01 00:00:00.000000000, 2000-01-01 00:00:00.000000000

is wrong, SQL server will not parse this command.
You need to change the way your application call the stored-procedure, adding quotes.
What's the language used to build the app? Do you have source code?
0
 

Author Comment

by:ac_davis2002
ID: 21865371
well actuall its cognos, I am calling a sql procedue from cognos. do you have any cognos knowledge?
0
 
LVL 2

Expert Comment

by:pierky
ID: 21865427
No, sorry!
0
 

Author Comment

by:ac_davis2002
ID: 21865514
no worries, thanks for your help anyway

I'll pass you the poinst as you answered my original question!
0
 

Author Closing Comment

by:ac_davis2002
ID: 31470522
thnaks again!
0

Featured Post

PRTG Network Monitor: Intuitive Network Monitoring

Network Monitoring is essential to ensure that computer systems and network devices are running. Use PRTG to monitor LANs, servers, websites, applications and devices, bandwidth, virtual environments, remote systems, IoT, and many more. PRTG is easy to set up & use.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
First Max value 3 30
SQL R 21 28
sql 2016 data tools breakdown.. 1 15
SQL - Curser to do an insert based on a select 2 10
When you hear the word proxy, you may become apprehensive. This article will help you to understand Proxy and when it is useful. Let's talk Proxy for SQL Server. (Not in terms of Internet access.) Typically, you'll run into this type of problem w…
Slowly Changing Dimension Transformation component in data task flow is very useful for us to manage and control how data changes in SSIS.
Via a live example, show how to extract insert data into a SQL Server database table using the Import/Export option and Bulk Insert.
Via a live example, show how to set up a backup for SQL Server using a Maintenance Plan and how to schedule the job into SQL Server Agent.

828 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question