[2 days left] What’s wrong with your cloud strategy? Learn why multicloud solutions matter with Nimble Storage.Register Now


CWinThread and CDialog - getting them work together

Posted on 2008-06-25
Medium Priority
1 Endorsement
Last Modified: 2013-12-14

I have created a new thread - that works perfect. Now I want to display a CDialog in this thread. In a Thread Montor a new thread with the name of the dialog is shown but i can not see the dialog. I have called the dialog without a thread - that worked. That have I done wrong?

Below some code which may help.

Greedings Sonja
// Call of the thread
  CMyThread * MyThread = new CMyThread();
  MyThread ->CreateThread(CREATE_SUSPENDED);
  MyThread ->m_Parameter = Parameter;
  MyThread ->m_pDialog = pDialog;
  MyThread ->ResumeThread();
// MyThread.cpp - class CMyThread : public CWinThread
int MyThread::Run()
  //pDialog initialized to NULL in the constructor of CMyWnd class
   CMyDialog* pDialog = new CMyDialog();
   //Check if new succeeded and we got a valid pointer to a dialog object
   if(pDialog != NULL)
      BOOL ret = pDialog->Create(IDD_MYDIALOG,NULL); // <- In the debugger it stops here
      if(!ret)   //Create failed.
         AfxMessageBox("Error creating Dialog");
      AfxMessageBox("Error Creating Dialog Object");
  return 0;

Open in new window

Question by:Sonja_M
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
LVL 19

Expert Comment

ID: 21866855
You should avoid to open a dialog in a different thread
LVL 45

Expert Comment

ID: 21867022
There are two types of thread.  A worker thread (does NOT support windows) and a UI thread (does support windows).
Which type are you using?  I suspect the first.
LVL 19

Expert Comment

ID: 21873986
>> int MyThread::Run()

Don't forget that when Run() returns, the thread ends.  So your thread will only be around for a split second.  

Generally it is a good idea not to override CWinThread::Run().  A better place to put your code is in InitInstance().  Add this function to your class and move the code to create the dialog into it.  This should resolve the problem.

Will your db performance match your db growth?

In Percona’s white paper “Performance at Scale: Keeping Your Database on Its Toes,” we take a high-level approach to what you need to think about when planning for database scalability.

LVL 19

Expert Comment

ID: 21874527
OK this works.  The key is in setting CWinThread::m_pMainWnd to be your dialog:

BOOL MyThread::InitInstance()
	CMyDialog* pDialog = new CMyDialog();
	BOOL ret = pDialog->Create(IDD_MYDIALOG,NULL); 
	m_pMainWnd = pDialog;
	m_pMainWnd->ShowWindow( SW_SHOW );
	return CWinThread::InitInstance();

Open in new window

LVL 19

Accepted Solution

mrwad99 earned 1996 total points
ID: 21874798
>> The key is in setting CWinThread::m_pMainWnd to be your dialog:

Sorry but that is not true, I made a mistake.  The key is in returning TRUE (not CWinThread::InitInstance(), which returns FALSE, thereby shutting down the thread) from InitInstance().  You don't have to do anything with m_pMainWnd.

Revised code follows.
BOOL MyThread::InitInstance()
        CMyDialog* pDialog = new CMyDialog();
        BOOL ret = pDialog->Create(IDD_MYDIALOG,NULL); 
        pDialog->ShowWindow( SW_SHOW );
        return TRUE;

Open in new window


Author Closing Comment

ID: 31470621
Thank you! Now it is working! Problem solved.
LVL 19

Expert Comment

ID: 21876669
Glad to help.

Featured Post

Free Tool: IP Lookup

Get more info about an IP address or domain name, such as organization, abuse contacts and geolocation.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Introduction: Finishing the grid – keyboard support for arrow keys to manoeuvre, entering the numbers.  The PreTranslateMessage function is to be used to intercept and respond to keyboard events. Continuing from the fourth article about sudoku. …
Introduction: Ownerdraw of the grid button.  A singleton class implentation and usage. Continuing from the fifth article about sudoku.   Open the project in visual studio. Go to the class view – CGridButton should be visible as a class.  R…
The viewer will learn how to use and create new code templates in NetBeans IDE 8.0 for Windows.
This video will show you how to get GIT to work in Eclipse.   It will walk you through how to install the EGit plugin in eclipse and how to checkout an existing repository.
Suggested Courses

656 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question