We help IT Professionals succeed at work.

DbConnection CreateCommand  Stored Procedure window form

myebay asked
Last Modified: 2010-04-21

I have a function that works but I need to change it in Stored Procedure called "viewAllUsers". Could you tell me what I need to change to make it works?

private List<User> GetUsersFromDB(DbConnection cnx)
            List<User> users = new List<User>();

            using (DbCommand cmd = cnx.CreateCommand())
                cmd.CommandType = System.Data.CommandType.Text;
                cmd.CommandText = "SELECT * FROM UserTable";

                 using (DbDataReader reader = cmd.ExecuteReader())
                    while (reader.Read())
                        User user = new User();
                        user.UserID = reader["UserID"] == DBNull.Value ? default(int) : int.Parse(reader["UserID"].ToString());
                        user.UserName = reader["Name"] == DBNull.Value ? default(string) : reader["Name"].ToString();
                        user.UserPassword = reader["Password"] == DBNull.Value ? default(string) : reader["Password"].ToString();
                        user.UserGender = reader["Gender"] == DBNull.Value ? default(string) : reader["Gender"].ToString();
                        user.UserAge = reader["Age"] == DBNull.Value ? default(int) : int.Parse(reader["Age"].ToString());
                        user.UserGeneral = reader["General"] == DBNull.Value ? default(string) : reader["General"].ToString();
                        user.UserTDI_Type = reader["TDI_Type"] == DBNull.Value ? default(string) : reader["TDI_Type"].ToString();
                        user.UserPhilisophy = reader["Philisophy"] == DBNull.Value ? default(string) : reader["Philisophy"].ToString();
                        user.UserReligion = reader["Religion"] == DBNull.Value ? default(string) : reader["Religion"].ToString();
                        user.UserPolitics = reader["Politics"] == DBNull.Value ? default(string) : reader["Politics"].ToString();
                        user.UserUseFrequency = reader["UseFrequency"] == DBNull.Value ? default(int) : int.Parse(reader["UseFrequency"].ToString());
                        user.UserViewFrequency = reader["ViewFrequency"] == DBNull.Value ? default(int) : int.Parse(reader["ViewFrequency"].ToString());

            return users;
Watch Question

This one is on us!
(Get your first solution completely free - no credit card required)

check this......


the concept is same just use  DbConnection incase of SqlConnection ( same for command and reader)


thank you

Gain unlimited access to on-demand training courses with an Experts Exchange subscription.

Get Access
Why Experts Exchange?

Experts Exchange always has the answer, or at the least points me in the correct direction! It is like having another employee that is extremely experienced.

Jim Murphy
Programmer at Smart IT Solutions

When asked, what has been your best career decision?

Deciding to stick with EE.

Mohamed Asif
Technical Department Head

Being involved with EE helped me to grow personally and professionally.

Carl Webster
CTP, Sr Infrastructure Consultant
Empower Your Career
Did You Know?

We've partnered with two important charities to provide clean water and computer science education to those who need it most. READ MORE

Ask ANY Question

Connect with Certified Experts to gain insight and support on specific technology challenges including:

  • Troubleshooting
  • Research
  • Professional Opinions
Unlock the solution to this question.
Join our community and discover your potential

Experts Exchange is the only place where you can interact directly with leading experts in the technology field. Become a member today and access the collective knowledge of thousands of technology experts.

*This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.


Please enter a first name

Please enter a last name

8+ characters (letters, numbers, and a symbol)

By clicking, you agree to the Terms of Use and Privacy Policy.