AboutPricingCommunityTeamsStart Free TrialLog in
Avatar of dudure
dudure
 asked on

How to map a drive & create folder based on AD Group

Hi ,
i have a script that create and map folder to user i want to repleace the for each sentence to if sentence
Like - i want to repleace for each  user is in group do this To if a user is in group do that .
For Each oUser In objGroupDP.Members to IF  oUser In objGroupDP.Members Then .......
the script :
---------------------

On Error Resume Next

Set objGroupDP = GetObject("LDAP://CN=DPCtxBakara,OU=çÑÕæÕê áÙØèÙçá,OU=Groups,OU=MahozDanPT,OU=Mehozot,DC=Domain,DC=Com")
Set objGroupDR = GetObject("LDAP://CN=DRCtxBakara,OU=Citrix,OU=Groups,OU=MahozDarom,OU=Mehozot,DC=Domain,DC=Com")
Set objGroupHF = GetObject("LDAP://CN=HFCtxBakara,OU=Citrix,OU=Groups,OU=MahozHaifa,OU=Mehozot,DC=Domain,DC=Com")
Set objGroupJR = GetObject("LDAP://CN=JRCtxBakara,OU=Citrix,OU=Groups,OU=MahozJerusalem,OU=Mehozot,DC=Domain,DC=Com")
Set objGroupMR = GetObject("LDAP://CN=MRCtxBakara,OU=Citrix,OU=Groups,OU=MahozMerkaz,OU=Mehozot,DC=Domain,DC=Com")
Set objGroupSH = GetObject("LDAP://CN=SHCtxBakara,OU=Citrix,OU=Groups,OU=MahozShosh,OU=Mehozot,DC=Domain,DC=Com")
Set objGroupTA = GetObject("LDAP://CN=TACtxBakara,OU=Citrix,OU=Groups,OU=MahozTayf,OU=Mehozot,DC=Domain,DC=Com")
Set objGroupZA = GetObject("LDAP://CN=ZACtxBakara,OU=Citrix,OU=Groups,OU=MahozZafon,OU=Mehozot,DC=Domain,DC=Com")

For Each oUser In objGroupDP.Members

If oUser.Class = "user" Then
      
Set objNet = WScript.CreateObject("WScript.Network")
Set FSO = CreateObject("scripting.filesystemobject")

sUserName = objNet.UserName
sDomainName= objNet.UserDomain

  If LCase(oUser.samAccountName) = LCase(sUserName) Then

      folderToCheckFor = "\\server\ShareName\danpt\home\" & sUserName

      If (FSO.FolderExists(folderToCheckFor)) = True Then

            objnet.mapnetworkdrive "w:","\\server\ShareName\danpt\home\" & sUserName
            WScript.Quit
      
      ElseIf (FSO.FolderExists(folderToCheckFor)) = False Then
                FSO.CreateFolder(folderToCheckFor)
                Set WshShell = WScript.CreateObject("WScript.Shell")
                Call WshShell.Run("CACLS " & folderToCheckFor & " /T /E /C /G " & sDomainName & "\" & sUserName & ":F",2,True)
            WScript.Sleep 2000
            objnet.mapnetworkdrive "w:","\\server\ShareName\danpt\home\" & sUserName
                Set WshShell = Nothing
            WScript.Quit      
      End If
      
      
  End If
Set FSO = Nothing
Set objNet = Nothing

End If
oUser.SetInfo
Set oUser = Nothing
Next

For Each oUser In objGroupDR.Members

If oUser.Class = "user" Then

Set objNet = WScript.CreateObject("WScript.Network")
Set FSO = CreateObject("scripting.filesystemobject")

sUserName = objNet.UserName
sDomainName= objNet.UserDomain

  If LCase(oUser.samAccountName) = LCase(sUserName) Then

      folderToCheckFor = "\\server\ShareName\darom\home\" & sUserName

      If (FSO.FolderExists(folderToCheckFor)) = True Then

            objnet.mapnetworkdrive "w:","\\server\ShareName\darom\home\" & sUserName
            WScript.Quit

      ElseIf (FSO.FolderExists(folderToCheckFor)) = False Then
                FSO.CreateFolder(folderToCheckFor)
                Set WshShell = WScript.CreateObject("WScript.Shell")
                Call WshShell.Run("CACLS " & folderToCheckFor & " /T /E /C /G " & sDomainName & "\" & sUserName & ":F",2,True)
            WScript.Sleep 2000
            objnet.mapnetworkdrive "w:","\\server\ShareName\darom\home\" & sUserName  
                Set WshShell = Nothing
            WScript.Quit      
      End If
      
      
  End If
Set FSO = Nothing
Set objNet = Nothing

End If
oUser.SetInfo
Set oUser = Nothing
Next


For Each oUser In objGroupHF.Members

If oUser.Class = "user" Then
      
Set objNet = WScript.CreateObject("WScript.Network")
Set FSO = CreateObject("scripting.filesystemobject")

sUserName = objNet.UserName
sDomainName= objNet.UserDomain

  If LCase(oUser.samAccountName) = LCase(sUserName) Then

      folderToCheckFor = "\\server\ShareName\haifa\home\" & sUserName

      If (FSO.FolderExists(folderToCheckFor)) = True Then
            
            objnet.mapnetworkdrive "w:","\\server\ShareName\haifa\home\" & sUserName
            WScript.Quit
 
      ElseIf (FSO.FolderExists(folderToCheckFor)) = False Then
                FSO.CreateFolder(folderToCheckFor)
                Set WshShell = WScript.CreateObject("WScript.Shell")
                Call WshShell.Run("CACLS " & folderToCheckFor & " /T /E /C /G " & sDomainName & "\" & sUserName & ":F",2,True)
            WScript.Sleep 2000
            objnet.mapnetworkdrive "w:","\\server\ShareName\haifa\home\" & sUserName  
                Set WshShell = Nothing
            WScript.Quit      
      End If
      
      
  End If
Set FSO = Nothing
Set objNet = Nothing
End If
oUser.SetInfo
Set oUser = Nothing
Next

For Each oUser In objGroupJR.Members

If oUser.Class = "user" Then

Set objNet = WScript.CreateObject("WScript.Network")
Set FSO = CreateObject("scripting.filesystemobject")

sUserName = objNet.UserName
sDomainName= objNet.UserDomain

  If LCase(oUser.samAccountName) = LCase(sUserName) Then

      folderToCheckFor = "\\server\ShareName\jerusalem\home\" & sUserName

      If (FSO.FolderExists(folderToCheckFor)) = True Then

            objnet.mapnetworkdrive "w:","\\server\ShareName\jerusalem\home\" & sUserName
            WScript.Quit
 
      ElseIf (FSO.FolderExists(folderToCheckFor)) = False Then
                FSO.CreateFolder(folderToCheckFor)
                Set WshShell = WScript.CreateObject("WScript.Shell")
                Call WshShell.Run("CACLS " & folderToCheckFor & " /T /E /C /G " & sDomainName & "\" & sUserName & ":F",2,True)
            WScript.Sleep 2000
            objnet.mapnetworkdrive "w:","\\server\ShareName\jerusalem\home\" & sUserName  
                Set WshShell = Nothing
            WScript.Quit      
      End If
      
      
  End If
Set FSO = Nothing
Set objNet = Nothing

End If
oUser.SetInfo
Set oUser = Nothing
Next

For Each oUser In objGroupMR.Members

If oUser.Class = "user" Then
      
Set objNet = WScript.CreateObject("WScript.Network")
Set FSO = CreateObject("scripting.filesystemobject")

sUserName = objNet.UserName
sDomainName= objNet.UserDomain

  If LCase(oUser.samAccountName) = LCase(sUserName) Then

      folderToCheckFor = "\\server\ShareName\merkaz\home\" & sUserName

      If (FSO.FolderExists(folderToCheckFor)) = True Then

            objnet.mapnetworkdrive "w:","\\server\ShareName\Merkaz\home\" & sUserName
            WScript.Quit
 
      ElseIf (FSO.FolderExists(folderToCheckFor)) = False Then
                FSO.CreateFolder(folderToCheckFor)
                Set WshShell = WScript.CreateObject("WScript.Shell")
                Call WshShell.Run("CACLS " & folderToCheckFor & " /T /E /C /G " & sDomainName & "\" & sUserName & ":F",2,True)
            WScript.Sleep 2000
            objnet.mapnetworkdrive "w:","\\server\ShareName\Merkaz\home\" & sUserName  
                Set WshShell = Nothing
            WScript.Quit      
      End If
      
      
  End If
Set FSO = Nothing
Set objNet = Nothing

End If
oUser.SetInfo
Set oUser = Nothing
Next

For Each oUser In objGroupSH.Members

If oUser.Class = "user" Then
      
Set objNet = WScript.CreateObject("WScript.Network")
Set FSO = CreateObject("scripting.filesystemobject")

sUserName = objNet.UserName
sDomainName= objNet.UserDomain

  If LCase(oUser.samAccountName) = LCase(sUserName) Then

      folderToCheckFor = "\\server\ShareName\shosh\home\" & sUserName

      If (FSO.FolderExists(folderToCheckFor)) = True Then

            objnet.mapnetworkdrive "w:","\\server\ShareName\shosh\home\" & sUserName
            WScript.Quit

      ElseIf (FSO.FolderExists(folderToCheckFor)) = False Then
                FSO.CreateFolder(folderToCheckFor)
                Set WshShell = WScript.CreateObject("WScript.Shell")
                Call WshShell.Run("CACLS " & folderToCheckFor & " /T /E /C /G " & sDomainName & "\" & sUserName & ":F",2,True)
            WScript.Sleep 2000
            objnet.mapnetworkdrive "w:","\\server\ShareName\shosh\home\" & sUserName  
                Set WshShell = Nothing
            WScript.Quit      
      End If
      
      
  End If
Set FSO = Nothing
Set objNet = Nothing

End If
oUser.SetInfo
Set oUser = Nothing
Next

For Each oUser In objGroupTA.Members

If oUser.Class = "user" Then
      
Set objNet = WScript.CreateObject("WScript.Network")
Set FSO = CreateObject("scripting.filesystemobject")

sUserName = objNet.UserName
sDomainName= objNet.UserDomain

  If LCase(oUser.samAccountName) = LCase(sUserName) Then

      folderToCheckFor = "\\server\ShareName\tayf\home\" & sUserName

      If (FSO.FolderExists(folderToCheckFor)) = True Then

            objnet.mapnetworkdrive "w:","\\server\ShareName\tayf\home\" & sUserName
            WScript.Quit
 
      ElseIf (FSO.FolderExists(folderToCheckFor)) = False Then
                FSO.CreateFolder(folderToCheckFor)
                Set WshShell = WScript.CreateObject("WScript.Shell")
                Call WshShell.Run("CACLS " & folderToCheckFor & " /T /E /C /G " & sDomainName & "\" & sUserName & ":F",2,True)
            WScript.Sleep 2000
            objnet.mapnetworkdrive "w:","\\server\ShareName\tayf\home\" & sUserName  
                Set WshShell = Nothing
            WScript.Quit      
      End If
      
      
  End If
Set FSO = Nothing
Set objNet = Nothing

End If
oUser.SetInfo
Set oUser = Nothing
Next

For Each oUser In objGroupZA.Members

If oUser.Class = "user" Then
      
Set objNet = WScript.CreateObject("WScript.Network")
Set FSO = CreateObject("scripting.filesystemobject")

sUserName = objNet.UserName
sDomainName= objNet.UserDomain

  If LCase(oUser.samAccountName) = LCase(sUserName) Then

      folderToCheckFor = "\\server\ShareName\zafon\home\" & sUserName

      If (FSO.FolderExists(folderToCheckFor)) = True Then

            objnet.mapnetworkdrive "w:","\\server\ShareName\zafon\home\" & sUserName
            WScript.Quit
 
      ElseIf (FSO.FolderExists(folderToCheckFor)) = False Then
                FSO.CreateFolder(folderToCheckFor)
                Set WshShell = WScript.CreateObject("WScript.Shell")
                Call WshShell.Run("CACLS " & folderToCheckFor & " /T /E /C /G " & sDomainName & "\" & sUserName & ":F",2,True)
            WScript.Sleep 2000
            objnet.mapnetworkdrive "w:","\\server\ShareName\zafon\home\" & sUserName  
                Set WshShell = Nothing
            WScript.Quit      
      End If
      
  End If
Set FSO = Nothing
Set objNet = Nothing

End If
oUser.SetInfo
Set oUser = Nothing
Next

WScript.Quit
Visual Basic ClassicVB Script
Avatar of undefined
Last Comment
AmazingTech
8/22/2022 - Mon
mraluminumsiding
I might have screwed up the nesting of some of the operations you're doing for each group, but you get the idea: put the group names in an external file and read them one by one, so you're only getting one group object at a time.

On the other hand, if you want to apply this change to all groups, you can skip making a list and use a recursive function to crawl through all the groups. 

Set objNet = WScript.CreateObject("WScript.Network")
Set FSO = CreateObject("scripting.filesystemobject")
Set objGroupNamesFile = FSO.OpenTextFile("yourfile.txt", 1)
 
sUserName = objNet.UserName
sDomainName= objNet.UserDomain
 
Do While Not objGroupNamesFile.AtEndOfStream
	Set objGroup = GetObject("LDAP://" & objGroupNamesFile.ReadLine)
 
		For Each oUser In objGroup.Members
	
		If oUser.Class = "user" Then
	      	
			If LCase(oUser.samAccountName) = LCase(sUserName) Then
				folderToCheckFor = "\\server\ShareName\danpt\home\" & sUserName
				If (FSO.FolderExists(folderToCheckFor)) = True Then
					objnet.mapnetworkdrive "w:","\\server\ShareName\danpt\home\" & sUserName
					WScript.Quit
				ElseIf (FSO.FolderExists(folderToCheckFor)) = False Then
					FSO.CreateFolder(folderToCheckFor)
					Set WshShell = WScript.CreateObject("WScript.Shell")
					Call WshShell.Run("CACLS " & folderToCheckFor & " /T /E /C /G " & sDomainName & "\" & sUserName & ":F",2,True)
					WScript.Sleep 2000
					objnet.mapnetworkdrive "w:","\\server\ShareName\danpt\home\" & sUserName
					Set WshShell = Nothing
					WScript.Quit   
				End If   
			End If
	      
		End If
		oUser.SetInfo
		Set oUser = Nothing
		Set objGroup = Nothing
	Next
Loop

Open in new window

dudure
ASKER
Hi , i meen i want to convert the "for each" to " if then " like if you are member in GROUP create a folder with full premession and map it . i have other script that only map i want to add the option to create a folder for user if he dont have one and if he have only map it .
like this script :


Option Explicit
Dim objNetwork, objUser, CurrentUser  
Dim strGroup


Const DPCtxBakara_Group = "cn=DPCtxBakara"
Const DRCtxBakara_Group = "cn=DRCtxBakara"
Const HFCtxBakara_Group = "cn=HFCtxBakara"
Const JRCtxBakara_Group = "cn=JRCtxBakara"
Const MRCtxBakara_Group = "cn=MRCtxBakara"
Const SHCtxBakara_Group = "cn=SHCtxBakara"
Const TACtxBakara_Group = "cn=TACtxBakara"
Const ZACtxBakara_Group = "cn=ZACtxBakara"


Set objNetworkwork = CreateObject("WScript.Network")
Set objUser = CreateObject("ADSystemInfo")
Set CurrentUser = GetObject("LDAP://" & objUser.UserName)
strGroup = LCase(Join(CurrentUser.MemberOf))

If InStr(strGroup, lcase(DpCtxBakara_Group)) Then
WScript.Echo "DPCtxBakara "
objNetwork.MapNetworkDrive "w:", "\\Servername\dfs$\citrix\danpt\home\" _
& objNetwork.UserName


ElseIf InStr(strGroup, lcase(DRCtxBakara_Group)) Then
WScript.Echo "DPCtxBakara "
objNetwork.MapNetworkDrive "w:", "\\Servername\dfs$\citrix\darom\home\" _
& objNetwork.UserName

ElseIf InStr(strGroup, lcase(HFCtxBakara_Group)) Then
WScript.Echo " HFCtxBakara " 
objNetwork.MapNetworkDrive "w:", "\\Servername\dfs$\citrix\haifa\home\"_
& objNetwork.UserName

ElseIf InStr(strGroup, lcase(JRCtxBakara_Group)) Then
WScript.Echo " JRCtxBakara " 
objNetwork.MapNetworkDrive "w:", "\\Servername\dfs$\citrix\jerusalem\home\"_
& objNetwork.UserName

ElseIf InStr(strGroup, lcase(MRCtxBakara_Group)) Then
WScript.Echo " MRCtxBakara " 
objNetwork.MapNetworkDrive "w:", "\\Servername\dfs$\citrix\merkaz\home\"_
& objNetwork.UserName

ElseIf InStr(strGroup, lcase(SHCtxBakara_Group)) Then
WScript.Echo " SHCtxBakara " 
objNetwork.MapNetworkDrive "w:", "\\Servername\dfs$\citrix\shosh\home\"_
& objNetwork.UserName

ElseIf InStr(strGroup, lcase(TACtxBakara_Group)) Then
WScript.Echo " TACtxBakara " 
objNetwork.MapNetworkDrive "w:", "\\Servername\dfs$\citrix\tayf\home\"_
& objNetwork.UserName

ElseIf InStr(strGroup, lcase(ZACtxBakara_Group)) Then
WScript.Echo " ZACtxBakara " 
objNetwork.MapNetworkDrive "w:", "\\Servername\dfs$\citrix\zafon\home\"_
& objNetwork.UserName


End If
Wscript.Echo "Finished mapping Groups - check drives "
WScript.Quit





ASKER CERTIFIED SOLUTION
AmazingTech
THIS SOLUTION ONLY AVAILABLE TO MEMBERS.
View this solution by signing up for a free trial.
Members can start a 7-Day free trial and enjoy unlimited access to the platform.
See Pricing Options
Start Free Trial
GET A PERSONALIZED SOLUTION
Ask your own question & get feedback from real experts
Find out why thousands trust the EE community with their toughest problems.
AmazingTech
Sorry I missed changing the Dim lines I missed seeing Option Explicit

Dim objNetwork, objUser, CurrentUser, objFSO, WshShell
Dim strGroup, UserFolder
I started with Experts Exchange in 2004 and it's been a mainstay of my professional computing life since. It helped me launch a career as a programmer / Oracle data analyst
William Peck
Plans and Pricing
Resources
Product
Podcasts
Careers
Contact Us
Teams
Certified Expert Program
Credly Partnership
Udemy Partnership
Privacy Policy
Terms of Use

© 1996-2023 Experts Exchange, LLC. All rights reserved. Covered by US Patent