Get Desktop Icon Text and Position

Hi marcodalzotto,

try to pass 'title' instead of '&title' to 'ReadProcessMemory' - a 'char title[256]' already is a pointer to a 256 byte buffer, &title is a pointer to this pointer, not to the buffer ...

If this doesn't help please show how DesktopIcon is declared.

Hope that helps,

ZOPPO

Thanks ZOPPO, but it is not the solution.

You can try the code, you will see that exporer.exe crashes when the program execure mydesktop.GetItemText.
The thing is that ptPoint is red correctly.

I already tried to use SendMessage with LVM_GETITEMTEXT but doesn't return the title of the item.

typedef struct {
	char title[256];
	POINT	pt;
	RECT  rect;
} DESKTOPICON;
 
void CDskSaverDlg::OnBnClickedSave()
{
  CListCtrl mydesktop;
 
  DESKTOPICON DesktopIcon;
  HANDLE hProcess = 0;
  POINT *ptPoint = 0;
  char  *ptTitle = 0;
  DWORD wndThreadID;
  DWORD pID;
  int i, count;
 
  HWND main    = ::FindWindow("Progman", NULL);
  HWND defView = ::FindWindowEx(main, NULL, "SHELLDLL_DefView", NULL);
  HWND list    = ::FindWindowEx(defView, NULL, "SysListView32", NULL);
  wndThreadID = ::GetWindowThreadProcessId(main, &pID);
 
  // Alloc memory to the process of SysListView32 window
  hProcess = OpenProcess(PROCESS_VM_OPERATION | PROCESS_VM_READ | PROCESS_VM_WRITE, FALSE, pID);
  ptTitle = (char  *)VirtualAllocEx(hProcess, NULL, sizeof(DesktopIcon.title), MEM_RESERVE | MEM_COMMIT, PAGE_EXECUTE_READWRITE);
  ptPoint = (POINT *)VirtualAllocEx(hProcess, NULL, sizeof(POINT), MEM_RESERVE | MEM_COMMIT, PAGE_EXECUTE_READWRITE);
 
//  FILE *file;
//	file = fopen("icone.bin", "w+");
//	if(file == NULL) ::MessageBox(main, "Impossibile aprire il file.", "DLL", MB_OK);
 
  // attach the list hwnd to the ListCtrl
  mydesktop.Attach(list);
 
  count = mydesktop.GetItemCount();
  for(i = 0; i < count; i++) {
    mydesktop.GetItemPosition(i, ptPoint);
    ReadProcessMemory(hProcess, ptPoint, &DesktopIcon.pt, sizeof(POINT), NULL);
 
    mydesktop.GetItemText(i, 0, ptTitle, sizeof(DesktopIcon.title)-1); // explorer crashes
    ReadProcessMemory(hProcess, ptTitle, DesktopIcon.title, sizeof(DesktopIcon.title), NULL);
 
//    fwrite(&DesktopIcon, sizeof(char), sizeof(DESKTOPICON), file);
  }
  mydesktop.Detach();
 
  // Free memory
  VirtualFreeEx(hProcess, ptTitle, sizeof(DesktopIcon.title), MEM_RELEASE);
  VirtualFreeEx(hProcess, ptPoint, sizeof(POINT), MEM_RELEASE);
  CloseHandle(hProcess);
//	fclose(file);
 
//	::MessageBox(main, "Icone salvate.", "DZIconSave", MB_OK);
}

Select allOpen in new window

Zoppo, thank you for trying. I made a similar try yesterday with the same resuts.

I made another project that use a Hook to a DLL function to achieve the same results... and i it works fine, except that I need to generate a keyboard event to the desktop so the Hook with WH_KEYBOARD can call my function. Right now to save the icons I have to focus manually the desktop and press a key.

Maybe you or somebody else can help me on that too:
https://www.experts-exchange.com/questions/23581079/Send-VK-to-desktop.html

PS: If the experts of experts-exchange cannot help me to solve this questions... I don't know who can!

marcodalzotto

Hi again,

sorry, no idea about the other question - maybe you should use another kind of hook, i.e. a WH_GETMESSAGE which should be called with every message that's handled by the process ...

ZOPPO

May be the desktop listcrl is a virtual list? In that case the icon text isn't stored in the control.
If it is the case, i think that the text should be sending an LVN_GETDISPINFO notification message to the control's parent window.