Solved

Transaction Rollback not working using TableAdapters

Posted on 2008-09-29
2
1,842 Views
Last Modified: 2013-12-17
I'm attempting to use Transactions while using TableAdapters.  I created partial classes for each of my table adapters from some code I found online.  I'd rather not use Transaction Scopes since I read it's inefficient. My code snippets contain the partial classes I created as well as my code to implement the transactions.

I'm noticing that when an exception occurs, insert statements are still committing.

Any thoughts?
****** PARTIAL CLASSES ********
    partial class PASSWORDSTableAdapter
    {
        private OracleTransaction _transaction;
        public OracleTransaction Transaction
        {
            get { return _transaction; }
            set
            {
                _transaction = value;
                _connection = _transaction.Connection;
 
                if (_adapter == null)
                    this.InitAdapter();
 
                foreach (OracleCommand command in this.CommandCollection)
                {
                    command.Transaction = _transaction;
                }
 
                this.Adapter.InsertCommand.Transaction = _transaction;
                this.Adapter.UpdateCommand.Transaction = _transaction;
                this.Adapter.DeleteCommand.Transaction = _transaction;
            }
        }
    }
 
    partial class ACCOUNT_PASSWORDSTableAdapter
    {
        private OracleTransaction _transaction;
        public OracleTransaction Transaction
        {
            get { return _transaction; }
            set
            {
                _transaction = value;
                _connection = _transaction.Connection;
 
                if (_adapter == null)
                    this.InitAdapter();
 
                foreach (OracleCommand command in this.CommandCollection)
                {
                    command.Transaction = _transaction;
                }
 
                this.Adapter.InsertCommand.Transaction = _transaction;
 
            }
        }
    }
 
****** TRANSACTION CODE ********
        PASSWORDSTableAdapter ta1 = new PASSWORDSTableAdapter();
        ACCOUNT_PASSWORDSTableAdapter ta2 = new ACCOUNT_PASSWORDSTableAdapter();
        OracleTransaction dbTransaction = null;
        OracleConnection taConn = new OracleConnection(ConfigurationManager.ConnectionStrings["ConnectionString"].ConnectionString);
 
        try
        {
            taConn.Open();
            dbTransaction = taConn.BeginTransaction();
            ta1.Transaction = dbTransaction;
            ta2.Transaction = dbTransaction;
 
            // insert password
            ta1.Insert(0, txtPassword.Text.ToString(), ddGlobal.SelectedValue.ToString());
 
            // encrypt/store password password
            using (OracleCommand cmd2 = new OracleCommand("security.encrypt_password",
                dbTransaction.Connection, dbTransaction))
            {
                cmd2.CommandType = CommandType.StoredProcedure;
                cmd2.Parameters.Add("key_in", OracleType.VarChar).Value = txtEncryptionKey.Text.ToString();
                cmd2.Parameters.Add("p_password_id", OracleType.Number).Value = myNewPasswordID;
                cmd2.ExecuteNonQuery();
            }
 
            // store system id, account id and password id in related table
            ta2.Insert(decimal.Parse(ddSystems.SelectedValue.ToString()), decimal.Parse(ddAccounts.SelectedValue.ToString()), myNewPasswordID);
 
            dbTransaction.Commit();
        }
 
        catch (Exception ex)
        {
            dbTransaction.Rollback();
            lblExceptionDetails.Visible = true;
            lblExceptionDetails.Text = "There was a problem inserting the password. ";
        }
        finally
        {
            if (dbTransaction != null) dbTransaction.Dispose();
            ta1.Dispose();
            ta2.Dispose();
        }

Open in new window

0
Comment
Question by:peerlesslv
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
2 Comments
 

Author Comment

by:peerlesslv
ID: 22601939
Is there anybody out there?
0
 

Accepted Solution

by:
peerlesslv earned 0 total points
ID: 22664689
It turns out it's the Stored Procedure that I call that wasn't being Rolled Back.  There was a commit statement in the Stored Procedure which obviously made it impossible to Roll it Back.  
0

Featured Post

Free Tool: Site Down Detector

Helpful to verify reports of your own downtime, or to double check a downed website you are trying to access.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

This document covers how to connect to SQL Server and browse its contents.  It is meant for those new to Visual Studio and/or working with Microsoft SQL Server.  It is not a guide to building SQL Server database connections in your code.  This is mo…
A long time ago (May 2011), I have written an article showing you how to create a DLL using Visual Studio 2005 to be hosted in SQL Server 2005. That was valid at that time and it is still valid if you are still using these versions. You can still re…
This video shows how to use Hyena, from SystemTools Software, to update 100 user accounts from an external text file. View in 1080p for best video quality.

739 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question