Solved

Transaction Rollback not working using TableAdapters

Posted on 2008-09-29
2
1,831 Views
Last Modified: 2013-12-17
I'm attempting to use Transactions while using TableAdapters.  I created partial classes for each of my table adapters from some code I found online.  I'd rather not use Transaction Scopes since I read it's inefficient. My code snippets contain the partial classes I created as well as my code to implement the transactions.

I'm noticing that when an exception occurs, insert statements are still committing.

Any thoughts?
****** PARTIAL CLASSES ********

    partial class PASSWORDSTableAdapter

    {

        private OracleTransaction _transaction;

        public OracleTransaction Transaction

        {

            get { return _transaction; }

            set

            {

                _transaction = value;

                _connection = _transaction.Connection;

 

                if (_adapter == null)

                    this.InitAdapter();

 

                foreach (OracleCommand command in this.CommandCollection)

                {

                    command.Transaction = _transaction;

                }

 

                this.Adapter.InsertCommand.Transaction = _transaction;

                this.Adapter.UpdateCommand.Transaction = _transaction;

                this.Adapter.DeleteCommand.Transaction = _transaction;

            }

        }

    }

 

    partial class ACCOUNT_PASSWORDSTableAdapter

    {

        private OracleTransaction _transaction;

        public OracleTransaction Transaction

        {

            get { return _transaction; }

            set

            {

                _transaction = value;

                _connection = _transaction.Connection;

 

                if (_adapter == null)

                    this.InitAdapter();

 

                foreach (OracleCommand command in this.CommandCollection)

                {

                    command.Transaction = _transaction;

                }

 

                this.Adapter.InsertCommand.Transaction = _transaction;

 

            }

        }

    }

 

****** TRANSACTION CODE ********

        PASSWORDSTableAdapter ta1 = new PASSWORDSTableAdapter();

        ACCOUNT_PASSWORDSTableAdapter ta2 = new ACCOUNT_PASSWORDSTableAdapter();

        OracleTransaction dbTransaction = null;

        OracleConnection taConn = new OracleConnection(ConfigurationManager.ConnectionStrings["ConnectionString"].ConnectionString);

 

        try

        {

            taConn.Open();

            dbTransaction = taConn.BeginTransaction();

            ta1.Transaction = dbTransaction;

            ta2.Transaction = dbTransaction;
 

            // insert password

            ta1.Insert(0, txtPassword.Text.ToString(), ddGlobal.SelectedValue.ToString());
 

            // encrypt/store password password

            using (OracleCommand cmd2 = new OracleCommand("security.encrypt_password",

                dbTransaction.Connection, dbTransaction))

            {

                cmd2.CommandType = CommandType.StoredProcedure;

                cmd2.Parameters.Add("key_in", OracleType.VarChar).Value = txtEncryptionKey.Text.ToString();

                cmd2.Parameters.Add("p_password_id", OracleType.Number).Value = myNewPasswordID;

                cmd2.ExecuteNonQuery();

            }

 

            // store system id, account id and password id in related table

            ta2.Insert(decimal.Parse(ddSystems.SelectedValue.ToString()), decimal.Parse(ddAccounts.SelectedValue.ToString()), myNewPasswordID);

 

            dbTransaction.Commit();

        }

 

        catch (Exception ex)

        {

            dbTransaction.Rollback();

            lblExceptionDetails.Visible = true;

            lblExceptionDetails.Text = "There was a problem inserting the password. ";

        }

        finally

        {

            if (dbTransaction != null) dbTransaction.Dispose();

            ta1.Dispose();

            ta2.Dispose();

        }

Open in new window

0
Comment
Question by:peerlesslv
  • 2
2 Comments
 

Author Comment

by:peerlesslv
ID: 22601939
Is there anybody out there?
0
 

Accepted Solution

by:
peerlesslv earned 0 total points
ID: 22664689
It turns out it's the Stored Procedure that I call that wasn't being Rolled Back.  There was a commit statement in the Stored Procedure which obviously made it impossible to Roll it Back.  
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Today I had a very interesting conundrum that had to get solved quickly. Needless to say, it wasn't resolved quickly because when we needed it we were very rushed, but as soon as the conference call was over and I took a step back I saw the correct …
This article shows how to deploy dynamic backgrounds to computers depending on the aspect ratio of display
Sending a Secure fax is easy with eFax Corporate (http://www.enterprise.efax.com). First, just open a new email message. In the To field, type your recipient's fax number @efaxsend.com. You can even send a secure international fax — just include t…
Both in life and business – not all partnerships are created equal. As the demand for cloud services increases, so do the number of self-proclaimed cloud partners. Asking the right questions up front in the partnership, will enable both parties …

863 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

23 Experts available now in Live!

Get 1:1 Help Now