• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 7444
  • Last Modified:

Vbscript fso copy file not returning an error code

I have the following snipit of cod ethat copy a file.

However, when the copy fails I do not get an error return? Shouldn't this code snippit see an error?
I am setting "on error resume next, so it should continue when there is an error


Err.Clear
fso.CopyFile file, destPath,True            
If Err.Number <> 0 Then
processExitError "attemp to copy file failed " &  Chr(34) & file  & Chr(34) & "failed with error code " & Err.Description & "," & Err.Number
WScript.Quit(-1)                        
End If
Function copyFileButStripLeadingNumberFromSource(file, destPath)
	On Error Resume next
		If Len(file.name) > 3 Then
			header = Left(file.name, 2)			
			If IsNumeric(header) And Left(file.name, 3) = (header&"-") Then
				nameWIthPreceedingNumberRemoved = Right(file.name, Len(file.name) - 3)
				'search backwards for the first directory marker in the path 
				index = InStrRev(destpath, "\")
				If index = 0 Then			'no directory marker
					destpath = Replace(destpath, nameWIthPreceedingNumberRemoved)
				Else
					destpath = Left(destpath, index)
					destpath = destpath & nameWIthPreceedingNumberRemoved 
				End If
			End If
		End If
		copyFileButStripLeadingNumberFromSource= destPath
	    EchoAndLog "copy " &  file & " to " &  destPath
	    Err.Clear
		fso.CopyFile file, destPath,True		
		EchoAndLog "returnCode = " & Err.Description
		If Err.Number <> 0 Then
			processExitError "attemp to copy file failed " &  Chr(34) & file  & Chr(34) & "failed with error code " & Err.Description & "," & Err.Number 
			WScript.Quit(-1)				
		End If
		
End Function

Open in new window

0
Christopher Schene
Asked:
Christopher Schene
  • 3
  • 3
  • 2
1 Solution
 
zoofanCommented:
Where/what is the code for this function?  "processExitError"


zf
0
 
zoofanCommented:
Or simply bypass that function with




zf
               If Err.Number <> 0 Then
                        'processExitError "attemp to copy file failed " &  Chr(34) & file  & Chr(34) & "failed with error code " & Err.Description & "," & Err.Number 
                         MsgBox Err.Number & " " & Err.Description & " " & Err.Source
                         WScript.Quit(-1)                                
                End If

Open in new window

0
 
Christopher ScheneSystem Engineer/Software EngineerAuthor Commented:
That is not my problem, my problem is the the "err" object is not returning an error even when I know the copy has failed.
0
Cloud Class® Course: CompTIA Cloud+

The CompTIA Cloud+ Basic training course will teach you about cloud concepts and models, data storage, networking, and network infrastructure.

 
lodar123Commented:
well i tried a quick run at it and when i get an error (for example the file do not exist, i get the err description.
your copyfile statement needs to be in brackets...... remove your on error resume next and it will give you a syntax error

This works....
On Error Resume Next
fso.CopyFile(file1, destination,True)
MsgBox Err.description 
 
This gives a Syntax error...
fso.CopyFile file1, destination, True   <---- no bracket = not good
MsgBox Err.description 

Open in new window

0
 
lodar123Commented:
Did you get it to work properly?
0
 
Christopher ScheneSystem Engineer/Software EngineerAuthor Commented:
I think my problem may be that when in notepad, I don't get an error when I copy over the file.

let me try making the file read only and see whether that causes an error.
0
 
lodar123Commented:
just make sure when you call fso.CopyFile(file1, destination,True) it as the brackets...or you get an syntax error... having on error resume next then this will be skipped and never get a return code
0
 
Christopher ScheneSystem Engineer/Software EngineerAuthor Commented:
works....my real problem was that I thought that opening a file with note pad would prevent it from being overwritten. Instead I write protected the file and and the error was detected.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Cloud Class® Course: CompTIA Healthcare IT Tech

This course will help prep you to earn the CompTIA Healthcare IT Technician certification showing that you have the knowledge and skills needed to succeed in installing, managing, and troubleshooting IT systems in medical and clinical settings.

  • 3
  • 3
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now