Solved

__Construct says it is missing an argument, but I passed it -- i swear!

Posted on 2008-09-30
5
2,228 Views
Last Modified: 2012-05-05
Executing the code below gives me this error:

Warning: Missing argument 1 for maccfg::__construct(), called in /var/www/provision/show-prov.php on line 31 and defined in /var/www/provision/maccfg.class.php on line 12

How to fix?
include('maccfg.class.php');
	
	//Loop throught he directory for config files that relate to phones.
	if($handle = opendir('/srv/tftp'))
	{
		while (false !== ($file = readdir($handle)))
		{
			//Check to see if it is a config file
			$pattern = "/^[a-fA-F0-9]{12}\.cfg/";
			//echo $file;
			if(preg_match($pattern,$file) && $file !== '000000000000.cfg')
			{
				echo "Found config file: " . $file. '<br>';
				$mc = new maccfg($file);
			}
		}
 
===============maccfg.class.php=========================
class maccfg
{
	public $path = '';
	public $mac = '';	
	
	public function __construct($f)
	{
		$this->path ='/srv/tftp/'.$f;
		$this->mac = substr($f,1,12);
		echo $this-mac;
	}

Open in new window

0
Comment
Question by:DrDamnit
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
  • 2
5 Comments
 
LVL 17

Expert Comment

by:psimation
ID: 22605310
maybe it's the typo on line 28?

echo $this-mac; should be echo $this->mac;?
0
 
LVL 32

Author Comment

by:DrDamnit
ID: 22605672
apparently also an error....fixed, but didn't solve the problem.
0
 
LVL 17

Expert Comment

by:psimation
ID: 22605810
Also looks like you are short one terminating } for your If statement starting on line 4.

What is the error you are getting now - maybe also just report your corrected code.
0
 
LVL 32

Author Comment

by:DrDamnit
ID: 22617638
That's because you only have relevent sections of the code. it is not missing a closing '}'.

Here's the full code:
class maccfg
{
	public $path = '';
	public $mac = '';	
	
	public function __construct($f)
	{
		$this->path ='/srv/tftp/'.$f;
		$this->mac = substr($f,1,12);
		echo $this->mac;
	}
	function get_configs()
	{
		//Use parse mac.cfg to find the config files for this phone.
		$dom = new DOMDocument();
		if(!$xml  = $dom->load($this->path))
		{
			echo "Error while parsing the document!\n";
			exit;
		}
		$de = $dom->documentElement;
		return $de->getattribute('CONFIG_FILES');
	}
 
}

Open in new window

0
 
LVL 21

Accepted Solution

by:
nizsmo earned 500 total points
ID: 22756316
try replacing:
public function __construct($f)

with:
public function __construct($f=null)

and see if the notice goes away.
0

Featured Post

Free Tool: ZipGrep

ZipGrep is a utility that can list and search zip (.war, .ear, .jar, etc) archives for text patterns, without the need to extract the archive's contents.

One of a set of tools we're offering as a way to say thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Popularity Can Be Measured Sometimes we deal with questions of popularity, and we need a way to collect opinions from our clients.  This article shows a simple teaching example of how we might elect a favorite color by letting our clients vote for …
Generating table dynamically is the most common issue faced by php developers.... So it seems there is a need of an article that explains the basic concept of generating tables dynamically. It just requires a basic knowledge of html and little maths…
The viewer will learn how to count occurrences of each item in an array.
This tutorial will teach you the core code needed to finalize the addition of a watermark to your image. The viewer will use a small PHP class to learn and create a watermark.

724 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question