?
Solved

__Construct says it is missing an argument, but I passed it -- i swear!

Posted on 2008-09-30
5
Medium Priority
?
2,250 Views
Last Modified: 2012-05-05
Executing the code below gives me this error:

Warning: Missing argument 1 for maccfg::__construct(), called in /var/www/provision/show-prov.php on line 31 and defined in /var/www/provision/maccfg.class.php on line 12

How to fix?
include('maccfg.class.php');
	
	//Loop throught he directory for config files that relate to phones.
	if($handle = opendir('/srv/tftp'))
	{
		while (false !== ($file = readdir($handle)))
		{
			//Check to see if it is a config file
			$pattern = "/^[a-fA-F0-9]{12}\.cfg/";
			//echo $file;
			if(preg_match($pattern,$file) && $file !== '000000000000.cfg')
			{
				echo "Found config file: " . $file. '<br>';
				$mc = new maccfg($file);
			}
		}
 
===============maccfg.class.php=========================
class maccfg
{
	public $path = '';
	public $mac = '';	
	
	public function __construct($f)
	{
		$this->path ='/srv/tftp/'.$f;
		$this->mac = substr($f,1,12);
		echo $this-mac;
	}

Open in new window

0
Comment
Question by:DrDamnit
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
  • 2
5 Comments
 
LVL 17

Expert Comment

by:psimation
ID: 22605310
maybe it's the typo on line 28?

echo $this-mac; should be echo $this->mac;?
0
 
LVL 32

Author Comment

by:DrDamnit
ID: 22605672
apparently also an error....fixed, but didn't solve the problem.
0
 
LVL 17

Expert Comment

by:psimation
ID: 22605810
Also looks like you are short one terminating } for your If statement starting on line 4.

What is the error you are getting now - maybe also just report your corrected code.
0
 
LVL 32

Author Comment

by:DrDamnit
ID: 22617638
That's because you only have relevent sections of the code. it is not missing a closing '}'.

Here's the full code:
class maccfg
{
	public $path = '';
	public $mac = '';	
	
	public function __construct($f)
	{
		$this->path ='/srv/tftp/'.$f;
		$this->mac = substr($f,1,12);
		echo $this->mac;
	}
	function get_configs()
	{
		//Use parse mac.cfg to find the config files for this phone.
		$dom = new DOMDocument();
		if(!$xml  = $dom->load($this->path))
		{
			echo "Error while parsing the document!\n";
			exit;
		}
		$de = $dom->documentElement;
		return $de->getattribute('CONFIG_FILES');
	}
 
}

Open in new window

0
 
LVL 21

Accepted Solution

by:
nizsmo earned 2000 total points
ID: 22756316
try replacing:
public function __construct($f)

with:
public function __construct($f=null)

and see if the notice goes away.
0

Featured Post

New feature and membership benefit!

New feature! Upgrade and increase expert visibility of your issues with Priority Questions.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

I imagine that there are some, like me, who require a way of getting currency exchange rates for implementation in web project from time to time, so I thought I would share a solution that I have developed for this purpose. It turns out that Yaho…
Things That Drive Us Nuts Have you noticed the use of the reCaptcha feature at EE and other web sites?  It wants you to read and retype something that looks like this. Insanity!  It's not EE's fault - that's just the way reCaptcha works.  But it i…
Learn how to match and substitute tagged data using PHP regular expressions. Demonstrated on Windows 7, but also applies to other operating systems. Demonstrated technique applies to PHP (all versions) and Firefox, but very similar techniques will w…
The viewer will learn how to create a basic form using some HTML5 and PHP for later processing. Set up your basic HTML file. Open your form tag and set the method and action attributes.: (CODE) Set up your first few inputs one for the name and …
Suggested Courses

770 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question