Solved

"generic error" Problem uploading image, code should work...

Posted on 2008-09-30
5
473 Views
Last Modified: 2013-12-25
I am trying to get a form where users can upload an image and it will be resized and saved.  I have found several code examples online and this one seems very nice and self-contained, and works on the demo page.

However upon implmenting it in my project I get the error

System.Runtime.InteropServices.ExternalException: A generic error occurred in GDI+.

(i commented out the try/catch in order to find which line has the error).

This error fires for lines

originalImg.save(Server.MapPath(upload_dir & upload_original & fileExt), originalImg.rawformat)

and

thumb.save(Server.MapPath(upload_dir & upload_thumb & fileExt), originalImg.rawformat)

I have permissions on the save folder set for everyone, and the folder is created in the same directory the ASPX file is stored in.

Anyone able to suss out the error here?

Thank you!

<%@ Page Trace="False" Language="vb" aspcompat="false" debug="true" validateRequest="false"%> 

<%@ Import Namespace=System.Drawing %>

<%@ Import Namespace=System.Drawing.Imaging %>

<%@ Import Namespace=System %>

<%@ Import Namespace=System.Web %>

<SCRIPT LANGUAGE="VBScript" runat="server">

const Lx = 200	' max width for thumbnails

const Ly = 240	' max height for thumbnails

const upload_dir = "/userImages/"	' directory to upload file

const upload_original = "sample"	' filename to save original as (suffix added by script)

const upload_thumb = "thumb"	' filename to save thumbnail as (suffix added by script)

const upload_max_size = 25	' max size of the upload (KB) note: this doesn't override any server upload limits

dim fileExt	' used to store the file extension (saves finding it mulitple times)

dim newWidth, newHeight as integer ' new width/height for the thumbnail

dim l2	' temp variable used when calculating new size

dim fileFld as HTTPPostedFile	' used to grab the file upload from the form

Dim originalimg As System.Drawing.Image	' used to hold the original image

dim msg	' display results

dim upload_ok as boolean	' did the upload work ?

</script>

<%
 
 

randomize() ' used to help the cache-busting on the preview images

upload_ok = false

if lcase(Request.ServerVariables("REQUEST_METHOD"))="post" then

	fileFld = request.files(0)	' get the first file uploaded from the form (note:- you can use this to itterate through more than one image)

	if fileFld.ContentLength > upload_max_size * 1024 then

		msg = "Sorry, the image must be less than " & upload_max_size & "Kb"

	else

	'	try

			originalImg = System.Drawing.Image.FromStream(fileFld.InputStream)

			' work out the width/height for the thumbnail. Preserve aspect ratio and honour max width/height

			' Note: if the original is smaller than the thumbnail size it will be scaled up

			If (originalImg.Width/Lx) > (originalImg.Width/Ly) Then

				L2 = originalImg.Width

				newWidth = Lx

				newHeight = originalImg.Height * (Lx / L2)

				if newHeight > Ly then

					newWidth = newWidth * (Ly / newHeight)

					newHeight = Ly

				end if

			Else

				L2 = originalImg.Height

				newHeight = Ly

				newWidth = originalImg.Width * (Ly / L2)

				if newWidth > Lx then

					newHeight = newHeight * (Lx / newWidth)

					newWidth = Lx

				end if

			End If
 

            Dim thumb As New Bitmap(newWidth, newHeight)
 

            'Create a graphics object           

            Dim gr_dest As Graphics = Graphics.FromImage(thumb)
 

			' just in case it's a transparent GIF force the bg to white 

			dim sb = new SolidBrush(System.Drawing.Color.White)

			gr_dest.FillRectangle(sb, 0, 0, thumb.Width, thumb.Height)
 

            'Re-draw the image to the specified height and width

			gr_dest.DrawImage(originalImg, 0, 0, thumb.Width, thumb.Height)
 

	'		try

				fileExt = System.IO.Path.GetExtension(fileFld.FileName).ToLower()

				originalImg.save(Server.MapPath(upload_dir & upload_original & fileExt), originalImg.rawformat)

				'thumb.save(Server.MapPath(upload_dir & upload_thumb & fileExt), originalImg.rawformat)

				response.write(upload_dir & upload_original & fileExt)

				msg = "Uploaded " & fileFld.FileName & " to " & Server.MapPath(upload_dir & upload_original & fileExt)

				upload_ok = true

	'		catch

	'			msg = "Sorry, there was a problem saving the image."

	'		end try

			' Housekeeping for the generated thumbnail

			if not thumb is nothing then

				thumb.Dispose()

				thumb = nothing

			end if

	'	catch

	'		msg = "Sorry, that was not an image we could process."

	'	end try

	end if
 

	' House Keeping !

	if not originalImg is nothing then

		originalImg.Dispose()

		originalImg = nothing

	end if
 

end if

%>

<html>

<head>

<title>ASP.NET File Upload and Resize Sample</title>

<META NAME="Description" CONTENT="ASP.NET File Upload and Resize Sample (Hybrid VB.NET)">

<META NAME="Keywords" CONTENT="ASP.NET, ASP, NET, VB, VBScript, Image, Upload, Resize, Thumbnail, Constrain, Filesize, File, Size, Free">

<META NAME="Copyright" CONTENT="Rufan-Redi Pty Ltd 2005">

<META NAME="Author" CONTENT="System developed by Jeremy at http://www.Rufan-Redi.com">

</head>

<body>
 

<p><b>Hybrid ASP.NET File Upload and Resize Sample (VB.NET)</b>

<br>Upload and resize a GIP/JPG/PNG images, ensuring filesizes are optimum.</p>
 

<form enctype="multipart/form-data" method="post" runat="server">

<table>

<tr><td>Select the file to upload:</td><td><input type="file" name="upload_file"></td></tr>

<tr><td colspan=2>Max upload size <%=upload_max_size%>Kb, gif/jpg/png only</td></tr>

<tr><td colspan=2><input type="submit" value="Upload"></td></tr>

</table>

</form>
 

<%

if upload_ok then

%>

<table>

<tr>

<td valign=top><img src="<%=upload_dir & upload_original & fileExt & "?" & rnd()%>"></td>

<td valign=top><img src="<%=upload_dir & upload_thumb & fileExt & "?" & rnd()%>"></td>

</tr>

</table>

<%

else

	response.write(msg)

end if

%>

Open in new window

0
Comment
Question by:thearniec
  • 4
5 Comments
 
LVL 3

Expert Comment

by:R_Janssen
ID: 22606496
Check if the path exists before trying to save. If you are missing a trailing slash it will throw an exception (And since the save would throw it would be a GDI+ error). Also check if the rawbitmap is actually filled and not null or length 0.
 
0
 

Author Comment

by:thearniec
ID: 22606604
I added to the code:
<%@ Import Namespace=System.IO %>


and then later

If Directory.Exists(upload_dir) Then
      response.write("directory valid")
else
      response.write("cannot find " & upload_dir & "<P>")
end if

It says it cannot find the directory.  

So if it is a path error, what would be causing it?  I've tried

\userImages\
userImages
userImages\
.\userImages
/userImages/
etc

It should be looking in the directory where the ASPX file is stored, and all paths relative to that, right?  Because I have a folder userImages in the same folder as my test ASPX.

Thakn you for your quick response!
0
 

Author Comment

by:thearniec
ID: 22606663
Additionally, I changed the upload directory to .\ which comes back as a valid directory.

And I have validated the image exists by inserting

response.write(originalImg.size)

and I get back

{Width=288, Height=288}.

But yet I still get the error on the .save methods...
0
 

Author Comment

by:thearniec
ID: 22606752
Sorry to keep adding but I'm testing more.

I added in some response.writes as shown in the code snippit below.  The path and filename appear correct.

With my upload directory as .\ which comes up directory valid, I get this output:  
directory valid{Width=288, Height=288}E:\MemNet2\CMS\warehouse\sample.jpg
directory valid


showing the file would be saved to my server's E drive and properly formatted in name and directory structure.  

And if I change it back to userImages

cannot find userImages\
{Width=288, Height=288}E:\MemNet2\CMS\warehouse\userImages\sample.jpg

directory valid

My first stest does not see just userImages but when I try the full path E:\...\userImages as shown above, it says directory valid.

And yet in both cases I get the same error on the save...

try

				fileExt = System.IO.Path.GetExtension(fileFld.FileName).ToLower()

				response.write(originalImg.size)

				Response.Write(Server.MapPath(upload_dir & upload_original & fileExt) & "<P>")

				If Directory.Exists(Server.MapPath(upload_dir)) Then 

					response.write("directory valid<P>")  

				else

					response.write("cannot find " & upload_dir & "<P>")

				end if

				'originalImg.save(Server.MapPath(upload_dir & upload_original & fileExt), originalImg.rawformat)

				'thumb.save(Server.MapPath(upload_dir & upload_thumb & fileExt), originalImg.rawformat)

				 

				msg = "Uploaded " & fileFld.FileName & " to " & Server.MapPath(upload_dir & upload_original & fileExt)

				upload_ok = true

	'		catch

	'			msg = "Sorry, there was a problem saving the image."

	'		end try

Open in new window

0
 

Accepted Solution

by:
thearniec earned 0 total points
ID: 22606829
Got it!  IIS permissions error....
0

Featured Post

Enabling OSINT in Activity Based Intelligence

Activity based intelligence (ABI) requires access to all available sources of data. Recorded Future allows analysts to observe structured data on the open, deep, and dark web.

Join & Write a Comment

Popularity Can Be Measured Sometimes we deal with questions of popularity, and we need a way to collect opinions from our clients.  This article shows a simple teaching example of how we might elect a favorite color by letting our clients vote for …
I've been asked to discuss some of the UX activities that I'm using with my team. Here I will share some details about how we approach UX projects.
Explain concepts important to validation of email addresses with regular expressions. Applies to most languages/tools that uses regular expressions. Consider email address RFCs: Look at HTML5 form input element (with type=email) regex pattern: T…
The viewer will learn how to create and use a small PHP class to apply a watermark to an image. This video shows the viewer the setup for the PHP watermark as well as important coding language. Continue to Part 2 to learn the core code used in creat…

706 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

17 Experts available now in Live!

Get 1:1 Help Now