Reading Microsoft AD users via python

I have the following script in python, that reads user properties from Microsoft Active Directory. However I have some basic issues regarding string manipulation with this tool.
Basically, I try to read:
username, first name, last name
and then feed this result to a shell command in my linux system.
however I cannot properly handle the following situations:
a- first name field is blank
b- first name field contains spaces example "Erick Perez"
c- same for last name field (a and b)
d- last name or first name contains numbers, tildes or the letter ñ. (ASCII 0164)

Please advice.

# Notes:
# This script automatically creates zimbra accounts from active directory.
# The user must be enabled, otherwise it will be skipped.
# Variables can be changed here:
import ldap, string, os, time, sys 
# BaseDN to search for user accounts.
base = 'cn=users,dc=quadrian,dc=gob,dc=pa'
scope = ldap.SCOPE_SUBTREE
# We filter for user accounts only, we skip machine and groups
filter = "(&(objectclass=person) (uid=%s))"
# Active Directory Domain Name
domain = "" 
# Active Directory Domain Controller
#ldap port usually 389
# Email domain to be used in mail applications
# Bind Domain for LDAP user account that will query the AD
#the account name of the account to bind to ldap and query de AD
# Here We list all Zimbra Accounts. So we can compare if the account we read from AD
# is already created in Zimbra or not.
f = os.popen(pathtozmprov +' gaa')
zmprovgaa= []
zmprovgaa = f.readlines()
# Here we initialize the LDAP connection 
	print "Your username or password to bind to LDAP is incorrect."
except ldap.LDAPError, e:
	if type(e.message) == dict and e.message.has_key('desc'):
		print e.message['desc']
		print e
# End of LDAP initialization
# Now we look for ENABLED user accounts in AD and get the following values
# sAMAccountName is the username to log on to the domain
# givenName is the first name
# sn is the surname or last name
# example of current usernames in the domain
# 4-982-345
# ericklatam
# memberOf are the groups this user belongs to
    res = l.search_s(base,scope, "(&(ObjectCategory=user)  (userAccountControl=512))",  ['sAMAccountName','givenName','sn','memberOf'])
#userAccountControl  512 = normal , 514 = disabled account
    for (dn, vals) in res:
      accountname = vals['sAMAccountName'][0].lower()
      print "accountname: "+accountname
        sirname = vals['sn'][0].lower()
        sirname = vals['sAMAccountName'][0].lower()
        givenname = vals['givenName'][0]
        givenname = vals['sAMAccountName'][0].lower()
        groups = vals['memberOf']
        groups = 'none'
      initial = givenname[:1].upper()
      sirname = sirname.replace(' ', )
      sirname = sirname.replace('\\', )
      sirname = sirname.replace('-', )
      sirname = sirname.capitalize()
      name = initial + "." + sirname
      accountname = accountname + "@" + emaildomain
      password = "  \'\' "
      # if the account doesn't exist in the output of zmprov gaa create the  account
      if accountname +"\n" not in zmprovgaa:
        print  accountname," exists in active directory but not in zimbra, the   account is being created\n"
        os.system(pathtozmprov +' ca %s %s displayName %s' %  (accountname,password,name))

Open in new window

Who is Participating?
peprConnect With a Mentor Commented:
Well, I do not know the ldap module. For the string module, you usually do not need it as the majority of its functionality was replaced by the built-in string methods.

For the ability to work correctly with the non-ASCII characters (above 127), Python is able to work in the "native" encoding of the OS or with UNICODE. It depends in what form you get the string. Try

print repr(myStringVariable) and you will see u'some string' or without u -- 'some string'. When working with 8-bit encoding, you have to tell Python what 8-bit encoding you use.

Please, show some examples of the problematic names (with spaces, none,...). Point to the lines in your code where you observe the problems.

erickperezAuthor Commented:
sorry, been traveling.
i will repost with exmaples.
Well, did you solved the problem with my hints? Or why you accepted it?
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.