Want to protect your cyber security and still get fast solutions? Ask a secure question today.Go Premium

x
?
Solved

Function not being called

Posted on 2008-10-01
4
Medium Priority
?
188 Views
Last Modified: 2010-04-21
Hi,
There is a function in this javascript file that is supposed to replace "&" with "&" and " " with a space, but it is not being called.  Any ideas?  Thanks!

Here is the page:
http://myweb.twu.edu/~bklug/catalog/js/test5.htm

I have attached my javascript.  The functions not being called are:
function ampersandReplacer() {
  var b = document.getElementsByTagName('body')[0];
  var re = /(&)/g;
 
  if( b.innerHTML.match( re ) ) {
    b.innerHTML =  b.innerHTML.replace(re,"&");
  }
}

function ampersandReplacer2() {
  var b = document.getElementsByTagName('body')[0];
  var re = /( )/g;
 
  if( b.innerHTML.match( re ) ) {
    b.innerHTML =  b.innerHTML.replace(re," ");
  }
}
//////////////////////////////////////////////////////////////////////
//////////////////////////////////////////////////////////////////////
 
 
 
 
function numberPages() {
  var rec = window.location.href.match(/recPointer=(\d+)/);
  var counter = rec ? rec[1] : 0;
 
  var allItems = getElementsByClassName('resultListCheckBox');
  for(var i = 0, e = allItems.length; i < e; i++) {
    if(allItems[i].firstChild) {
      var span = document.createElement('span');
      span.style.paddingLeft = '20px';
      span.innerHTML = parseInt(i, 10) + parseInt(counter, 10) + parseInt(1, 10);
      allItems[i].insertBefore(span, allItems[i].firstChild);
    }
  }
}
 
//Got this from dustiandiaz.com.  No need to reinvent the wheel
function getElementsByClassName(searchClass,node,tag) {
  var classElements = new Array();
  if ( node == null ) {
          node = document;
  }
  if ( tag == null ) {
          tag = '*';
  }
  var els = node.getElementsByTagName(tag);
  var elsLen = els.length;
  var pattern = new RegExp('(^|\\\\s)'+searchClass+'(\\\\s|$)');
  for (i = 0, j = 0; i < elsLen; i++) {
    if ( pattern.test(els[i].className) ) {
            classElements[j] = els[i];
            j++;
    }
  }
  return classElements;
}
 
 
function setFocus(pageName) {
   /*
   ** A pageName will get passed in , which we will use to set the focus.
   ** to add support for a new page use the /page:page/@nameId (from the XML)
   ** value for the case match, and call the focusElement() function with the
   ** id of the form element to set focus to
   ** 
   */
 
   switch(pageName)  {
    case 'page.searchBasic':
    case 'page.searchSubject':
    case 'page.searchAuthor':
       focusElement('searchArg');
       break;
       
    case 'page.searchAdvanced':
       focusElement('searchArg1');
       break;
       
    case 'page.logIn':
       focusElement('loginId');
       break;
  } 
 
  numberPages()
  ampersandReplacer();
   ampersandReplacer2();
  return true;
}
 
function ampersandReplacer() {
  var b = document.getElementsByTagName('body')[0];
  var re = /(&amp;)/g;
 
  if( b.innerHTML.match( re ) ) {
    b.innerHTML =  b.innerHTML.replace(re,"&");
  }
}
 
function ampersandReplacer2() {
  var b = document.getElementsByTagName('body')[0];
  var re = /(&nbsp;)/g;
 
  if( b.innerHTML.match( re ) ) {
    b.innerHTML =  b.innerHTML.replace(re," ");
  }
}
 
 
  <!--End edited by TWU Library  -->
 
 
 
 
//////////////////////////////////////////////////////////////////////
function focusElement(eleName) {
   if(document.getElementById(eleName)) {
      document.getElementById(eleName).focus();
   }
}
///////////////////////////////////////////////////////////////

Open in new window

0
Comment
Question by:jianxin9
  • 2
  • 2
4 Comments
 
LVL 15

Expert Comment

by:MMDeveloper
ID: 22615525
this is what I did to your code and it worked fine for me

this is inside your pageInputFocus-2.js file
function setFocus(pageName) {
   /*
   ** A pageName will get passed in , which we will use to set the focus.
   ** to add support for a new page use the /page:page/@nameId (from the XML)
   ** value for the case match, and call the focusElement() function with the
   ** id of the form element to set focus to
   **
   */
 
   switch(pageName)  {
    case 'page.searchBasic':
    case 'page.searchSubject':
    case 'page.searchAuthor':
       focusElement('searchArg');
       break;
 
    case 'page.searchAdvanced':
       focusElement('searchArg1');
       break;
 
    case 'page.logIn':
       focusElement('loginId');
       break;
  }
 
  numberPages();
  replaceChars();
  //ampersandReplacer();
   //ampersandReplacer2();
  return true;
}
 
function replaceChars() {
	b = document.getElementById("theResults");
	b.innerHTML = b.innerHTML.replace(/&amp;/g, "&");
	b.innerHTML = b.innerHTML.replace(/&nbsp;/g, " ");
}

Open in new window

0
 
LVL 15

Accepted Solution

by:
MMDeveloper earned 2000 total points
ID: 22615535
ehh... ok well that last replace should have the HTML code for a space in it, when I posted it, it must have been stripped out, I'll try to post again


function setFocus(pageName) {
   /*
   ** A pageName will get passed in , which we will use to set the focus.
   ** to add support for a new page use the /page:page/@nameId (from the XML)
   ** value for the case match, and call the focusElement() function with the
   ** id of the form element to set focus to
   **
   */

   switch(pageName)  {
    case 'page.searchBasic':
    case 'page.searchSubject':
    case 'page.searchAuthor':
       focusElement('searchArg');
       break;

    case 'page.searchAdvanced':
       focusElement('searchArg1');
       break;

    case 'page.logIn':
       focusElement('loginId');
       break;
  }

  numberPages();
  replaceChars();
  //ampersandReplacer();
   //ampersandReplacer2();
  return true;
}

function replaceChars() {
      b = document.getElementById("theResults");
      b.innerHTML = b.innerHTML.replace(/&amp;/g, "&");
      b.innerHTML = b.innerHTML.replace(/&nbsp;/g, " ");
}
0
 

Author Comment

by:jianxin9
ID: 22616735
Thanks so much for posting.  When I tried it like that, it seemed to work for the "&nbsp" but not for the "&amp;", when I make this change (change on second line), it works for both, but seems to get rid of the yellow highlighting which we need.  

function replaceChars() {
       b = document.getElementsByTagName("body");
      b.innerHTML = b.innerHTML.replace(/&amp;/g, "&");
      b.innerHTML = b.innerHTML.replace(/&nbsp;/g, " ");
}

function setFocus(pageName) {
   /*
   ** A pageName will get passed in , which we will use to set the focus.
   ** to add support for a new page use the /page:page/@nameId (from the XML)
   ** value for the case match, and call the focusElement() function with the
   ** id of the form element to set focus to
   **
   */
 
   switch(pageName)  {
    case 'page.searchBasic':
    case 'page.searchSubject':
    case 'page.searchAuthor':
       focusElement('searchArg');
       break;
 
    case 'page.searchAdvanced':
       focusElement('searchArg1');
       break;
 
    case 'page.logIn':
       focusElement('loginId');
       break;
  }
 
  numberPages();
  replaceChars();
  return true;
}
 
function replaceChars() {
       b = document.getElementsByTagName("body");
      b.innerHTML = b.innerHTML.replace(/&amp;/g, "&");
      b.innerHTML = b.innerHTML.replace(/&nbsp;/g, " ");
}

Open in new window

0
 

Author Closing Comment

by:jianxin9
ID: 31501964
thanks so much!
0

Featured Post

Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

I will show you how to create a ASP.NET Captcha control without using any HTTP HANDELRS or what so ever. you can easily plug it into your web pages. For Example a = 2 + 3 (where 2 and 3 are 2 random numbers) Session("Answer") = 5 then we…
Introduction Since I wrote the original article about Handling Date and Time in PHP and MySQL several years ago, it seemed like now was a good time to update it for object-oriented PHP.  This article does that, replacing as much as possible the pr…
The viewer will learn how to count occurrences of each item in an array.
Learn how to create flexible layouts using relative units in CSS.  New relative units added in CSS3 include vw(viewports width), vh(viewports height), vmin(minimum of viewports height and width), and vmax (maximum of viewports height and width).
Suggested Courses

572 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question