Solved

Positive or Negative value returned from comparison

Posted on 2008-10-01
11
882 Views
Last Modified: 2012-08-13
Hello,
 
 This should be a quick fix for almost anyone :) but i have never had to deal  with absolute value or a comparison of this type before.
 Below is the code i am currently using. Now what i am trying to accomplish is this.
 
 I have a current count and a previous count. Both values are correct coming into the function.
 
 I want to compare the 2 values and find the difference, Either positive or negative or equal etc.
 
 Now if the value is positive i want to output a +(number) if it's negative i want to output -(number)
 
 I thought in theory this would work. However i always seem to evaluate to a positive number.
 
 Perhaps someone can help me out and tell me where i messed up
 
 Thanks for the help.

function FindVariance($Previous,$Current)

		{

				if ( is_numeric($Current) && is_numeric($Previous) ) {

						$Difference = abs( $Current - $Previous );

					}

					

				

					if(Difference > $Current)

					{

						$this->CountChange = "-".$Difference;

					}

					elseif($Difference < $Current )

					{

						$this->CountChange = "+".$Difference;

					}

					else if(!is_numeric($Difference))

					{

						$this->CountChange=null; 

					}

					else

					{

						$this->CountChange = $Difference;

					}

			

		 	return $this->CountChange;

		}

Open in new window

0
Comment
Question by:Defunct-Exodus
  • 8
  • 3
11 Comments
 
LVL 4

Expert Comment

by:Jerrod_W
ID: 22617419
missing a space on the 2nd else if?
0
 
LVL 4

Expert Comment

by:Jerrod_W
ID: 22617423
err, make that the 1st one
0
 

Author Comment

by:Defunct-Exodus
ID: 22617697
Sorry i edited the code a bit before i posted it, The syntax etc appears to be correctly on my end.

But for some reason it never shows a "-" just a "+" even if the value is lower.
0
 
LVL 4

Expert Comment

by:Jerrod_W
ID: 22618474
Can you post your current syntax, cause I'm still seeing errors
0
 

Author Comment

by:Defunct-Exodus
ID: 22618587
Okay here you go,

Hopefully it is something as simple as a syntax error on my part lol.
	function FindVariance($PreviousCount,$CurrentCount)

		{

				if ( is_numeric($CurrentCount) && is_numeric($PreviousCount) ) {

						$Difference = abs( $CurrentCount - $PreviousCount );

					}

					

				

					if($Difference > $CurrentCount)

					{

						$this->CountChange = "-".$Difference;

					}

					elseif($Difference < $CurrentCount)

					{

						$this->CountChange = "+".$Difference;

					}

					else if(!is_numeric($Difference))

					{

						$this->CountChange=null; 

					}

					else

					{

						$this->CountChange = $Difference;

					}

			

		 	return $this->CountChange;

		}

Open in new window

0
6 Surprising Benefits of Threat Intelligence

All sorts of threat intelligence is available on the web. Intelligence you can learn from, and use to anticipate and prepare for future attacks.

 
LVL 4

Expert Comment

by:Jerrod_W
ID: 22619468
As far as I can tell, what I have should work.
       function FindVariance($PreviousCount,$CurrentCount)

                {

                                if ( is_numeric($CurrentCount) && is_numeric($PreviousCount) ) {

                                                $Difference = abs( $CurrentCount - $PreviousCount );

                                        }

                                        

                                

                                        if($Difference > $CurrentCount)

                                        {

                                                $this->CountChange = "-".$Difference;

                                        }

                                        else if($Difference < $CurrentCount)

                                        {

                                                $this->CountChange = "+".$Difference;

                                        }

                                        else if(!is_numeric($Difference))

                                        {

                                                $this->CountChange=null; 

                                        }

                                        else

                                        {

                                                $this->CountChange = $Difference;

                                        }

                        

                        return $this->CountChange;

                }

Open in new window

0
 
LVL 4

Expert Comment

by:Jerrod_W
ID: 22619513
Another quick question. Where are you getting the numbers for previouscount and currentcount? Unless  previouscount is double the value of currentcount, your number will always return positive due to the fact that you are using absolute value.
0
 
LVL 4

Expert Comment

by:Jerrod_W
ID: 22619704

       function FindVariance($PreviousCount,$CurrentCount)

                {

                                if ( is_numeric($CurrentCount) && is_numeric($PreviousCount) ) {

                                                $Difference = abs( $CurrentCount - $PreviousCount );

                                        }

                                        

                                

                                        if($Difference < $CurrentCount)

                                        {

                                                $this->CountChange = "-".$Difference;

                                        }

                                        else if($Difference > $CurrentCount)

                                        {

                                                $this->CountChange = "+".$Difference;

                                        }

                                        else if(!is_numeric($Difference))

                                        {

                                                $this->CountChange=null; 

                                        }

                                        else

                                        {

                                                $this->CountChange = $Difference;

                                        }

                        

                        return $this->CountChange;

                }

Open in new window

0
 
LVL 4

Accepted Solution

by:
Jerrod_W earned 500 total points
ID: 22619836
My php is pretty rusty, but I think will work better towards what you are trying to do. I'm kinda tired, so ignore my other junk.
       function FindVariance($PreviousCount,$CurrentCount)

                {

                                if ( is_numeric($CurrentCount) && is_numeric($PreviousCount) ) {

                                                $Difference = ( $CurrentCount - $PreviousCount );

                                        }

                                        

                                

                                        if($Difference < $CurrentCount)

                                        {

                                                $this->CountChange = "-".$Difference;

                                        }

                                        else if( $Difference  < 0)

                                        {

                                                $this->CountChange = "+".abs ( $Difference );

                                        }

                                        else if(!is_numeric($Difference))

                                        {

                                                $this->CountChange=null; 

                                        }

                                        else

                                        {

                                                $this->CountChange = $Difference;

                                        }

                        

                        return $this->CountChange;

                }

Open in new window

0
 

Author Closing Comment

by:Defunct-Exodus
ID: 31502105
Well that was it, I totally messed up using abs, I should have just tried to keep things simple.

Jerrod, Thank you very much for your help.
0
 
LVL 4

Expert Comment

by:Jerrod_W
ID: 22625175
You may also want to add something to check when the currentcount is less than or equal to zero. You will have some weird things happen if you don't.
0

Featured Post

What Should I Do With This Threat Intelligence?

Are you wondering if you actually need threat intelligence? The answer is yes. We explain the basics for creating useful threat intelligence.

Join & Write a Comment

Deprecated and Headed for the Dustbin By now, you have probably heard that some PHP features, while convenient, can also cause PHP security problems.  This article discusses one of those, called register_globals.  It is a thing you do not want.  …
I imagine that there are some, like me, who require a way of getting currency exchange rates for implementation in web project from time to time, so I thought I would share a solution that I have developed for this purpose. It turns out that Yaho…
The viewer will learn how to dynamically set the form action using jQuery.
The viewer will learn how to count occurrences of each item in an array.

747 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

10 Experts available now in Live!

Get 1:1 Help Now