Solved

How to make login form with connectionstring

Posted on 2008-10-02
6
4,152 Views
Last Modified: 2012-05-05
i am makiing a simple login form where i can login with txtusername.Text and password.Text into connectonstring and logon.

But i am getting error message: +            ex      {"The connection was not closed. The connection's current state is open."}      System.Exception {System.InvalidOperationException}

Can somone hlep me fiksing this bug...?

public void SqlServerLogin(string Sql, string connectionString)
        {
 
            
                SqlConnection sqlConnection2 = new SqlConnection();
                sqlConnection2.ConnectionString = "Data Source=" + sqlConnection2.DataSource + ";initial catalog=" + sqlConnection2.Database + ";Integrated Security=SSPI " + ";user id=" + txtUsername.Text + ";pwd=" + txtPassword.Text;
                sqlConnection2.Open();
                SqlCommand cmd = new SqlCommand(Sql, sqlConnection2);
                //SqlDataReader dr;
                //cmd.ExecuteNonQuery();
                try
                {
                    cmd.Connection.Open();
                    cmd.ExecuteNonQuery();
                }
                catch (Exception ex)
                {
                    System.Windows.Forms.MessageBox.Show("Couldnt execute the query! " + ex.Message.ToString());
                }
                finally
                {
                    cmd.Connection.Close();
                }
}

Open in new window

0
Comment
Question by:Adnan
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 3
  • 3
6 Comments
 
LVL 5

Expert Comment

by:johnaryan
ID: 22622677
I'd give this a go in your finally

 finally
            {
                if (cmd != null)
                {
                    cmd.Dispose();
                }
                if (sqlConnection2 != null)
                {
                    sqlConnection2.Close();
                    sqlConnection2 = null;
                }
            }

Open in new window

0
 

Author Comment

by:Adnan
ID: 22622699
thanks man, it helped, but now iam getting this error message: +            ex      {"Object reference not set to an instance of an object."}      System.Exception {System.NullReferenceException}

is my method correct for logon to sql server with sqlConnection2.ConnectionString = "Data Source="......!!!
0
 
LVL 5

Accepted Solution

by:
johnaryan earned 500 total points
ID: 22622770
When running through a debugger, when you hit the line
sqlConnection2.Open();
What is the state of the sqlConnection?

The connection string i use for SQL Server is of the form:
"Server=myServerName, port;Database=myDatabase;Uid=username;Pwd=password
0
Salesforce Made Easy to Use

On-screen guidance at the moment of need enables you & your employees to focus on the core, you can now boost your adoption rates swiftly and simply with one easy tool.

 

Author Comment

by:Adnan
ID: 22622784
when i hit the line sqlConnection2.Open(); the state i closed....????!!
0
 
LVL 5

Expert Comment

by:johnaryan
ID: 22623023
I just want to clarify, is the state closed after the statement runs ( by this i mean when the debugger hits the next line) ?

0
 

Author Comment

by:Adnan
ID: 22623403
i want to make a login form for sql server Authentication....
0

Featured Post

Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Performance in games development is paramount: every microsecond counts to be able to do everything in less than 33ms (aiming at 16ms). C# foreach statement is one of the worst performance killers, and here I explain why.
The article shows the basic steps of integrating an HTML theme template into an ASP.NET MVC project
The viewer will learn how to pass data into a function in C++. This is one step further in using functions. Instead of only printing text onto the console, the function will be able to perform calculations with argumentents given by the user.
The viewer will learn how to use the return statement in functions in C++. The video will also teach the user how to pass data to a function and have the function return data back for further processing.

689 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question