Solved

How to make login form with connectionstring

Posted on 2008-10-02
6
4,144 Views
Last Modified: 2012-05-05
i am makiing a simple login form where i can login with txtusername.Text and password.Text into connectonstring and logon.

But i am getting error message: +            ex      {"The connection was not closed. The connection's current state is open."}      System.Exception {System.InvalidOperationException}

Can somone hlep me fiksing this bug...?

public void SqlServerLogin(string Sql, string connectionString)

        {
 

            

                SqlConnection sqlConnection2 = new SqlConnection();

                sqlConnection2.ConnectionString = "Data Source=" + sqlConnection2.DataSource + ";initial catalog=" + sqlConnection2.Database + ";Integrated Security=SSPI " + ";user id=" + txtUsername.Text + ";pwd=" + txtPassword.Text;

                sqlConnection2.Open();

                SqlCommand cmd = new SqlCommand(Sql, sqlConnection2);

                //SqlDataReader dr;

                //cmd.ExecuteNonQuery();

                try

                {

                    cmd.Connection.Open();

                    cmd.ExecuteNonQuery();

                }

                catch (Exception ex)

                {

                    System.Windows.Forms.MessageBox.Show("Couldnt execute the query! " + ex.Message.ToString());

                }

                finally

                {

                    cmd.Connection.Close();

                }

}

Open in new window

0
Comment
Question by:Adnan
  • 3
  • 3
6 Comments
 
LVL 5

Expert Comment

by:johnaryan
ID: 22622677
I'd give this a go in your finally

 finally

            {

                if (cmd != null)

                {

                    cmd.Dispose();

                }

                if (sqlConnection2 != null)

                {

                    sqlConnection2.Close();

                    sqlConnection2 = null;

                }

            }

Open in new window

0
 

Author Comment

by:Adnan
ID: 22622699
thanks man, it helped, but now iam getting this error message: +            ex      {"Object reference not set to an instance of an object."}      System.Exception {System.NullReferenceException}

is my method correct for logon to sql server with sqlConnection2.ConnectionString = "Data Source="......!!!
0
 
LVL 5

Accepted Solution

by:
johnaryan earned 500 total points
ID: 22622770
When running through a debugger, when you hit the line
sqlConnection2.Open();
What is the state of the sqlConnection?

The connection string i use for SQL Server is of the form:
"Server=myServerName, port;Database=myDatabase;Uid=username;Pwd=password
0
Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

 

Author Comment

by:Adnan
ID: 22622784
when i hit the line sqlConnection2.Open(); the state i closed....????!!
0
 
LVL 5

Expert Comment

by:johnaryan
ID: 22623023
I just want to clarify, is the state closed after the statement runs ( by this i mean when the debugger hits the next line) ?

0
 

Author Comment

by:Adnan
ID: 22623403
i want to make a login form for sql server Authentication....
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Entity Framework is a powerful tool to help you interact with the DataBase but still doesn't help much when we have a Stored Procedure that returns more than one resultset. The solution takes some of out-of-the-box thinking; read on!
It was really hard time for me to get the understanding of Delegates in C#. I went through many websites and articles but I found them very clumsy. After going through those sites, I noted down the points in a easy way so here I am sharing that unde…
The goal of this video is to provide viewers with basic examples to understand and use conditional statements in the C programming language.
This video teaches viewers about errors in exception handling.

867 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

12 Experts available now in Live!

Get 1:1 Help Now