• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 4159
  • Last Modified:

How to make login form with connectionstring

i am makiing a simple login form where i can login with txtusername.Text and password.Text into connectonstring and logon.

But i am getting error message: +            ex      {"The connection was not closed. The connection's current state is open."}      System.Exception {System.InvalidOperationException}

Can somone hlep me fiksing this bug...?

public void SqlServerLogin(string Sql, string connectionString)
        {
 
            
                SqlConnection sqlConnection2 = new SqlConnection();
                sqlConnection2.ConnectionString = "Data Source=" + sqlConnection2.DataSource + ";initial catalog=" + sqlConnection2.Database + ";Integrated Security=SSPI " + ";user id=" + txtUsername.Text + ";pwd=" + txtPassword.Text;
                sqlConnection2.Open();
                SqlCommand cmd = new SqlCommand(Sql, sqlConnection2);
                //SqlDataReader dr;
                //cmd.ExecuteNonQuery();
                try
                {
                    cmd.Connection.Open();
                    cmd.ExecuteNonQuery();
                }
                catch (Exception ex)
                {
                    System.Windows.Forms.MessageBox.Show("Couldnt execute the query! " + ex.Message.ToString());
                }
                finally
                {
                    cmd.Connection.Close();
                }
}

Open in new window

0
Adnan
Asked:
Adnan
  • 3
  • 3
1 Solution
 
johnaryanCommented:
I'd give this a go in your finally

 finally
            {
                if (cmd != null)
                {
                    cmd.Dispose();
                }
                if (sqlConnection2 != null)
                {
                    sqlConnection2.Close();
                    sqlConnection2 = null;
                }
            }

Open in new window

0
 
AdnanAuthor Commented:
thanks man, it helped, but now iam getting this error message: +            ex      {"Object reference not set to an instance of an object."}      System.Exception {System.NullReferenceException}

is my method correct for logon to sql server with sqlConnection2.ConnectionString = "Data Source="......!!!
0
 
johnaryanCommented:
When running through a debugger, when you hit the line
sqlConnection2.Open();
What is the state of the sqlConnection?

The connection string i use for SQL Server is of the form:
"Server=myServerName, port;Database=myDatabase;Uid=username;Pwd=password
0
Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
AdnanAuthor Commented:
when i hit the line sqlConnection2.Open(); the state i closed....????!!
0
 
johnaryanCommented:
I just want to clarify, is the state closed after the statement runs ( by this i mean when the debugger hits the next line) ?

0
 
AdnanAuthor Commented:
i want to make a login form for sql server Authentication....
0

Featured Post

Keep up with what's happening at Experts Exchange!

Sign up to receive Decoded, a new monthly digest with product updates, feature release info, continuing education opportunities, and more.

  • 3
  • 3
Tackle projects and never again get stuck behind a technical roadblock.
Join Now