• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 1957
  • Last Modified:

Add field if does not exist (mysql, php)

Hello,

The problem with my code is that some databases do not contain fields for "extra1Width" and "extra2Width".

This causes a database error.

How can I automatically ADD these fields if they do not already exist to avoid the error?

The value should be a smallint and should be 0 by default.


$adminSetting .= '
	extra1Width = ' . quote_smart($_POST['extra1Width']) . ',
	extra2Width = ' . quote_smart($_POST['extra2Width']) . ',
 
 
    $postupdate = 'UPDATE
                        cms_vars
                    SET
                        Item1 = ' . quote_smart($_POST['Item1']) . ','
			.$adminSetting.'
                        Item2 = ' . quote_smart($_POST['Item2']) . ','
                    WHERE
                        id = 1';
 
    $postupdateer = mysql_query($postupdate);

Open in new window

0
hankknight
Asked:
hankknight
  • 3
  • 2
1 Solution
 
AielloJCommented:
How many databases would you possibly need to make this upgrade to?  You might want to consider the risks of a web / PHP application being able to change your database structure.
0
 
hankknightAuthor Commented:
I have about 70 databases.  Alternatively I could just check to see if the fields exists before doing the query to avoid the error.  How could I do that?
0
 
AielloJCommented:
My first reccomendation would be to do the updates to all the databases if possible.  If not, the easiest way to check if the field exists would be to do a SELECT * FROM the table with a rowlimit of 1.  Then check for the existence of the column name in the recordset using the isset function.  I consider this a definite second best solution to doing the database column updates if at all practical.
0
Free Tool: IP Lookup

Get more info about an IP address or domain name, such as organization, abuse contacts and geolocation.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

 
Hube02Commented:

//See if a column exists
 
  $columns = array();
  $table = 'MyTable'
  $query = 'SHOW COLUMNS FROM '.$table.';';
  if ($results = mysql_query($query)) {
   if (mysql_num_rows($results) > 0) {
    while($row = mysql_fetch_row($results)) {
     columns[] = $row[0];
    }
   }
  }
  if (in_array('myColumn', $columns)) {
   echo 'column exists';     
  }
 
// add a column query
  $column = 'myColumn'
  $query = 'ALTER TABLE '.$table.' ADD COLUMN '.$column.' smallint DEFAULT "0";';

Open in new window

0
 
Hube02Commented:
Should have left a comment...

You could turn the above into a function and call it to check for the columns that are needed before trying to use those columns.

As long as you specify the exact columns and do not depend on user input for the column names you should be safe. Never alter a table based on user input unless you are sure you know what that user input it. Only alter a database based on specific requirements.
0
 
Hube02Commented:
just as an aside...

Altering a database in this way is a more common thing that one would expect. Many upgrades of applications perform these types of checks, especially those that do not require you to run an installation script to make the update.

If an installation/update script is provided then in many cases the database changes are done in the update. However, if an installation/update script is not used then in all likelihood, if database changes are included in the update, there could be many places where tables are altered to meet the new requirements of the application.

Security should always be considered when performing these changes to ensure that random alterations cannot occur due to user input.
0

Featured Post

Receive 1:1 tech help

Solve your biggest tech problems alongside global tech experts with 1:1 help.

  • 3
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now