Solved

How to iterate through files in VB Script, opening each one for reading

Posted on 2008-10-02
3
1,383 Views
Last Modified: 2008-10-03
At Line 18 I read in all of the files in a directory into a collection called 'FileNames'  I then try to iterate through all F in FileNames.  I get an error on Line 25 because "F does not support .AtEndOfStream.  I think I'm just slightly off syntactically, but how can I iterate through this collection of files, opening each one for reading as I go?


dim FileSys
 

DirName = "C:\BackupVerify\" 
 

Set FileSys = CreateObject("Scripting.FileSystemObject")
 

'if the C:\BackupVerify directory does not exist, create it

If Not FileSys.FolderExists(DirName) Then

Set CreatedDir = FileSys.CreateFolder(DirName)

End If
 

'------------------------------------------------------------
 

'iterate through all files in the C:\BackupVerify directory
 

Set FileRetriever = FileSys.GetFolder(DirName)

Set FileNames = FileRetriever.Files
 

For Each F in FileNames
 

Dim FileContents()

i = 0
 

'read the contents of each file into an array

Do Until F.AtEndOfStream

Redim Preserve FileContents(i)

FileContents(i) = F.ReadLine

i = i + 1

Loop

F.Close
 

'look at the date from the file

Set PrevDate = FileContents(0)
 

'look at the current date

Set CurrDate = Date()
 

'calcualte the difference between the two dates in number of days

Set Date_Diff = DateDiff("d" , CurrDate , PrevDate )
 

'if the backup test file is older than 180 days, delete it

If Date_Diff > 180 Then

	FileSys.DeleteFile(DirName & "BackupVerify" & PrevDate & ".txt")

	End If
 

Next 
 

'-----------------------------------------------------------
 

DateStamp = FormatDateTime(Date(),1)

TimeStamp = Time()
 

FileName = DirName & "BackupVerify" & DateStamp & ".txt"

WScript.echo filename

Set FileWriter = FileSys.CreateTextFile(FileName, True)
 

FileWriter.WriteLine(DateStamp)

FileWriter.WriteLine(TimeStamp)
 

FileWriter.Close
 

'WRITE TO ERROR LOG IF FILE

Open in new window

0
Comment
Question by:jkovba
3 Comments
 
LVL 67

Accepted Solution

by:
sirbounty earned 100 total points
Comment Utility
You don't need that - it's for reading an input file...or if you're trying to open each file...
dim FileSys

 

DirName = "C:\BackupVerify\" 

 

Set FileSys = CreateObject("Scripting.FileSystemObject")

 

'if the C:\BackupVerify directory does not exist, create it

If Not FileSys.FolderExists(DirName) Then

Set CreatedDir = FileSys.CreateFolder(DirName)

End If

 

'------------------------------------------------------------

 

'iterate through all files in the C:\BackupVerify directory

 

Set FileRetriever = FileSys.GetFolder(DirName)

Set FileNames = FileRetriever.Files

 

For Each F in FileNames

 

Dim FileContents()

i = 0

 

'read the contents of each file into an array

Dim objFile : Set objFile = FileSys.OpenTextFile(F)

Do Until objFile.AtEndOfStream

  Redim Preserve FileContents(i)

  FileContents(i) = F.ReadLine

  i = i + 1

Loop

objFile.Close

 

'look at the date from the file

Set PrevDate = FileContents(0)

 

'look at the current date

Set CurrDate = Date()

 

'calcualte the difference between the two dates in number of days

Set Date_Diff = DateDiff("d" , CurrDate , PrevDate )

 

'if the backup test file is older than 180 days, delete it

If Date_Diff > 180 Then

        FileSys.DeleteFile(DirName & "BackupVerify" & PrevDate & ".txt")

        End If

 

Next 

 

'-----------------------------------------------------------

 

DateStamp = FormatDateTime(Date(),1)

TimeStamp = Time()

 

FileName = DirName & "BackupVerify" & DateStamp & ".txt"

WScript.echo filename

Set FileWriter = FileSys.CreateTextFile(FileName, True)

 

FileWriter.WriteLine(DateStamp)

FileWriter.WriteLine(TimeStamp)

 

FileWriter.Close

 

'WRITE TO ERROR LOG IF FILE

Open in new window

0
 
LVL 9

Expert Comment

by:gregcmcse
Comment Utility
The only addition I'd make to SirBounty's code is a much easier way of handling the array (and should execute MUCH faster).  Use the split function to create an array with each line in its own element in one shot as below.  REDIM PRESERVE is horrifically expensive in terms of execution cycles.

Note:  You MAY get an error on the split due to line 21.  If you do, change the line:

Dim FileContents()
  to
Dim FileContents

or just delete it entirely.
strTemp = ""

Do Until objFile.AtEndOfStream

  strTemp = F.ReadAll

Loop

FileContents = Split(strTemp,vbCrLf)
 

  

Open in new window

0
 

Author Comment

by:jkovba
Comment Utility
Thank you SirBounty for the precise solution, and thanks also to gregmcse for a great suggestion to improve performance.
0

Featured Post

Find Ransomware Secrets With All-Source Analysis

Ransomware has become a major concern for organizations; its prevalence has grown due to past successes achieved by threat actors. While each ransomware variant is different, we’ve seen some common tactics and trends used among the authors of the malware.

Join & Write a Comment

This script will sweep a range of IP addresses (class c only, 255.255.255.0) and report to a log the version of office installed. What it does: 1.)      Creates log file in the directory the script is run from (if it doesn't already exist) 2.)      Sweep…
If you need to start windows update installation remotely or as a scheduled task you will find this very helpful.
Excel styles will make formatting consistent and let you apply and change formatting faster. In this tutorial, you'll learn how to use Excel's built-in styles, how to modify styles, and how to create your own. You'll also learn how to use your custo…
Illustrator's Shape Builder tool will let you combine shapes visually and interactively. This video shows the Mac version, but the tool works the same way in Windows. To follow along with this video, you can draw your own shapes or download the file…

771 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

11 Experts available now in Live!

Get 1:1 Help Now