Solved

How to iterate through files in VB Script, opening each one for reading

Posted on 2008-10-02
3
1,391 Views
Last Modified: 2008-10-03
At Line 18 I read in all of the files in a directory into a collection called 'FileNames'  I then try to iterate through all F in FileNames.  I get an error on Line 25 because "F does not support .AtEndOfStream.  I think I'm just slightly off syntactically, but how can I iterate through this collection of files, opening each one for reading as I go?


dim FileSys
 
DirName = "C:\BackupVerify\" 
 
Set FileSys = CreateObject("Scripting.FileSystemObject")
 
'if the C:\BackupVerify directory does not exist, create it
If Not FileSys.FolderExists(DirName) Then
Set CreatedDir = FileSys.CreateFolder(DirName)
End If
 
'------------------------------------------------------------
 
'iterate through all files in the C:\BackupVerify directory
 
Set FileRetriever = FileSys.GetFolder(DirName)
Set FileNames = FileRetriever.Files
 
For Each F in FileNames
 
Dim FileContents()
i = 0
 
'read the contents of each file into an array
Do Until F.AtEndOfStream
Redim Preserve FileContents(i)
FileContents(i) = F.ReadLine
i = i + 1
Loop
F.Close
 
'look at the date from the file
Set PrevDate = FileContents(0)
 
'look at the current date
Set CurrDate = Date()
 
'calcualte the difference between the two dates in number of days
Set Date_Diff = DateDiff("d" , CurrDate , PrevDate )
 
'if the backup test file is older than 180 days, delete it
If Date_Diff > 180 Then
	FileSys.DeleteFile(DirName & "BackupVerify" & PrevDate & ".txt")
	End If
 
Next 
 
'-----------------------------------------------------------
 
DateStamp = FormatDateTime(Date(),1)
TimeStamp = Time()
 
FileName = DirName & "BackupVerify" & DateStamp & ".txt"
WScript.echo filename
Set FileWriter = FileSys.CreateTextFile(FileName, True)
 
FileWriter.WriteLine(DateStamp)
FileWriter.WriteLine(TimeStamp)
 
FileWriter.Close
 
'WRITE TO ERROR LOG IF FILE

Open in new window

0
Comment
Question by:jkovba
3 Comments
 
LVL 67

Accepted Solution

by:
sirbounty earned 100 total points
ID: 22629114
You don't need that - it's for reading an input file...or if you're trying to open each file...
dim FileSys
 
DirName = "C:\BackupVerify\" 
 
Set FileSys = CreateObject("Scripting.FileSystemObject")
 
'if the C:\BackupVerify directory does not exist, create it
If Not FileSys.FolderExists(DirName) Then
Set CreatedDir = FileSys.CreateFolder(DirName)
End If
 
'------------------------------------------------------------
 
'iterate through all files in the C:\BackupVerify directory
 
Set FileRetriever = FileSys.GetFolder(DirName)
Set FileNames = FileRetriever.Files
 
For Each F in FileNames
 
Dim FileContents()
i = 0
 
'read the contents of each file into an array
Dim objFile : Set objFile = FileSys.OpenTextFile(F)
Do Until objFile.AtEndOfStream
  Redim Preserve FileContents(i)
  FileContents(i) = F.ReadLine
  i = i + 1
Loop
objFile.Close
 
'look at the date from the file
Set PrevDate = FileContents(0)
 
'look at the current date
Set CurrDate = Date()
 
'calcualte the difference between the two dates in number of days
Set Date_Diff = DateDiff("d" , CurrDate , PrevDate )
 
'if the backup test file is older than 180 days, delete it
If Date_Diff > 180 Then
        FileSys.DeleteFile(DirName & "BackupVerify" & PrevDate & ".txt")
        End If
 
Next 
 
'-----------------------------------------------------------
 
DateStamp = FormatDateTime(Date(),1)
TimeStamp = Time()
 
FileName = DirName & "BackupVerify" & DateStamp & ".txt"
WScript.echo filename
Set FileWriter = FileSys.CreateTextFile(FileName, True)
 
FileWriter.WriteLine(DateStamp)
FileWriter.WriteLine(TimeStamp)
 
FileWriter.Close
 
'WRITE TO ERROR LOG IF FILE

Open in new window

0
 
LVL 9

Expert Comment

by:gregcmcse
ID: 22636046
The only addition I'd make to SirBounty's code is a much easier way of handling the array (and should execute MUCH faster).  Use the split function to create an array with each line in its own element in one shot as below.  REDIM PRESERVE is horrifically expensive in terms of execution cycles.

Note:  You MAY get an error on the split due to line 21.  If you do, change the line:

Dim FileContents()
  to
Dim FileContents

or just delete it entirely.
strTemp = ""
Do Until objFile.AtEndOfStream
  strTemp = F.ReadAll
Loop
FileContents = Split(strTemp,vbCrLf)
 
  

Open in new window

0
 

Author Comment

by:jkovba
ID: 22637927
Thank you SirBounty for the precise solution, and thanks also to gregmcse for a great suggestion to improve performance.
0

Featured Post

Courses: Start Training Online With Pros, Today

Brush up on the basics or master the advanced techniques required to earn essential industry certifications, with Courses. Enroll in a course and start learning today. Training topics range from Android App Dev to the Xen Virtualization Platform.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Unlike scripting languages such as C# where a semi-colon is used to indicate the end of a command, Microsoft's VBScript language relies on line breaks to determine when a command begins and ends. As you can imagine, this quickly results in messy cod…
This is pretty cool.  The purpose of this VB Script is to help you document where JAR (Java ARchive) files and specifically java class files are located so that you can address issues seen with a client or that you can speak intelligently with a dev…
Migrating to Microsoft Office 365 is becoming increasingly popular for organizations both large and small. If you have made the leap to Microsoft’s cloud platform, you know that you will need to create a corporate email signature for your Office 365…
This video shows how to quickly and easily add an email signature for all users on Exchange 2016. The resulting signature is applied on a server level by Exchange Online. The email signature template has been downloaded from: www.mail-signatures…

816 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

11 Experts available now in Live!

Get 1:1 Help Now