• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 1419
  • Last Modified:

How to iterate through files in VB Script, opening each one for reading

At Line 18 I read in all of the files in a directory into a collection called 'FileNames'  I then try to iterate through all F in FileNames.  I get an error on Line 25 because "F does not support .AtEndOfStream.  I think I'm just slightly off syntactically, but how can I iterate through this collection of files, opening each one for reading as I go?


dim FileSys
 
DirName = "C:\BackupVerify\" 
 
Set FileSys = CreateObject("Scripting.FileSystemObject")
 
'if the C:\BackupVerify directory does not exist, create it
If Not FileSys.FolderExists(DirName) Then
Set CreatedDir = FileSys.CreateFolder(DirName)
End If
 
'------------------------------------------------------------
 
'iterate through all files in the C:\BackupVerify directory
 
Set FileRetriever = FileSys.GetFolder(DirName)
Set FileNames = FileRetriever.Files
 
For Each F in FileNames
 
Dim FileContents()
i = 0
 
'read the contents of each file into an array
Do Until F.AtEndOfStream
Redim Preserve FileContents(i)
FileContents(i) = F.ReadLine
i = i + 1
Loop
F.Close
 
'look at the date from the file
Set PrevDate = FileContents(0)
 
'look at the current date
Set CurrDate = Date()
 
'calcualte the difference between the two dates in number of days
Set Date_Diff = DateDiff("d" , CurrDate , PrevDate )
 
'if the backup test file is older than 180 days, delete it
If Date_Diff > 180 Then
	FileSys.DeleteFile(DirName & "BackupVerify" & PrevDate & ".txt")
	End If
 
Next 
 
'-----------------------------------------------------------
 
DateStamp = FormatDateTime(Date(),1)
TimeStamp = Time()
 
FileName = DirName & "BackupVerify" & DateStamp & ".txt"
WScript.echo filename
Set FileWriter = FileSys.CreateTextFile(FileName, True)
 
FileWriter.WriteLine(DateStamp)
FileWriter.WriteLine(TimeStamp)
 
FileWriter.Close
 
'WRITE TO ERROR LOG IF FILE

Open in new window

0
jkovba
Asked:
jkovba
1 Solution
 
sirbountyCommented:
You don't need that - it's for reading an input file...or if you're trying to open each file...
dim FileSys
 
DirName = "C:\BackupVerify\" 
 
Set FileSys = CreateObject("Scripting.FileSystemObject")
 
'if the C:\BackupVerify directory does not exist, create it
If Not FileSys.FolderExists(DirName) Then
Set CreatedDir = FileSys.CreateFolder(DirName)
End If
 
'------------------------------------------------------------
 
'iterate through all files in the C:\BackupVerify directory
 
Set FileRetriever = FileSys.GetFolder(DirName)
Set FileNames = FileRetriever.Files
 
For Each F in FileNames
 
Dim FileContents()
i = 0
 
'read the contents of each file into an array
Dim objFile : Set objFile = FileSys.OpenTextFile(F)
Do Until objFile.AtEndOfStream
  Redim Preserve FileContents(i)
  FileContents(i) = F.ReadLine
  i = i + 1
Loop
objFile.Close
 
'look at the date from the file
Set PrevDate = FileContents(0)
 
'look at the current date
Set CurrDate = Date()
 
'calcualte the difference between the two dates in number of days
Set Date_Diff = DateDiff("d" , CurrDate , PrevDate )
 
'if the backup test file is older than 180 days, delete it
If Date_Diff > 180 Then
        FileSys.DeleteFile(DirName & "BackupVerify" & PrevDate & ".txt")
        End If
 
Next 
 
'-----------------------------------------------------------
 
DateStamp = FormatDateTime(Date(),1)
TimeStamp = Time()
 
FileName = DirName & "BackupVerify" & DateStamp & ".txt"
WScript.echo filename
Set FileWriter = FileSys.CreateTextFile(FileName, True)
 
FileWriter.WriteLine(DateStamp)
FileWriter.WriteLine(TimeStamp)
 
FileWriter.Close
 
'WRITE TO ERROR LOG IF FILE

Open in new window

0
 
gregcmcseCommented:
The only addition I'd make to SirBounty's code is a much easier way of handling the array (and should execute MUCH faster).  Use the split function to create an array with each line in its own element in one shot as below.  REDIM PRESERVE is horrifically expensive in terms of execution cycles.

Note:  You MAY get an error on the split due to line 21.  If you do, change the line:

Dim FileContents()
  to
Dim FileContents

or just delete it entirely.
strTemp = ""
Do Until objFile.AtEndOfStream
  strTemp = F.ReadAll
Loop
FileContents = Split(strTemp,vbCrLf)
 
  

Open in new window

0
 
jkovbaAuthor Commented:
Thank you SirBounty for the precise solution, and thanks also to gregmcse for a great suggestion to improve performance.
0

Featured Post

Free Tool: Path Explorer

An intuitive utility to help find the CSS path to UI elements on a webpage. These paths are used frequently in a variety of front-end development and QA automation tasks.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now