Want to protect your cyber security and still get fast solutions? Ask a secure question today.Go Premium

x
?
Solved

recursive problem

Posted on 2008-10-05
11
Medium Priority
?
311 Views
Last Modified: 2012-05-05
I have a recursive program that is suppose to return the square root of a number recursivley, the program will run, but it returns 1. please help
#include <stdio.h>
 
 
 
double square_root(double low, double high);
 
int main(void)
{
    float number;
    double root;
    
    printf("Enter a number to compute the square root of.\n");
    scanf("%f", &number);
    
    root = square_root(1, number);
    
    printf("The square root of %.3f is about %.3lf\n", number, root);
    
    system("PAUSE");
    return 0;
}
 
	double square_root(double low, double high)
{
    float mid;
    
    mid = (high + low) / 2;
 
    //Base Case
    if((mid*mid) == high)
        return mid;
 
     //Stops when the high and low numbers are within 0.001 of one another.   
    if((high - low) < 0.001)
        return mid;
    
    if((mid*mid) > high)
        return square_root(low, mid);
        
    return square_root(mid, high);
}

Open in new window

0
Comment
Question by:mikeregas
  • 4
  • 3
  • 2
  • +1
10 Comments
 
LVL 85

Expert Comment

by:ozo
ID: 22646982
Are you sure you have the correct recursion?
The method you use looks like it would work better passing 3 numbers.
or else changing
0
 

Author Comment

by:mikeregas
ID: 22647108
I need to take a number say 19.7 and then it is suppose to return 4.438 is the example that I was given. I know that I am suppose to take two number the low which would be 0 and the high and which would be 19.7 and recursively bring it down to an approximate square root. So there would be a third number in the equation the  mid.
0
 
LVL 45

Expert Comment

by:sunnycoder
ID: 22647118
>square_root(1, number);
second arg is the number whose sq root you want.

Your recursive calls are
>return square_root(low, mid);<<<------ you are calculating sq root of mid!!
>return square_root(mid, high);

0
What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

 
LVL 1

Expert Comment

by:lakshmikarle
ID: 22647340
Hello mikergas,

You are using "Babylonian method" to calculate square root. You are not using it in right way.
For proer desciption of babylonian method can be found in link
http://personal.bgsu.edu/~carother/babylon/Examples.html

I am attaching modified and working version of your code..
<code edited out>
sunnycoder
ZAPE

Open in new window

0
 
LVL 1

Expert Comment

by:lakshmikarle
ID: 22648784
sunnycoder,
I will take care in future
0
 

Author Comment

by:mikeregas
ID: 22650155
I am confused on what is right in my code and what is wrong? can you please give me some direction to go in. my code is return a 1 for any number that I input and I know that is worng.
0
 
LVL 45

Expert Comment

by:sunnycoder
ID: 22650289
http:#22647118 lists your problem
http:#22646982 hints at a solution
0
 
LVL 1

Expert Comment

by:lakshmikarle
ID: 22650877
According to algorithm
x(n+1) = 1/2( x(n) + a / x(n) )

where a is the number for which square root should be calculated.
Change calculation of 'mid' to above formula.

Also, since you are always calling function recursively with low as 1, your answer is always converging to 1.

0
 

Author Comment

by:mikeregas
ID: 22651030
x(n+1) = 1/2( x(n) + a / x(n) ) let me make sure that I understand this. if a is the number that I am trying to get the root of then x is a function of what? I am truely lost with recursion
0
 
LVL 1

Accepted Solution

by:
lakshmikarle earned 1500 total points
ID: 22651108
n can take values like 0,1,2,3
Assume x(0) = 1.
Go thru the link I have posted
0

Featured Post

What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Have you thought about creating an iPhone application (app), but didn't even know where to get started? Here's how: ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ Important pre-programming comments: I’ve never tri…
Summary: This tutorial covers some basics of pointer, pointer arithmetic and function pointer. What is a pointer: A pointer is a variable which holds an address. This address might be address of another variable/address of devices/address of fu…
The goal of this video is to provide viewers with basic examples to understand and use pointers in the C programming language.
The goal of this video is to provide viewers with basic examples to understand opening and writing to files in the C programming language.
Suggested Courses

581 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question