Solved

Why isn't my array printing w/in function?

Posted on 2008-10-06
10
185 Views
Last Modified: 2012-05-05
Why isn't my array printing w/in the prinArray function?  It prints if in main, but I need it to reside in a function.  Please help.  Below is my code.


public class yamotdProtocol {
 

	static String[] message = new String[5];

	static Scanner is = null;

	static String m = null;

	private static String line;

	private static String msgget = "MSGGET";

	

	public static void main(String args[]) throws IOException {

	

	try {

		

		is = new Scanner(new FileInputStream("C:\\messages.txt"));

	}

	

	catch(FileNotFoundException e){}

	

	for(int i=0; i<message.length; i++)

	{

		line = is.nextLine();

		message[i] = line;

	}

	

	for(int n =0; n<message.length; n++)

		System.out.println(message[n]);

	}

	

	public void printArray(){

		

		for(int n =0; n<message.length; n++)

			System.out.println(message[n]);

	}

}

Open in new window

0
Comment
Question by:deliachang
  • 4
  • 4
  • 2
10 Comments
 
LVL 24

Expert Comment

by:sciuriware
Comment Utility
Because 'printArray() is a separate method, that's never called.

;JOOP!
0
 
LVL 8

Accepted Solution

by:
mnrz earned 500 total points
Comment Utility
it will, but you have to call that method
check this:


public class yamotdProtocol {

 

        static String[] message = new String[5];

        static Scanner is = null;

        static String m = null;

        private static String line;

        private static String msgget = "MSGGET";

        

        public static void main(String args[]) throws IOException {

        

        try {

                

                is = new Scanner(new FileInputStream("C:\\messages.txt"));

        }

        

        catch(FileNotFoundException e){}

        

        for(int i=0; i<message.length; i++)

        {

                line = is.nextLine();

                message[i] = line;

        }

        

        /*for(int n =0; n<message.length; n++)

                System.out.println(message[n]);

         */

        yamotdProtocol instance = new yamotdProtocol();

        instance.printArray()  ;

        }

        

        public void printArray(){

                

                for(int n =0; n<message.length; n++)

                        System.out.println(message[n]);

        }

}

Open in new window

0
 
LVL 24

Expert Comment

by:sciuriware
Comment Utility
Change your code to something like this:

public class yamotdProtocol
{
   static String[] message = new String[5];
   static Scanner is = null;
   static String m = null;
   private static String line;
   private static String msgget = "MSGGET";

   public static void main(String args[]) throws IOException
   {
      try
      {
         is = new Scanner(new FileInputStream("C:\\messages.txt"));
      }
      catch(FileNotFoundException e){ /* No action */ }

      for(int i = 0; i < message.length; i++)
      {
         line = is.nextLine();
         message[i] = line;
      }

      for(int n = 0; n < message.length; n++)
         System.out.println(message[n]);
     
      printArray();  // This makes sense!!!!
   }
   
   public static void printArray()
   {

      for(int n = 0; n < message.length; n++)
         System.out.println(message[n]);
   }

}

;JOOP!
0
 
LVL 8

Expert Comment

by:mnrz
Comment Utility
or you can declare that method as static:

also please note in Java we don't say function, method is used instead

public static void printArray(){

                

                for(int n =0; n<message.length; n++)

                        System.out.println(message[n]);

        }

Open in new window

0
 
LVL 24

Expert Comment

by:sciuriware
Comment Utility
I disagree with mnrz: printArray() was embedded inside 'main()'
by bad positioning of { } and it was not called.

;JOOP!
0
Why You Should Analyze Threat Actor TTPs

After years of analyzing threat actor behavior, it’s become clear that at any given time there are specific tactics, techniques, and procedures (TTPs) that are particularly prevalent. By analyzing and understanding these TTPs, you can dramatically enhance your security program.

 

Author Comment

by:deliachang
Comment Utility
mnrz, your solution work.  I do have another question and not sure if it can work.  Can I call this function from another class within the same package?

If I declare the an instance of the protocol class in another class, I get nothing but nulls.  Why is this?
public String printArray(String userInput){

		

		String theOutput = userInput;

				

		if (theOutput.equals("MSGGET"))

			theOutput = "It works." + message[0];

		

		return theOutput;

	}

Open in new window

0
 

Author Closing Comment

by:deliachang
Comment Utility
Thank you so much.  I actually got it working - even calling it from another class.
0
 
LVL 24

Expert Comment

by:sciuriware
Comment Utility
Thanks deliachang.

;JOOP!
0
 
LVL 8

Expert Comment

by:mnrz
Comment Utility
sciuriware
no the closing bracket was in right place but the indent was not correct.

deliachang
since the method is declared as public you can call this method from another class but the process in which your message array is populating is placed in main() method and this method is static, so you have to call it before printArray()

check this example out:
 
0
 
LVL 8

Expert Comment

by:mnrz
Comment Utility
sorry this is example:

public class YourClassName {

 

        String[] message = new String[5];

        Scanner is = null;

        String m = null;

        private String line;

        private String msgget = "MSGGET";

        

        public void populateArray() throws IOException {

        

        try {

                

                is = new Scanner(new FileInputStream("C:\\messages.txt"));

        }

        

        catch(FileNotFoundException e){}

        

        for(int i=0; i<message.length; i++)

        {

                line = is.nextLine();

                message[i] = line;

        }

      }

        

        public void printArray(){

                

                for(int n =0; n<message.length; n++)

                        System.out.println(message[n]);

        }
 

public String printArray(String userInput){

                

                String theOutput = userInput;

                                

                if (theOutput.equals("MSGGET"))

                        theOutput = "It works." + message[0];

                

                return theOutput;

        }

}
 

// in other class

public class AnotherClass {
 
 

        public static void main(String[] a) {

             YourClassName instance = new YourClassName();

             instance.populateArray();

             instance.printArray();

              instance.printArray("MSGGET");

         }

}

Open in new window

0

Featured Post

How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

Join & Write a Comment

By the end of 1980s, object oriented programming using languages like C++, Simula69 and ObjectPascal gained momentum. It looked like programmers finally found the perfect language. C++ successfully combined the object oriented principles of Simula w…
Introduction This article is the first of three articles that explain why and how the Experts Exchange QA Team does test automation for our web site. This article explains our test automation goals. Then rationale is given for the tools we use to a…
Viewers will learn about the different types of variables in Java and how to declare them. Decide the type of variable desired: Put the keyword corresponding to the type of variable in front of the variable name: Use the equal sign to assign a v…
This tutorial covers a practical example of lazy loading technique and early loading technique in a Singleton Design Pattern.

771 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

16 Experts available now in Live!

Get 1:1 Help Now