Solved

Why isn't my array printing w/in function?

Posted on 2008-10-06
10
187 Views
Last Modified: 2012-05-05
Why isn't my array printing w/in the prinArray function?  It prints if in main, but I need it to reside in a function.  Please help.  Below is my code.


public class yamotdProtocol {
 
	static String[] message = new String[5];
	static Scanner is = null;
	static String m = null;
	private static String line;
	private static String msgget = "MSGGET";
	
	public static void main(String args[]) throws IOException {
	
	try {
		
		is = new Scanner(new FileInputStream("C:\\messages.txt"));
	}
	
	catch(FileNotFoundException e){}
	
	for(int i=0; i<message.length; i++)
	{
		line = is.nextLine();
		message[i] = line;
	}
	
	for(int n =0; n<message.length; n++)
		System.out.println(message[n]);
	}
	
	public void printArray(){
		
		for(int n =0; n<message.length; n++)
			System.out.println(message[n]);
	}
}

Open in new window

0
Comment
Question by:deliachang
  • 4
  • 4
  • 2
10 Comments
 
LVL 24

Expert Comment

by:sciuriware
ID: 22651345
Because 'printArray() is a separate method, that's never called.

;JOOP!
0
 
LVL 8

Accepted Solution

by:
mnrz earned 500 total points
ID: 22651401
it will, but you have to call that method
check this:


public class yamotdProtocol {
 
        static String[] message = new String[5];
        static Scanner is = null;
        static String m = null;
        private static String line;
        private static String msgget = "MSGGET";
        
        public static void main(String args[]) throws IOException {
        
        try {
                
                is = new Scanner(new FileInputStream("C:\\messages.txt"));
        }
        
        catch(FileNotFoundException e){}
        
        for(int i=0; i<message.length; i++)
        {
                line = is.nextLine();
                message[i] = line;
        }
        
        /*for(int n =0; n<message.length; n++)
                System.out.println(message[n]);
         */
        yamotdProtocol instance = new yamotdProtocol();
        instance.printArray()  ;
        }
        
        public void printArray(){
                
                for(int n =0; n<message.length; n++)
                        System.out.println(message[n]);
        }
}

Open in new window

0
 
LVL 24

Expert Comment

by:sciuriware
ID: 22651409
Change your code to something like this:

public class yamotdProtocol
{
   static String[] message = new String[5];
   static Scanner is = null;
   static String m = null;
   private static String line;
   private static String msgget = "MSGGET";

   public static void main(String args[]) throws IOException
   {
      try
      {
         is = new Scanner(new FileInputStream("C:\\messages.txt"));
      }
      catch(FileNotFoundException e){ /* No action */ }

      for(int i = 0; i < message.length; i++)
      {
         line = is.nextLine();
         message[i] = line;
      }

      for(int n = 0; n < message.length; n++)
         System.out.println(message[n]);
     
      printArray();  // This makes sense!!!!
   }
   
   public static void printArray()
   {

      for(int n = 0; n < message.length; n++)
         System.out.println(message[n]);
   }

}

;JOOP!
0
Announcing the Most Valuable Experts of 2016

MVEs are more concerned with the satisfaction of those they help than with the considerable points they can earn. They are the types of people you feel privileged to call colleagues. Join us in honoring this amazing group of Experts.

 
LVL 8

Expert Comment

by:mnrz
ID: 22651423
or you can declare that method as static:

also please note in Java we don't say function, method is used instead

public static void printArray(){
                
                for(int n =0; n<message.length; n++)
                        System.out.println(message[n]);
        }

Open in new window

0
 
LVL 24

Expert Comment

by:sciuriware
ID: 22651705
I disagree with mnrz: printArray() was embedded inside 'main()'
by bad positioning of { } and it was not called.

;JOOP!
0
 

Author Comment

by:deliachang
ID: 22651749
mnrz, your solution work.  I do have another question and not sure if it can work.  Can I call this function from another class within the same package?

If I declare the an instance of the protocol class in another class, I get nothing but nulls.  Why is this?
public String printArray(String userInput){
		
		String theOutput = userInput;
				
		if (theOutput.equals("MSGGET"))
			theOutput = "It works." + message[0];
		
		return theOutput;
	}

Open in new window

0
 

Author Closing Comment

by:deliachang
ID: 31503472
Thank you so much.  I actually got it working - even calling it from another class.
0
 
LVL 24

Expert Comment

by:sciuriware
ID: 22651948
Thanks deliachang.

;JOOP!
0
 
LVL 8

Expert Comment

by:mnrz
ID: 22652042
sciuriware
no the closing bracket was in right place but the indent was not correct.

deliachang
since the method is declared as public you can call this method from another class but the process in which your message array is populating is placed in main() method and this method is static, so you have to call it before printArray()

check this example out:
 
0
 
LVL 8

Expert Comment

by:mnrz
ID: 22652117
sorry this is example:

public class YourClassName {
 
        String[] message = new String[5];
        Scanner is = null;
        String m = null;
        private String line;
        private String msgget = "MSGGET";
        
        public void populateArray() throws IOException {
        
        try {
                
                is = new Scanner(new FileInputStream("C:\\messages.txt"));
        }
        
        catch(FileNotFoundException e){}
        
        for(int i=0; i<message.length; i++)
        {
                line = is.nextLine();
                message[i] = line;
        }
      }
        
        public void printArray(){
                
                for(int n =0; n<message.length; n++)
                        System.out.println(message[n]);
        }
 
public String printArray(String userInput){
                
                String theOutput = userInput;
                                
                if (theOutput.equals("MSGGET"))
                        theOutput = "It works." + message[0];
                
                return theOutput;
        }
}
 
// in other class
public class AnotherClass {
 
 
        public static void main(String[] a) {
             YourClassName instance = new YourClassName();
             instance.populateArray();
             instance.printArray();
              instance.printArray("MSGGET");
         }
}

Open in new window

0

Featured Post

Gigs: Get Your Project Delivered by an Expert

Select from freelancers specializing in everything from database administration to programming, who have proven themselves as experts in their field. Hire the best, collaborate easily, pay securely and get projects done right.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
How to get all the API from website? 11 82
JDeveloper 12c for 32 bit 4 84
eclipse shortcuts 9 54
jsp login check 12 27
By the end of 1980s, object oriented programming using languages like C++, Simula69 and ObjectPascal gained momentum. It looked like programmers finally found the perfect language. C++ successfully combined the object oriented principles of Simula w…
Java functions are among the best things for programmers to work with as Java sites can be very easy to read and prepare. Java especially simplifies many processes in the coding industry as it helps integrate many forms of technology and different d…
Viewers will learn about if statements in Java and their use The if statement: The condition required to create an if statement: Variations of if statements: An example using if statements:
This tutorial covers a step-by-step guide to install VisualVM launcher in eclipse.

816 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

10 Experts available now in Live!

Get 1:1 Help Now