• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 208
  • Last Modified:

Why isn't my array printing w/in function?

Why isn't my array printing w/in the prinArray function?  It prints if in main, but I need it to reside in a function.  Please help.  Below is my code.


public class yamotdProtocol {
 
	static String[] message = new String[5];
	static Scanner is = null;
	static String m = null;
	private static String line;
	private static String msgget = "MSGGET";
	
	public static void main(String args[]) throws IOException {
	
	try {
		
		is = new Scanner(new FileInputStream("C:\\messages.txt"));
	}
	
	catch(FileNotFoundException e){}
	
	for(int i=0; i<message.length; i++)
	{
		line = is.nextLine();
		message[i] = line;
	}
	
	for(int n =0; n<message.length; n++)
		System.out.println(message[n]);
	}
	
	public void printArray(){
		
		for(int n =0; n<message.length; n++)
			System.out.println(message[n]);
	}
}

Open in new window

0
deliachang
Asked:
deliachang
  • 4
  • 4
  • 2
1 Solution
 
sciuriwareCommented:
Because 'printArray() is a separate method, that's never called.

;JOOP!
0
 
mnrzCommented:
it will, but you have to call that method
check this:


public class yamotdProtocol {
 
        static String[] message = new String[5];
        static Scanner is = null;
        static String m = null;
        private static String line;
        private static String msgget = "MSGGET";
        
        public static void main(String args[]) throws IOException {
        
        try {
                
                is = new Scanner(new FileInputStream("C:\\messages.txt"));
        }
        
        catch(FileNotFoundException e){}
        
        for(int i=0; i<message.length; i++)
        {
                line = is.nextLine();
                message[i] = line;
        }
        
        /*for(int n =0; n<message.length; n++)
                System.out.println(message[n]);
         */
        yamotdProtocol instance = new yamotdProtocol();
        instance.printArray()  ;
        }
        
        public void printArray(){
                
                for(int n =0; n<message.length; n++)
                        System.out.println(message[n]);
        }
}

Open in new window

0
 
sciuriwareCommented:
Change your code to something like this:

public class yamotdProtocol
{
   static String[] message = new String[5];
   static Scanner is = null;
   static String m = null;
   private static String line;
   private static String msgget = "MSGGET";

   public static void main(String args[]) throws IOException
   {
      try
      {
         is = new Scanner(new FileInputStream("C:\\messages.txt"));
      }
      catch(FileNotFoundException e){ /* No action */ }

      for(int i = 0; i < message.length; i++)
      {
         line = is.nextLine();
         message[i] = line;
      }

      for(int n = 0; n < message.length; n++)
         System.out.println(message[n]);
     
      printArray();  // This makes sense!!!!
   }
   
   public static void printArray()
   {

      for(int n = 0; n < message.length; n++)
         System.out.println(message[n]);
   }

}

;JOOP!
0
Cloud Class® Course: Certified Penetration Testing

This CPTE Certified Penetration Testing Engineer course covers everything you need to know about becoming a Certified Penetration Testing Engineer. Career Path: Professional roles include Ethical Hackers, Security Consultants, System Administrators, and Chief Security Officers.

 
mnrzCommented:
or you can declare that method as static:

also please note in Java we don't say function, method is used instead

public static void printArray(){
                
                for(int n =0; n<message.length; n++)
                        System.out.println(message[n]);
        }

Open in new window

0
 
sciuriwareCommented:
I disagree with mnrz: printArray() was embedded inside 'main()'
by bad positioning of { } and it was not called.

;JOOP!
0
 
deliachangAuthor Commented:
mnrz, your solution work.  I do have another question and not sure if it can work.  Can I call this function from another class within the same package?

If I declare the an instance of the protocol class in another class, I get nothing but nulls.  Why is this?
public String printArray(String userInput){
		
		String theOutput = userInput;
				
		if (theOutput.equals("MSGGET"))
			theOutput = "It works." + message[0];
		
		return theOutput;
	}

Open in new window

0
 
deliachangAuthor Commented:
Thank you so much.  I actually got it working - even calling it from another class.
0
 
sciuriwareCommented:
Thanks deliachang.

;JOOP!
0
 
mnrzCommented:
sciuriware
no the closing bracket was in right place but the indent was not correct.

deliachang
since the method is declared as public you can call this method from another class but the process in which your message array is populating is placed in main() method and this method is static, so you have to call it before printArray()

check this example out:
 
0
 
mnrzCommented:
sorry this is example:

public class YourClassName {
 
        String[] message = new String[5];
        Scanner is = null;
        String m = null;
        private String line;
        private String msgget = "MSGGET";
        
        public void populateArray() throws IOException {
        
        try {
                
                is = new Scanner(new FileInputStream("C:\\messages.txt"));
        }
        
        catch(FileNotFoundException e){}
        
        for(int i=0; i<message.length; i++)
        {
                line = is.nextLine();
                message[i] = line;
        }
      }
        
        public void printArray(){
                
                for(int n =0; n<message.length; n++)
                        System.out.println(message[n]);
        }
 
public String printArray(String userInput){
                
                String theOutput = userInput;
                                
                if (theOutput.equals("MSGGET"))
                        theOutput = "It works." + message[0];
                
                return theOutput;
        }
}
 
// in other class
public class AnotherClass {
 
 
        public static void main(String[] a) {
             YourClassName instance = new YourClassName();
             instance.populateArray();
             instance.printArray();
              instance.printArray("MSGGET");
         }
}

Open in new window

0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Cloud Class® Course: SQL Server Core 2016

This course will introduce you to SQL Server Core 2016, as well as teach you about SSMS, data tools, installation, server configuration, using Management Studio, and writing and executing queries.

  • 4
  • 4
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now